You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/06/01 08:23:48 UTC

[GitHub] [fineract] vorburger commented on pull request #813: add (Quartz's) LoggingTriggerHistoryPlugin (re. FINERACT-922)

vorburger commented on pull request #813:
URL: https://github.com/apache/fineract/pull/813#issuecomment-636692368


   > add this to a property file so you can then comment the property in / out when testing - but without needing to recompile: `org.quartz.plugin.triggHistory.class = org.quartz.plugins.history.LoggingTriggerHistoryPlugin`
   
   @ptuomola yeah, makes sense, as per http://www.quartz-scheduler.org/documentation/quartz-2.3.0/configuration/ConfigPlugins.html. But actually, looking at this against after a bit of time, and re-comparing it with my other #812, I see that this probably won't really add any more additional useful information anyway, and the logging levels in (my) `SchedulerTriggerListener` are better.
   
   >> Please don't merge this one just yet; I want to do some more local tests to compare this VS #812.
   > Let's actually merge this... together with, not instead of #812 - having both shouldn't do any harm - 
   
   I'll therefore "abandon" (close without merge) this proposal, after all.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org