You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/12/16 00:51:21 UTC

[GitHub] [arrow] Yuhta opened a new pull request #8933: ARROW-10932: [C++] BinaryMemoTable::CopyOffsets access out-of-bound address when data is empty

Yuhta opened a new pull request #8933:
URL: https://github.com/apache/arrow/pull/8933


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] pitrou commented on a change in pull request #8933: ARROW-10932: [C++] BinaryMemoTable::CopyOffsets access out-of-bound address when data is empty

Posted by GitBox <gi...@apache.org>.
pitrou commented on a change in pull request #8933:
URL: https://github.com/apache/arrow/pull/8933#discussion_r544382794



##########
File path: cpp/src/arrow/util/hashing.h
##########
@@ -690,7 +690,8 @@ class BinaryMemoTable : public MemoTable {
     DCHECK_LE(start, size());
 
     const builder_offset_type* offsets = binary_builder_.offsets_data();
-    const builder_offset_type delta = offsets[start];
+    const builder_offset_type delta =
+        start < binary_builder_.value_data_length() ? offsets[start] : 0;

Review comment:
       Can you post a followup PR (just reuse the same JIRA number)?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on pull request #8933: ARROW-10932: [C++] BinaryMemoTable::CopyOffsets access out-of-bound address when data is empty

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8933:
URL: https://github.com/apache/arrow/pull/8933#issuecomment-745702299


   https://issues.apache.org/jira/browse/ARROW-10932


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] Yuhta commented on a change in pull request #8933: ARROW-10932: [C++] BinaryMemoTable::CopyOffsets access out-of-bound address when data is empty

Posted by GitBox <gi...@apache.org>.
Yuhta commented on a change in pull request #8933:
URL: https://github.com/apache/arrow/pull/8933#discussion_r544379156



##########
File path: cpp/src/arrow/util/hashing.h
##########
@@ -690,7 +690,8 @@ class BinaryMemoTable : public MemoTable {
     DCHECK_LE(start, size());
 
     const builder_offset_type* offsets = binary_builder_.offsets_data();
-    const builder_offset_type delta = offsets[start];
+    const builder_offset_type delta =
+        start < binary_builder_.value_data_length() ? offsets[start] : 0;

Review comment:
       I made a mistake here, `binary_builder_.value_data_length()` should be `binary_builder_.length()`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] pitrou closed pull request #8933: ARROW-10932: [C++] BinaryMemoTable::CopyOffsets access out-of-bound address when data is empty

Posted by GitBox <gi...@apache.org>.
pitrou closed pull request #8933:
URL: https://github.com/apache/arrow/pull/8933


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] pitrou commented on pull request #8933: ARROW-10932: [C++] BinaryMemoTable::CopyOffsets access out-of-bound address when data is empty

Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #8933:
URL: https://github.com/apache/arrow/pull/8933#issuecomment-746033058


   The CI failures are unrelated, will merge.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org