You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by GitBox <gi...@apache.org> on 2021/01/25 08:52:06 UTC
[GitHub] [httpcomponents-core] ncapponi opened a new pull request #246: HTTPCORE-659 Race condition in IOSessionImpl when setting event
ncapponi opened a new pull request #246:
URL: https://github.com/apache/httpcomponents-core/pull/246
I'm not including change on `setEventMask(final int newValue)` method as there is currently no lock and I have no knowledge on its usage. Tell me if you want this modification as well.
I'm not including a new test case because the race condition is quite hard to reproduce without some "artificial" help like making the code sleep in the `setEvent()` method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] ok2c merged pull request #246: HTTPCORE-659 Race condition in IOSessionImpl when setting event
Posted by GitBox <gi...@apache.org>.
ok2c merged pull request #246:
URL: https://github.com/apache/httpcomponents-core/pull/246
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] ncapponi commented on pull request #246: HTTPCORE-659 Race condition in IOSessionImpl when setting event
Posted by GitBox <gi...@apache.org>.
ncapponi commented on pull request #246:
URL: https://github.com/apache/httpcomponents-core/pull/246#issuecomment-767377749
Thanks !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] ncapponi commented on pull request #246: HTTPCORE-659 Race condition in IOSessionImpl when setting event
Posted by GitBox <gi...@apache.org>.
ncapponi commented on pull request #246:
URL: https://github.com/apache/httpcomponents-core/pull/246#issuecomment-767072661
@ok2c done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] ok2c commented on pull request #246: HTTPCORE-659 Race condition in IOSessionImpl when setting event
Posted by GitBox <gi...@apache.org>.
ok2c commented on pull request #246:
URL: https://github.com/apache/httpcomponents-core/pull/246#issuecomment-767059393
@ncapponi Please do introduce locking to `#setEventMask`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] ncapponi commented on pull request #246: HTTPCORE-659 Race condition in IOSessionImpl when setting event
Posted by GitBox <gi...@apache.org>.
ncapponi commented on pull request #246:
URL: https://github.com/apache/httpcomponents-core/pull/246#issuecomment-767072661
@ok2c done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] ok2c commented on pull request #246: HTTPCORE-659 Race condition in IOSessionImpl when setting event
Posted by GitBox <gi...@apache.org>.
ok2c commented on pull request #246:
URL: https://github.com/apache/httpcomponents-core/pull/246#issuecomment-767059393
@ncapponi Please do introduce locking to `#setEventMask`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org