You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Pallav Kulshreshtha <pa...@gmail.com> on 2017/01/27 18:20:35 UTC

Review Request 56030: Hive View 2.0 execute button needs some feedback

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56030/
-----------------------------------------------------------

Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and Rohit Choudhary.


Bugs: AMBARI-19752
    https://issues.apache.org/jira/browse/AMBARI-19752


Repository: ambari


Description
-------

Added fontawesome animation while query is in progress.


Diffs
-----

  contrib/views/hive20/src/main/resources/ui/app/services/jobs.js 5d7ce77 
  contrib/views/hive20/src/main/resources/ui/app/styles/app.scss e178222 
  contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs 9e9e542 

Diff: https://reviews.apache.org/r/56030/diff/


Testing
-------

manually tested.


Thanks,

Pallav Kulshreshtha


Re: Review Request 56030: Hive View 2.0 execute button needs some feedback

Posted by Gaurav Nagar <gn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56030/#review163386
-----------------------------------------------------------


Ship it!




Ship It!

- Gaurav Nagar


On Jan. 27, 2017, 6:20 p.m., Pallav Kulshreshtha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56030/
> -----------------------------------------------------------
> 
> (Updated Jan. 27, 2017, 6:20 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-19752
>     https://issues.apache.org/jira/browse/AMBARI-19752
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Added fontawesome animation while query is in progress.
> 
> 
> Diffs
> -----
> 
>   contrib/views/hive20/src/main/resources/ui/app/services/jobs.js 5d7ce77 
>   contrib/views/hive20/src/main/resources/ui/app/styles/app.scss e178222 
>   contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs 9e9e542 
> 
> Diff: https://reviews.apache.org/r/56030/diff/
> 
> 
> Testing
> -------
> 
> manually tested.
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>


Re: Review Request 56030: Hive View 2.0 execute button needs some feedback

Posted by Nitiraj Rathore <ni...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56030/#review163466
-----------------------------------------------------------


Ship it!




Ship It!

- Nitiraj Rathore


On Jan. 27, 2017, 6:20 p.m., Pallav Kulshreshtha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56030/
> -----------------------------------------------------------
> 
> (Updated Jan. 27, 2017, 6:20 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-19752
>     https://issues.apache.org/jira/browse/AMBARI-19752
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Added fontawesome animation while query is in progress.
> 
> 
> Diffs
> -----
> 
>   contrib/views/hive20/src/main/resources/ui/app/services/jobs.js 5d7ce77 
>   contrib/views/hive20/src/main/resources/ui/app/styles/app.scss e178222 
>   contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs 9e9e542 
> 
> Diff: https://reviews.apache.org/r/56030/diff/
> 
> 
> Testing
> -------
> 
> manually tested.
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>