You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by Tom van Dijk <to...@tvandijk.nl> on 2011/03/16 17:55:26 UTC
TAP-1320
Hi,
I would like the patch in TAP-1320 (modifications to ServiceActivity) to
be accepted. Is there any reason why this can't be done? If none, I
would be happy if someone could be assigned to it.
Tom.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
Re: TAP-1320
Posted by Tom van Dijk <to...@tvandijk.nl>.
Solved, added a test that tests that the perThread case is handled
correctly, plus I modified the existing test to cover getMarkers().
Op 16-3-2011 19:20, Tom van Dijk schreef:
> Okay, I'll make one as soon as I'm done with my current task list.
>
> Op 16-3-2011 19:18, Kalle Korhonen schreef:
>> No unit test. At least it should be unit tested that perThreadStatus
>> gets properly initialized and used when you ask for status. Beyond
>> that, some patches may not get applied right away if it's unclear
>> whether a proposed approach is the right approach (even if the
>> implementation itself was trivial). That said, this makes sense to me
>> - I could apply and we can always reconsider later. If you care, write
>> the unit test, add it to the issue and I'll apply it as soon as it's
>> in, otherwise need to wait for me or somebody else to write test and
>> apply.
>>
>> Kalle
>>
>>
>> On Wed, Mar 16, 2011 at 9:55 AM, Tom van Dijk<to...@tvandijk.nl> wrote:
>>> Hi,
>>>
>>> I would like the patch in TAP-1320 (modifications to
>>> ServiceActivity) to be
>>> accepted. Is there any reason why this can't be done? If none, I
>>> would be
>>> happy if someone could be assigned to it.
>>>
>>> Tom.
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
>>> For additional commands, e-mail: dev-help@tapestry.apache.org
>>>
>>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
>> For additional commands, e-mail: dev-help@tapestry.apache.org
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
> For additional commands, e-mail: dev-help@tapestry.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
Re: TAP-1320
Posted by Tom van Dijk <to...@tvandijk.nl>.
Okay, I'll make one as soon as I'm done with my current task list.
Op 16-3-2011 19:18, Kalle Korhonen schreef:
> No unit test. At least it should be unit tested that perThreadStatus
> gets properly initialized and used when you ask for status. Beyond
> that, some patches may not get applied right away if it's unclear
> whether a proposed approach is the right approach (even if the
> implementation itself was trivial). That said, this makes sense to me
> - I could apply and we can always reconsider later. If you care, write
> the unit test, add it to the issue and I'll apply it as soon as it's
> in, otherwise need to wait for me or somebody else to write test and
> apply.
>
> Kalle
>
>
> On Wed, Mar 16, 2011 at 9:55 AM, Tom van Dijk<to...@tvandijk.nl> wrote:
>> Hi,
>>
>> I would like the patch in TAP-1320 (modifications to ServiceActivity) to be
>> accepted. Is there any reason why this can't be done? If none, I would be
>> happy if someone could be assigned to it.
>>
>> Tom.
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
>> For additional commands, e-mail: dev-help@tapestry.apache.org
>>
>>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
> For additional commands, e-mail: dev-help@tapestry.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
Re: TAP-1320
Posted by Kalle Korhonen <ka...@gmail.com>.
No unit test. At least it should be unit tested that perThreadStatus
gets properly initialized and used when you ask for status. Beyond
that, some patches may not get applied right away if it's unclear
whether a proposed approach is the right approach (even if the
implementation itself was trivial). That said, this makes sense to me
- I could apply and we can always reconsider later. If you care, write
the unit test, add it to the issue and I'll apply it as soon as it's
in, otherwise need to wait for me or somebody else to write test and
apply.
Kalle
On Wed, Mar 16, 2011 at 9:55 AM, Tom van Dijk <to...@tvandijk.nl> wrote:
> Hi,
>
> I would like the patch in TAP-1320 (modifications to ServiceActivity) to be
> accepted. Is there any reason why this can't be done? If none, I would be
> happy if someone could be assigned to it.
>
> Tom.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
> For additional commands, e-mail: dev-help@tapestry.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org