[jira] [Commented] (GEODE-8562) Add a new serialization test and example that uses a class for the key

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GEODE-8562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17280331#comment-17280331 ] 

ASF GitHub Bot commented on GEODE-8562:
---------------------------------------

mmartell opened a new pull request #742:
URL: https://github.com/apache/geode-native/pull/742


   This PR updates the .NET ClassAsKey example to use only standard .NET types. Additional tweaks include:
   - switch to new Objects.Hash() to ensure hashCodes mache between client and server
   - remove public from CacheableString since no longer needed
   - print matching hashCode output and add to README.md


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Add a new serialization test and example that uses a class for the key
> ----------------------------------------------------------------------
>
>                 Key: GEODE-8562
>                 URL: https://issues.apache.org/jira/browse/GEODE-8562
>             Project: Geode
>          Issue Type: Improvement
>          Components: native client
>            Reporter: Michael Martell
>            Priority: Major
>              Labels: pull-request-available
>
> There appears to be no native client tests that use a class for the key.
> A new DataSerializable test should be added (new framework of course) that uses a class that implements DataSerializable for both the key and the value. Also, the test should be added for both C++ and .NET.
> Also update the existing put/get examples to include using a class as the key. Note, this will require Java code that instantiates the key class.
> Notes:
>  * 
>  Using a class as a key requires the equivalent Java class to be deployed, as well as an Instantiator for that class to be executed by the server on startup. An example of this is the QueryTest::DataSerializableQueryHaveCorrectValues which uses Position.cs and Position.java.
>  * In this existing test, Position.java needs to be deployed and instantiated because the test executes queries. In this new test, we need to deploy and instantiate the java code for the key class because it's a key not a value.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)