You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@quickstep.apache.org by zuyu <gi...@git.apache.org> on 2018/05/21 20:57:56 UTC

[GitHub] incubator-quickstep pull request #338: Fixed the gRPC Problem for Data Excha...

Github user zuyu commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/338#discussion_r189711855
  
    --- Diff: storage/StorageManager.cpp ---
    @@ -687,8 +687,13 @@ StorageManager::BlockHandle StorageManager::loadBlockOrBlob(
     #ifdef QUICKSTEP_DISTRIBUTED
         const string domain_network_address = getPeerDomainNetworkAddress(BlockIdUtil::Domain(block));
         DLOG(INFO) << "Pulling Block " << BlockIdUtil::ToString(block) << " from " << domain_network_address;
    +
    +    // Customize the grpc channel
    +    grpc::ChannelArguments channelArgs;
    +    channelArgs.SetMaxReceiveMessageSize(kGrpcChanelSize);
    --- End diff --
    
    Please add a condition wrapper based on the `GRPC` version number for this API call, since not every version has this API.


---