You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/05/04 16:39:29 UTC

[GitHub] [arrow] eerhardt commented on pull request #7032: ARROW-6603: [C#] Adds ArrayBuilder API to support writing null values + BooleanArray null support

eerhardt commented on pull request #7032:
URL: https://github.com/apache/arrow/pull/7032#issuecomment-623573368


   @mr-smidge - 
   I think that approach would be fine - especially if there are advantages (performance or otherwise?) that end-users get from a change like that.
   
   I looked at the C++ implementation, and it uses the same approach as you are describing:
   
   https://github.com/apache/arrow/blob/d13e8f3ed647b6623ef2cb517424b0afe75461dc/cpp/src/arrow/array/builder_base.h#L210
   
   https://github.com/apache/arrow/blob/d13e8f3ed647b6623ef2cb517424b0afe75461dc/cpp/src/arrow/buffer_builder.h#L269-L388


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org