You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by mi...@apache.org on 2022/09/14 20:24:15 UTC
[maven-shared-io] branch master updated (4794a8e -> f8f2633)
This is an automated email from the ASF dual-hosted git repository.
michaelo pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/maven-shared-io.git
from 4794a8e update CI url
new 64a4e5c MSHARED-1142 – remove rendundant error message
new b50a734 MSHARED-1142 fixes of tailing spaces
new f8f2633 [MSHARED-1143] Remove e.getMessage() duplication when e is passed as object
The 3 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
.../shared/io/download/DefaultDownloadManager.java | 17 ++++++++---------
1 file changed, 8 insertions(+), 9 deletions(-)
[maven-shared-io] 02/03: MSHARED-1142 fixes of tailing spaces
Posted by mi...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
michaelo pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/maven-shared-io.git
commit b50a734bbd9f9e175153e65e2afb2870c044d649
Author: Koziolek <bj...@gmail.com>
AuthorDate: Wed Sep 14 20:29:15 2022 +0200
MSHARED-1142 fixes of tailing spaces
---
.../maven/shared/io/download/DefaultDownloadManager.java | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/src/main/java/org/apache/maven/shared/io/download/DefaultDownloadManager.java b/src/main/java/org/apache/maven/shared/io/download/DefaultDownloadManager.java
index bcfe40c..a349599 100644
--- a/src/main/java/org/apache/maven/shared/io/download/DefaultDownloadManager.java
+++ b/src/main/java/org/apache/maven/shared/io/download/DefaultDownloadManager.java
@@ -100,7 +100,7 @@ public class DefaultDownloadManager
}
catch ( MalformedURLException e )
{
- throw new DownloadFailedException( url, "Download failed due to invalid URL. Reason: " + e.getMessage(),
+ throw new DownloadFailedException( url, "Download failed due to invalid URL.",
e );
}
@@ -113,7 +113,7 @@ public class DefaultDownloadManager
}
catch ( UnsupportedProtocolException e )
{
- throw new DownloadFailedException( url, "Download failed. ", e );
+ throw new DownloadFailedException( url, "Download failed.", e );
}
messageHolder.addMessage( "Using wagon: " + wagon + " to download: " + url );
@@ -128,7 +128,7 @@ public class DefaultDownloadManager
}
catch ( IOException e )
{
- throw new DownloadFailedException( url, "Failed to create temporary file target for download. ", e );
+ throw new DownloadFailedException( url, "Failed to create temporary file target for download.", e );
}
messageHolder.addMessage( "Download target is: " + downloaded.getAbsolutePath() );
@@ -155,11 +155,11 @@ public class DefaultDownloadManager
}
catch ( ConnectionException e )
{
- throw new DownloadFailedException( url, "Download failed. ", e );
+ throw new DownloadFailedException( url, "Download failed.", e );
}
catch ( AuthenticationException e )
{
- throw new DownloadFailedException( url, "Download failed. ", e );
+ throw new DownloadFailedException( url, "Download failed.", e );
}
messageHolder.addMessage( "Getting: " + remotePath );
@@ -175,15 +175,15 @@ public class DefaultDownloadManager
}
catch ( TransferFailedException e )
{
- throw new DownloadFailedException( url, "Download failed. ", e );
+ throw new DownloadFailedException( url, "Download failed.", e );
}
catch ( ResourceDoesNotExistException e )
{
- throw new DownloadFailedException( url, "Download failed. ", e );
+ throw new DownloadFailedException( url, "Download failed.", e );
}
catch ( AuthorizationException e )
{
- throw new DownloadFailedException( url, "Download failed. ", e );
+ throw new DownloadFailedException( url, "Download failed.", e );
}
finally
{
[maven-shared-io] 03/03: [MSHARED-1143] Remove e.getMessage() duplication when e is passed as object
Posted by mi...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
michaelo pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/maven-shared-io.git
commit f8f263321ab70119eebb16b426e3a38833fa0e42
Author: Koziolek <bj...@gmail.com>
AuthorDate: Wed Sep 14 22:05:57 2022 +0200
[MSHARED-1143] Remove e.getMessage() duplication when e is passed as object
This closes #17
---
.../maven/shared/io/download/DefaultDownloadManager.java | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/src/main/java/org/apache/maven/shared/io/download/DefaultDownloadManager.java b/src/main/java/org/apache/maven/shared/io/download/DefaultDownloadManager.java
index a349599..887f204 100644
--- a/src/main/java/org/apache/maven/shared/io/download/DefaultDownloadManager.java
+++ b/src/main/java/org/apache/maven/shared/io/download/DefaultDownloadManager.java
@@ -113,7 +113,7 @@ public class DefaultDownloadManager
}
catch ( UnsupportedProtocolException e )
{
- throw new DownloadFailedException( url, "Download failed.", e );
+ throw new DownloadFailedException( url, "Download failed", e );
}
messageHolder.addMessage( "Using wagon: " + wagon + " to download: " + url );
@@ -155,11 +155,11 @@ public class DefaultDownloadManager
}
catch ( ConnectionException e )
{
- throw new DownloadFailedException( url, "Download failed.", e );
+ throw new DownloadFailedException( url, "Download failed", e );
}
catch ( AuthenticationException e )
{
- throw new DownloadFailedException( url, "Download failed.", e );
+ throw new DownloadFailedException( url, "Download failed", e );
}
messageHolder.addMessage( "Getting: " + remotePath );
@@ -175,15 +175,15 @@ public class DefaultDownloadManager
}
catch ( TransferFailedException e )
{
- throw new DownloadFailedException( url, "Download failed.", e );
+ throw new DownloadFailedException( url, "Download failed", e );
}
catch ( ResourceDoesNotExistException e )
{
- throw new DownloadFailedException( url, "Download failed.", e );
+ throw new DownloadFailedException( url, "Download failed", e );
}
catch ( AuthorizationException e )
{
- throw new DownloadFailedException( url, "Download failed.", e );
+ throw new DownloadFailedException( url, "Download failed", e );
}
finally
{
[maven-shared-io] 01/03: MSHARED-1142 – remove rendundant error message
Posted by mi...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
michaelo pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/maven-shared-io.git
commit 64a4e5c7d74732975e021763460d07a793a13ddd
Author: Koziolek <bj...@gmail.com>
AuthorDate: Wed Sep 14 16:50:23 2022 +0200
MSHARED-1142 – remove rendundant error message
---
.../maven/shared/io/download/DefaultDownloadManager.java | 15 +++++++--------
1 file changed, 7 insertions(+), 8 deletions(-)
diff --git a/src/main/java/org/apache/maven/shared/io/download/DefaultDownloadManager.java b/src/main/java/org/apache/maven/shared/io/download/DefaultDownloadManager.java
index 5cf0087..bcfe40c 100644
--- a/src/main/java/org/apache/maven/shared/io/download/DefaultDownloadManager.java
+++ b/src/main/java/org/apache/maven/shared/io/download/DefaultDownloadManager.java
@@ -113,7 +113,7 @@ public class DefaultDownloadManager
}
catch ( UnsupportedProtocolException e )
{
- throw new DownloadFailedException( url, "Download failed. Reason: " + e.getMessage(), e );
+ throw new DownloadFailedException( url, "Download failed. ", e );
}
messageHolder.addMessage( "Using wagon: " + wagon + " to download: " + url );
@@ -128,8 +128,7 @@ public class DefaultDownloadManager
}
catch ( IOException e )
{
- throw new DownloadFailedException( url, "Failed to create temporary file target for download. Reason: "
- + e.getMessage(), e );
+ throw new DownloadFailedException( url, "Failed to create temporary file target for download. ", e );
}
messageHolder.addMessage( "Download target is: " + downloaded.getAbsolutePath() );
@@ -156,11 +155,11 @@ public class DefaultDownloadManager
}
catch ( ConnectionException e )
{
- throw new DownloadFailedException( url, "Download failed. Reason: " + e.getMessage(), e );
+ throw new DownloadFailedException( url, "Download failed. ", e );
}
catch ( AuthenticationException e )
{
- throw new DownloadFailedException( url, "Download failed. Reason: " + e.getMessage(), e );
+ throw new DownloadFailedException( url, "Download failed. ", e );
}
messageHolder.addMessage( "Getting: " + remotePath );
@@ -176,15 +175,15 @@ public class DefaultDownloadManager
}
catch ( TransferFailedException e )
{
- throw new DownloadFailedException( url, "Download failed. Reason: " + e.getMessage(), e );
+ throw new DownloadFailedException( url, "Download failed. ", e );
}
catch ( ResourceDoesNotExistException e )
{
- throw new DownloadFailedException( url, "Download failed. Reason: " + e.getMessage(), e );
+ throw new DownloadFailedException( url, "Download failed. ", e );
}
catch ( AuthorizationException e )
{
- throw new DownloadFailedException( url, "Download failed. Reason: " + e.getMessage(), e );
+ throw new DownloadFailedException( url, "Download failed. ", e );
}
finally
{