You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@velocity.apache.org by "Claude Brisson (JIRA)" <ji...@apache.org> on 2016/07/15 07:35:20 UTC

[jira] [Resolved] (VELOCITY-793) Change ResourceLoader.getResourceStream to getResourceReader

     [ https://issues.apache.org/jira/browse/VELOCITY-793?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Claude Brisson resolved VELOCITY-793.
-------------------------------------
    Resolution: Fixed

Commited, with backward compatibility.

> Change ResourceLoader.getResourceStream to getResourceReader
> ------------------------------------------------------------
>
>                 Key: VELOCITY-793
>                 URL: https://issues.apache.org/jira/browse/VELOCITY-793
>             Project: Velocity
>          Issue Type: Wish
>          Components: Engine
>            Reporter: Christopher Schultz
>             Fix For: 2.x
>
>
> It would be nice to use Readers instead of InputStreams for templates.
> Velocity is all about text-based rendering, so the templates are certainly going to be text-based. Using a Reader allows individual readers to determine the character encoding if necessary (say, from a database) and not have another component second-guess them.
> Of course, this is a serious change to the API. We could possible re-implement getResourceStream to read a Reader and provide bytes as backward-compatibility with older client code, but since we're going to 2.0, this would be the time to make breaking changes to the API.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org