You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by "Dave Sag (JIRA)" <ji...@codehaus.org> on 2005/10/08 09:37:11 UTC
[jira] Created: (MNG-1136) clover breaks when encountering assert statements.
clover breaks when encountering assert statements.
--------------------------------------------------
Key: MNG-1136
URL: http://jira.codehaus.org/browse/MNG-1136
Project: Maven 2
Type: Bug
Components: maven-clover-plugin
Versions: 2.0-beta-3
Environment: any
Reporter: Dave Sag
the clover plugin is breaking on the line
assert result != null : "the result should not be null";
saying
[INFO] Reason: Clover has failed to instrument the source files
i can only assume that this is because clover does not understand the assert, or is assuming java 1.3? eitherway it's no use to me until this is fixed.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MNG-1136) clover breaks when encountering assert statements.
Posted by "Vincent Massol (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-1136?page=comments#action_49144 ]
Vincent Massol commented on MNG-1136:
-------------------------------------
Thanks Dave. That did it. I've fixed this. You'll now need to specify the jdk in the plugin's configuraiton. For example:
[...]
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-clover-plugin</artifactId>
<configuration>
<jdk>1.4</jdk>
</configuration>
[...]
I don't think you need to configure the plugin twice... The reason it is configured twice in the sample is because I wanted to test two things (the clover:check feature and the site report). But you're right I'll split it into 2 examples not to confuse people...
> clover breaks when encountering assert statements.
> --------------------------------------------------
>
> Key: MNG-1136
> URL: http://jira.codehaus.org/browse/MNG-1136
> Project: Maven 2
> Type: Bug
> Components: maven-clover-plugin
> Versions: 2.0-beta-3
> Environment: any
> Reporter: Dave Sag
> Assignee: Vincent Massol
> Fix For: 2.0.1
> Attachments: example_pom_from_davesag.xml, maven-clover-plugin-samples-20051024.zip, maven-clover-plugin-samples_breaks_DS.zip
>
>
> the clover plugin is breaking on the line
> assert result != null : "the result should not be null";
> saying
> [INFO] Reason: Clover has failed to instrument the source files
> i can only assume that this is because clover does not understand the assert, or is assuming java 1.3? eitherway it's no use to me until this is fixed.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Reopened: (MCLOVER-2) clover breaks when encountering assert
statements.
Posted by "Vincent Massol (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCLOVER-2?page=all ]
Vincent Massol reopened MCLOVER-2:
----------------------------------
Reopen to set again versions after the jira move from "Maven 2" to "Maven 2.x Clover Plugin"
> clover breaks when encountering assert statements.
> --------------------------------------------------
>
> Key: MCLOVER-2
> URL: http://jira.codehaus.org/browse/MCLOVER-2
> Project: Maven 2.x Clover Plugin
> Type: Bug
> Versions: 2.0-alpha-1
> Environment: any
> Reporter: Dave Sag
> Assignee: Vincent Massol
> Fix For: 2.0
> Attachments: example_pom_from_davesag.xml, maven-clover-plugin-samples-20051024.zip, maven-clover-plugin-samples_breaks_DS.zip
>
>
> the clover plugin is breaking on the line
> assert result != null : "the result should not be null";
> saying
> [INFO] Reason: Clover has failed to instrument the source files
> i can only assume that this is because clover does not understand the assert, or is assuming java 1.3? eitherway it's no use to me until this is fixed.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Updated: (MNG-1136) clover breaks when encountering assert statements.
Posted by "Dave Sag (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-1136?page=all ]
Dave Sag updated MNG-1136:
--------------------------
Attachment: maven-clover-plugin-samples_breaks_DS.zip
Okay i found something. Firstly I didn't realise that you have to configure plugins twice, once in the build section and then again in the reports section. But secondly, when I use asserts I use the following syntax:
assert true == true : "true was not true";
rather than as you had it assert (true == true);
both are valid Java, but clover jams on the first. I suspect this is a bug in clover, not the plugin.
> clover breaks when encountering assert statements.
> --------------------------------------------------
>
> Key: MNG-1136
> URL: http://jira.codehaus.org/browse/MNG-1136
> Project: Maven 2
> Type: Bug
> Components: maven-clover-plugin
> Versions: 2.0-beta-3
> Environment: any
> Reporter: Dave Sag
> Assignee: Vincent Massol
> Attachments: example_pom_from_davesag.xml, maven-clover-plugin-samples-20051024.zip, maven-clover-plugin-samples_breaks_DS.zip
>
>
> the clover plugin is breaking on the line
> assert result != null : "the result should not be null";
> saying
> [INFO] Reason: Clover has failed to instrument the source files
> i can only assume that this is because clover does not understand the assert, or is assuming java 1.3? eitherway it's no use to me until this is fixed.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Closed: (MNG-1136) clover breaks when encountering assert statements.
Posted by "Vincent Massol (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-1136?page=all ]
Vincent Massol closed MNG-1136:
-------------------------------
Resolution: Fixed
Fix Version: 2.0.1
Fixed in SVN.
> clover breaks when encountering assert statements.
> --------------------------------------------------
>
> Key: MNG-1136
> URL: http://jira.codehaus.org/browse/MNG-1136
> Project: Maven 2
> Type: Bug
> Components: maven-clover-plugin
> Versions: 2.0-beta-3
> Environment: any
> Reporter: Dave Sag
> Assignee: Vincent Massol
> Fix For: 2.0.1
> Attachments: example_pom_from_davesag.xml, maven-clover-plugin-samples-20051024.zip, maven-clover-plugin-samples_breaks_DS.zip
>
>
> the clover plugin is breaking on the line
> assert result != null : "the result should not be null";
> saying
> [INFO] Reason: Clover has failed to instrument the source files
> i can only assume that this is because clover does not understand the assert, or is assuming java 1.3? eitherway it's no use to me until this is fixed.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Updated: (MCLOVER-2) clover breaks when encountering assert
statements.
Posted by "Vincent Massol (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCLOVER-2?page=all ]
Vincent Massol updated MCLOVER-2:
---------------------------------
Version: 2.0-alpha-1
Fix Version: 2.0
set again versions after the jira move from "Maven 2" to "Maven 2.x Clover Plugin"
> clover breaks when encountering assert statements.
> --------------------------------------------------
>
> Key: MCLOVER-2
> URL: http://jira.codehaus.org/browse/MCLOVER-2
> Project: Maven 2.x Clover Plugin
> Type: Bug
> Versions: 2.0-alpha-1
> Environment: any
> Reporter: Dave Sag
> Assignee: Vincent Massol
> Fix For: 2.0
> Attachments: example_pom_from_davesag.xml, maven-clover-plugin-samples-20051024.zip, maven-clover-plugin-samples_breaks_DS.zip
>
>
> the clover plugin is breaking on the line
> assert result != null : "the result should not be null";
> saying
> [INFO] Reason: Clover has failed to instrument the source files
> i can only assume that this is because clover does not understand the assert, or is assuming java 1.3? eitherway it's no use to me until this is fixed.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MNG-1136) clover breaks when encountering assert statements.
Posted by "Matthew Beermann (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-1136?page=comments#action_49027 ]
Matthew Beermann commented on MNG-1136:
---------------------------------------
I have exactly the plugin configuration mentioned above, and I'm trying to instrument a code that contains an assertion. Nothing wierd about the use case...
Neither -jdk14 or -jdk15 is stated as being the default in the documentation link above; so if Clover is trying to instrument my code using 1.3 syntax, it's dying correctly AFAICT.
> clover breaks when encountering assert statements.
> --------------------------------------------------
>
> Key: MNG-1136
> URL: http://jira.codehaus.org/browse/MNG-1136
> Project: Maven 2
> Type: Bug
> Components: maven-clover-plugin
> Versions: 2.0-beta-3
> Environment: any
> Reporter: Dave Sag
> Assignee: Vincent Massol
>
>
> the clover plugin is breaking on the line
> assert result != null : "the result should not be null";
> saying
> [INFO] Reason: Clover has failed to instrument the source files
> i can only assume that this is because clover does not understand the assert, or is assuming java 1.3? eitherway it's no use to me until this is fixed.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MNG-1136) clover breaks when encountering assert statements.
Posted by "Dave Sag (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-1136?page=comments#action_49128 ]
Dave Sag commented on MNG-1136:
-------------------------------
see attached pom
if i uncomment the clover plugin report this is the result:
(disco-davesag) [09:55:16] ~/checkouts/private/davesag/AddressBook$ mvn -e site
+ Error stacktraces are turned on.
[INFO] Scanning for projects...
[INFO] ----------------------------------------------------------------------------
[INFO] Building AddresBook fitnesse example
[INFO] task-segment: [site]
[INFO] ----------------------------------------------------------------------------
[INFO] Preparing clover:report
[INFO] [clover:instrument]
Clover Version 1.3.9, built on July 06 2005
loaded from: /Users/davesag/.m2/repository/clover/clover/1.3.9/clover-1.3.9.jar
30 day Evaluation Version distributed via the Maven Jar Repository.
Clover is not free. You have 30 days to evaluate it. After this, please visit http://www.cenqua.com to obtain a licensed version of Clover
No coverage database '/Users/davesag/checkouts/private/davesag/AddressBook/target/clover/clover.db' found. Creating a fresh one.
ERROR: /Users/davesag/checkouts/private/davesag/AddressBook/src/main/java/com/davesag/example/addressbook/AddressBook.java:54:16:unexpected token: result
ERROR: Error parsing /Users/davesag/checkouts/private/davesag/AddressBook/src/main/java/com/davesag/example/addressbook/AddressBook.java: line 54: unexpected token: result
[INFO] ----------------------------------------------------------------------------
[ERROR] BUILD ERROR
[INFO] ----------------------------------------------------------------------------
[INFO] Clover has failed to instrument the source files
[INFO] ----------------------------------------------------------------------------
[INFO] Trace
org.apache.maven.lifecycle.LifecycleExecutionException: Clover has failed to instrument the source files
at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoals(DefaultLifecycleExecutor.java:544)
at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalWithLifecycle(DefaultLifecycleExecutor.java:469)
at org.apache.maven.lifecycle.DefaultLifecycleExecutor.forkProjectLifecycle(DefaultLifecycleExecutor.java:789)
at org.apache.maven.lifecycle.DefaultLifecycleExecutor.forkLifecycle(DefaultLifecycleExecutor.java:718)
at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoals(DefaultLifecycleExecutor.java:512)
at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalWithLifecycle(DefaultLifecycleExecutor.java:469)
at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoal(DefaultLifecycleExecutor.java:448)
at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalAndHandleFailures(DefaultLifecycleExecutor.java:301)
at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeTaskSegments(DefaultLifecycleExecutor.java:268)
at org.apache.maven.lifecycle.DefaultLifecycleExecutor.execute(DefaultLifecycleExecutor.java:137)
at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:316)
at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:113)
at org.apache.maven.cli.MavenCli.main(MavenCli.java:249)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:324)
at org.codehaus.classworlds.Launcher.launchEnhanced(Launcher.java:315)
at org.codehaus.classworlds.Launcher.launch(Launcher.java:255)
at org.codehaus.classworlds.Launcher.mainWithExitCode(Launcher.java:430)
at org.codehaus.classworlds.Launcher.main(Launcher.java:375)
Caused by: org.apache.maven.plugin.MojoExecutionException: Clover has failed to instrument the source files
at org.apache.maven.plugin.clover.CloverInstrumentMojo.execute(CloverInstrumentMojo.java:94)
at org.apache.maven.plugin.DefaultPluginManager.executeMojo(DefaultPluginManager.java:399)
at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoals(DefaultLifecycleExecutor.java:519)
... 20 more
> clover breaks when encountering assert statements.
> --------------------------------------------------
>
> Key: MNG-1136
> URL: http://jira.codehaus.org/browse/MNG-1136
> Project: Maven 2
> Type: Bug
> Components: maven-clover-plugin
> Versions: 2.0-beta-3
> Environment: any
> Reporter: Dave Sag
> Assignee: Vincent Massol
> Attachments: example_pom_from_davesag.xml
>
>
> the clover plugin is breaking on the line
> assert result != null : "the result should not be null";
> saying
> [INFO] Reason: Clover has failed to instrument the source files
> i can only assume that this is because clover does not understand the assert, or is assuming java 1.3? eitherway it's no use to me until this is fixed.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Updated: (MNG-1136) clover breaks when encountering assert statements.
Posted by "Dave Sag (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-1136?page=all ]
Dave Sag updated MNG-1136:
--------------------------
Attachment: example_pom_from_davesag.xml
my POM xml is attached. as you can see I do declare java 1.4 as both source and target.
if I uncomment the clover report and run %mvn -e site I get the following result.
(disco-davesag) [09:55:16] ~/checkouts/private/davesag/AddressBook$ mvn -e site
+ Error stacktraces are turned on.
[INFO] Scanning for projects...
[INFO] ----------------------------------------------------------------------------
[INFO] Building AddresBook fitnesse example
[INFO] task-segment: [site]
[INFO] ----------------------------------------------------------------------------
[INFO] Preparing clover:report
[INFO] [clover:instrument]
Clover Version 1.3.9, built on July 06 2005
loaded from: /Users/davesag/.m2/repository/clover/clover/1.3.9/clover-1.3.9.jar
30 day Evaluation Version distributed via the Maven Jar Repository.
Clover is not free. You have 30 days to evaluate it. After this, please visit http://www.cenqua.com to obtain a licensed version of Clover
No coverage database '/Users/davesag/checkouts/private/davesag/AddressBook/target/clover/clover.db' found. Creating a fresh one.
ERROR: /Users/davesag/checkouts/private/davesag/AddressBook/src/main/java/com/davesag/example/addressbook/AddressBook.java:54:16:unexpected token: result
ERROR: Error parsing /Users/davesag/checkouts/private/davesag/AddressBook/src/main/java/com/davesag/example/addressbook/AddressBook.java: line 54: unexpected token: result
[INFO] ----------------------------------------------------------------------------
[ERROR] BUILD ERROR
[INFO] ----------------------------------------------------------------------------
[INFO] Clover has failed to instrument the source files
[INFO] ----------------------------------------------------------------------------
[INFO] Trace
org.apache.maven.lifecycle.LifecycleExecutionException: Clover has failed to instrument the source files
at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoals(DefaultLifecycleExecutor.java:544)
at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalWithLifecycle(DefaultLifecycleExecutor.java:469)
at org.apache.maven.lifecycle.DefaultLifecycleExecutor.forkProjectLifecycle(DefaultLifecycleExecutor.java:789)
at org.apache.maven.lifecycle.DefaultLifecycleExecutor.forkLifecycle(DefaultLifecycleExecutor.java:718)
at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoals(DefaultLifecycleExecutor.java:512)
at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalWithLifecycle(DefaultLifecycleExecutor.java:469)
at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoal(DefaultLifecycleExecutor.java:448)
at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalAndHandleFailures(DefaultLifecycleExecutor.java:301)
at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeTaskSegments(DefaultLifecycleExecutor.java:268)
at org.apache.maven.lifecycle.DefaultLifecycleExecutor.execute(DefaultLifecycleExecutor.java:137)
at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:316)
at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:113)
at org.apache.maven.cli.MavenCli.main(MavenCli.java:249)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:324)
at org.codehaus.classworlds.Launcher.launchEnhanced(Launcher.java:315)
at org.codehaus.classworlds.Launcher.launch(Launcher.java:255)
at org.codehaus.classworlds.Launcher.mainWithExitCode(Launcher.java:430)
at org.codehaus.classworlds.Launcher.main(Launcher.java:375)
Caused by: org.apache.maven.plugin.MojoExecutionException: Clover has failed to instrument the source files
at org.apache.maven.plugin.clover.CloverInstrumentMojo.execute(CloverInstrumentMojo.java:94)
at org.apache.maven.plugin.DefaultPluginManager.executeMojo(DefaultPluginManager.java:399)
at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoals(DefaultLifecycleExecutor.java:519)
... 20 more
> clover breaks when encountering assert statements.
> --------------------------------------------------
>
> Key: MNG-1136
> URL: http://jira.codehaus.org/browse/MNG-1136
> Project: Maven 2
> Type: Bug
> Components: maven-clover-plugin
> Versions: 2.0-beta-3
> Environment: any
> Reporter: Dave Sag
> Assignee: Vincent Massol
> Attachments: example_pom_from_davesag.xml
>
>
> the clover plugin is breaking on the line
> assert result != null : "the result should not be null";
> saying
> [INFO] Reason: Clover has failed to instrument the source files
> i can only assume that this is because clover does not understand the assert, or is assuming java 1.3? eitherway it's no use to me until this is fixed.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MNG-1136) clover breaks when encountering assert statements.
Posted by "Vincent Massol (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-1136?page=comments#action_49139 ]
Vincent Massol commented on MNG-1136:
-------------------------------------
Hi Dave,
I'm still trying to understand your use case...
In your last post you say that if you uncomment the clover plugin report you're still getting clover errors. I don't see how this is possible since you've removed the clover report... :-)
I've tried running both the clover:check goal and the site and I don't any such errors.
Here's what I propose to you. Could you please try the attached sample. It's the sample that I use to validate the clover plugin (it's also in SVN in components/trunk/examples).
There are 2 ways to run it:
1/ By typing "mvn install". That will run the clover:check goal. It'll fail because there's still a problem in the clover plugin but it shouldn't fail on JDK 1.4 asserts
2/ By typing "mvn site". That should work with no error.
Let me know if it works for you and if so how your project differs from it.
Thanks
PS: I have finished implementing the -jdk14 and -jdk15 flag but I need to validate this on an example and for this I need to be able to reproduce your error... :-)
> clover breaks when encountering assert statements.
> --------------------------------------------------
>
> Key: MNG-1136
> URL: http://jira.codehaus.org/browse/MNG-1136
> Project: Maven 2
> Type: Bug
> Components: maven-clover-plugin
> Versions: 2.0-beta-3
> Environment: any
> Reporter: Dave Sag
> Assignee: Vincent Massol
> Attachments: example_pom_from_davesag.xml
>
>
> the clover plugin is breaking on the line
> assert result != null : "the result should not be null";
> saying
> [INFO] Reason: Clover has failed to instrument the source files
> i can only assume that this is because clover does not understand the assert, or is assuming java 1.3? eitherway it's no use to me until this is fixed.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Updated: (MNG-1136) clover breaks when encountering assert statements.
Posted by "Vincent Massol (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-1136?page=all ]
Vincent Massol updated MNG-1136:
--------------------------------
Attachment: maven-clover-plugin-samples-20051024.zip
Example of using the clover plugin with JDK 1.4 asserts.
> clover breaks when encountering assert statements.
> --------------------------------------------------
>
> Key: MNG-1136
> URL: http://jira.codehaus.org/browse/MNG-1136
> Project: Maven 2
> Type: Bug
> Components: maven-clover-plugin
> Versions: 2.0-beta-3
> Environment: any
> Reporter: Dave Sag
> Assignee: Vincent Massol
> Attachments: example_pom_from_davesag.xml, maven-clover-plugin-samples-20051024.zip
>
>
> the clover plugin is breaking on the line
> assert result != null : "the result should not be null";
> saying
> [INFO] Reason: Clover has failed to instrument the source files
> i can only assume that this is because clover does not understand the assert, or is assuming java 1.3? eitherway it's no use to me until this is fixed.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MNG-1136) clover breaks when encountering assert statements.
Posted by "Dave Sag (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-1136?page=comments#action_48438 ]
Dave Sag commented on MNG-1136:
-------------------------------
that is quite possibly the case. are you in a position to fix that?
> clover breaks when encountering assert statements.
> --------------------------------------------------
>
> Key: MNG-1136
> URL: http://jira.codehaus.org/browse/MNG-1136
> Project: Maven 2
> Type: Bug
> Components: maven-clover-plugin
> Versions: 2.0-beta-3
> Environment: any
> Reporter: Dave Sag
>
>
> the clover plugin is breaking on the line
> assert result != null : "the result should not be null";
> saying
> [INFO] Reason: Clover has failed to instrument the source files
> i can only assume that this is because clover does not understand the assert, or is assuming java 1.3? eitherway it's no use to me until this is fixed.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MNG-1136) clover breaks when encountering assert statements.
Posted by "Matthew Beermann (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-1136?page=comments#action_48581 ]
Matthew Beermann commented on MNG-1136:
---------------------------------------
...but I can try to make it easy if someone's got a build environment and knows how the POM works: it's at line 156 of CloverInstrumentMojo.java. You need to add the flags "-jdk14" or "-jdk15". http://www.cenqua.com/clover/doc/cli/cloverinstr.html
> clover breaks when encountering assert statements.
> --------------------------------------------------
>
> Key: MNG-1136
> URL: http://jira.codehaus.org/browse/MNG-1136
> Project: Maven 2
> Type: Bug
> Components: maven-clover-plugin
> Versions: 2.0-beta-3
> Environment: any
> Reporter: Dave Sag
>
>
> the clover plugin is breaking on the line
> assert result != null : "the result should not be null";
> saying
> [INFO] Reason: Clover has failed to instrument the source files
> i can only assume that this is because clover does not understand the assert, or is assuming java 1.3? eitherway it's no use to me until this is fixed.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MNG-1136) clover breaks when encountering assert statements.
Posted by "Matthew Beermann (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-1136?page=comments#action_48449 ]
Matthew Beermann commented on MNG-1136:
---------------------------------------
I'm afraid not, no.
> clover breaks when encountering assert statements.
> --------------------------------------------------
>
> Key: MNG-1136
> URL: http://jira.codehaus.org/browse/MNG-1136
> Project: Maven 2
> Type: Bug
> Components: maven-clover-plugin
> Versions: 2.0-beta-3
> Environment: any
> Reporter: Dave Sag
>
>
> the clover plugin is breaking on the line
> assert result != null : "the result should not be null";
> saying
> [INFO] Reason: Clover has failed to instrument the source files
> i can only assume that this is because clover does not understand the assert, or is assuming java 1.3? eitherway it's no use to me until this is fixed.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MNG-1136) clover breaks when encountering assert statements.
Posted by "Vincent Massol (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-1136?page=comments#action_49040 ]
Vincent Massol commented on MNG-1136:
-------------------------------------
Hi Matthew,
Could you please tell me exactly your configuration and what goal your're running? Could you please also send us the stack trace you're getting?
i've tried running the clover:check goal on a project containing 1.4 assertions and it worked fine.
Thanks
> clover breaks when encountering assert statements.
> --------------------------------------------------
>
> Key: MNG-1136
> URL: http://jira.codehaus.org/browse/MNG-1136
> Project: Maven 2
> Type: Bug
> Components: maven-clover-plugin
> Versions: 2.0-beta-3
> Environment: any
> Reporter: Dave Sag
> Assignee: Vincent Massol
>
>
> the clover plugin is breaking on the line
> assert result != null : "the result should not be null";
> saying
> [INFO] Reason: Clover has failed to instrument the source files
> i can only assume that this is because clover does not understand the assert, or is assuming java 1.3? eitherway it's no use to me until this is fixed.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MNG-1136) clover breaks when encountering assert statements.
Posted by "Vincent Massol (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-1136?page=comments#action_48999 ]
Vincent Massol commented on MNG-1136:
-------------------------------------
Dave,
Are you sure? I've just tried using the Clover plugin on a Java 1.4 project that uses assert and it's working fine. Of course you'll need to have the following in your project's pom.xml:
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<configuration>
<source>1.4</source>
<target>1.4</target>
</configuration>
</plugin>
That said, I have implemented support for passing the -jdk14 and -jdk15 flags which I'll be committing shortly.
> clover breaks when encountering assert statements.
> --------------------------------------------------
>
> Key: MNG-1136
> URL: http://jira.codehaus.org/browse/MNG-1136
> Project: Maven 2
> Type: Bug
> Components: maven-clover-plugin
> Versions: 2.0-beta-3
> Environment: any
> Reporter: Dave Sag
> Assignee: Vincent Massol
>
>
> the clover plugin is breaking on the line
> assert result != null : "the result should not be null";
> saying
> [INFO] Reason: Clover has failed to instrument the source files
> i can only assume that this is because clover does not understand the assert, or is assuming java 1.3? eitherway it's no use to me until this is fixed.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MNG-1136) clover breaks when encountering assert statements.
Posted by "Vincent Massol (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-1136?page=comments#action_49014 ]
Vincent Massol commented on MNG-1136:
-------------------------------------
I won't commit quickly as it's more complex than I thought... :-(
That said I'm curious to understand your use case as it works for me with Java 1.4 without any change...
> clover breaks when encountering assert statements.
> --------------------------------------------------
>
> Key: MNG-1136
> URL: http://jira.codehaus.org/browse/MNG-1136
> Project: Maven 2
> Type: Bug
> Components: maven-clover-plugin
> Versions: 2.0-beta-3
> Environment: any
> Reporter: Dave Sag
> Assignee: Vincent Massol
>
>
> the clover plugin is breaking on the line
> assert result != null : "the result should not be null";
> saying
> [INFO] Reason: Clover has failed to instrument the source files
> i can only assume that this is because clover does not understand the assert, or is assuming java 1.3? eitherway it's no use to me until this is fixed.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MNG-1136) clover breaks when encountering assert statements.
Posted by "Matthew Beermann (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-1136?page=comments#action_48436 ]
Matthew Beermann commented on MNG-1136:
---------------------------------------
I don't think it's a problem with Clover; rather, the <source/> attribute from the compiler:compile goal isn't getting propagated to Clover.
> clover breaks when encountering assert statements.
> --------------------------------------------------
>
> Key: MNG-1136
> URL: http://jira.codehaus.org/browse/MNG-1136
> Project: Maven 2
> Type: Bug
> Components: maven-clover-plugin
> Versions: 2.0-beta-3
> Environment: any
> Reporter: Dave Sag
>
>
> the clover plugin is breaking on the line
> assert result != null : "the result should not be null";
> saying
> [INFO] Reason: Clover has failed to instrument the source files
> i can only assume that this is because clover does not understand the assert, or is assuming java 1.3? eitherway it's no use to me until this is fixed.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Closed: (MCLOVER-2) clover breaks when encountering assert
statements.
Posted by "Vincent Massol (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MCLOVER-2?page=all ]
Vincent Massol closed MCLOVER-2:
--------------------------------
Resolution: Fixed
Fixed again versions after the jira move from "Maven 2" to "Maven 2.x Clover Plugin"
> clover breaks when encountering assert statements.
> --------------------------------------------------
>
> Key: MCLOVER-2
> URL: http://jira.codehaus.org/browse/MCLOVER-2
> Project: Maven 2.x Clover Plugin
> Type: Bug
> Versions: 2.0-alpha-1
> Environment: any
> Reporter: Dave Sag
> Assignee: Vincent Massol
> Fix For: 2.0
> Attachments: example_pom_from_davesag.xml, maven-clover-plugin-samples-20051024.zip, maven-clover-plugin-samples_breaks_DS.zip
>
>
> the clover plugin is breaking on the line
> assert result != null : "the result should not be null";
> saying
> [INFO] Reason: Clover has failed to instrument the source files
> i can only assume that this is because clover does not understand the assert, or is assuming java 1.3? eitherway it's no use to me until this is fixed.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MNG-1136) clover breaks when encountering assert statements.
Posted by "Dave Sag (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-1136?page=comments#action_49129 ]
Dave Sag commented on MNG-1136:
-------------------------------
oops - sorry for the double post then.
> clover breaks when encountering assert statements.
> --------------------------------------------------
>
> Key: MNG-1136
> URL: http://jira.codehaus.org/browse/MNG-1136
> Project: Maven 2
> Type: Bug
> Components: maven-clover-plugin
> Versions: 2.0-beta-3
> Environment: any
> Reporter: Dave Sag
> Assignee: Vincent Massol
> Attachments: example_pom_from_davesag.xml
>
>
> the clover plugin is breaking on the line
> assert result != null : "the result should not be null";
> saying
> [INFO] Reason: Clover has failed to instrument the source files
> i can only assume that this is because clover does not understand the assert, or is assuming java 1.3? eitherway it's no use to me until this is fixed.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org