You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Szehon Ho <sz...@cloudera.com> on 2014/05/07 03:37:47 UTC
Review Request 21095: HIVE-7015 Failing to inherit group/permission should
not fail the operation
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21095/
-----------------------------------------------------------
Review request for hive and Brock Noland.
Repository: hive-git
Description
-------
There was some reported permission errors hit in Fs.setOwner during table creation, when the inherit permission flag was on. I realized that HDFS follows the BSD rule and anyway sets new directory to be the same group as the parent, so actually no need to call 'setOwner' for changing the group during mkdirs.
Minor cleanups elsewhere. Changed the other call in mkdirs (Fs.setPermission) to use the shell, so it doesnt throw an error (although I don't see why it should, as folder should be owned by the current user whether its impersonated user or hive). Also changing other places as well to not throw error on failure, although again they shouldn't have failed as these were already using the shell.
Diffs
-----
common/src/java/org/apache/hadoop/hive/common/FileUtils.java 23a4b8e
ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java d8ad873
Diff: https://reviews.apache.org/r/21095/diff/
Testing
-------
Ran TestFolderPermissions.
Thanks,
Szehon Ho
Re: Review Request 21095: HIVE-7015 Failing to inherit group/permission
should not fail the operation
Posted by Szehon Ho <sz...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21095/
-----------------------------------------------------------
(Updated May 9, 2014, 7:13 p.m.)
Review request for hive and Brock Noland.
Changes
-------
The diff did not have some files (with minor call changes), adding them.
Bugs: HIVE-7015
https://issues.apache.org/jira/browse/HIVE-7015
Repository: hive-git
Description
-------
There was some reported permission errors hit in Fs.setOwner during table creation, when the inherit permission flag was on. I realized that HDFS follows the BSD rule and anyway sets new directory to be the same group as the parent, so actually no need to call 'setOwner' for changing the group during mkdirs.
Minor cleanups elsewhere. Changed the other call in mkdirs (Fs.setPermission) to use the shell, so it doesnt throw an error (although I don't see why it should, as folder should be owned by the current user whether its impersonated user or hive). Also changing other places as well to not throw error on failure, although again they shouldn't have failed as these were already using the shell.
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/common/FileUtils.java 23a4b8e
metastore/src/java/org/apache/hadoop/hive/metastore/Warehouse.java 6d9b559
ql/src/java/org/apache/hadoop/hive/ql/exec/CopyTask.java 43064b3
ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java d8ad873
Diff: https://reviews.apache.org/r/21095/diff/
Testing
-------
Ran TestFolderPermissions.
Thanks,
Szehon Ho
Re: Review Request 21095: HIVE-7015 Failing to inherit group/permission
should not fail the operation
Posted by Szehon Ho <sz...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21095/
-----------------------------------------------------------
(Updated May 8, 2014, 12:14 a.m.)
Review request for hive and Brock Noland.
Bugs: HIVE-7015
https://issues.apache.org/jira/browse/HIVE-7015
Repository: hive-git
Description
-------
There was some reported permission errors hit in Fs.setOwner during table creation, when the inherit permission flag was on. I realized that HDFS follows the BSD rule and anyway sets new directory to be the same group as the parent, so actually no need to call 'setOwner' for changing the group during mkdirs.
Minor cleanups elsewhere. Changed the other call in mkdirs (Fs.setPermission) to use the shell, so it doesnt throw an error (although I don't see why it should, as folder should be owned by the current user whether its impersonated user or hive). Also changing other places as well to not throw error on failure, although again they shouldn't have failed as these were already using the shell.
Diffs
-----
common/src/java/org/apache/hadoop/hive/common/FileUtils.java 23a4b8e
ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java d8ad873
Diff: https://reviews.apache.org/r/21095/diff/
Testing
-------
Ran TestFolderPermissions.
Thanks,
Szehon Ho