You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "heronshoes (via GitHub)" <gi...@apache.org> on 2023/04/07 02:48:05 UTC
[GitHub] [arrow] heronshoes opened a new pull request, #34954: GH-34953: [Ruby] Change null selection behavior in `Table.slice` to `:drop`
heronshoes opened a new pull request, #34954:
URL: https://github.com/apache/arrow/pull/34954
### Rationale for this change
`Table.slice` behaves as `FilterOptions.null_selection_behavior = :emit_null` for backward compatibility.
But this is a differnt behavior from `Table#filter` and `Slicer::ColumnCondition#select`
which use default option `:drop`.
This request will change the behavior of `Table#slice` to align with the default of `FilterOptions`.
### What changes are included in this PR?
Set `FilterOptions.null_selection_behavior` to the default value `:drop` from `:emit_null` .
### Are these changes tested?
Work is in progress.
### Are there any user-facing changes?
Yes.
Incompatible change will happen.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] heronshoes commented on pull request #34954: GH-34953: [Ruby] Change null selection behavior in `Table.slice` to `:drop`
Posted by "heronshoes (via GitHub)" <gi...@apache.org>.
heronshoes commented on PR #34954:
URL: https://github.com/apache/arrow/pull/34954#issuecomment-1501293284
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #34954: GH-34953: [Ruby] Change null selection behavior in `Table.slice` to `:drop`
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #34954:
URL: https://github.com/apache/arrow/pull/34954#issuecomment-1501375704
Benchmark runs are scheduled for baseline = 311cc52d208034214c325983f416f2f847a2a015 and contender = e3dd1cc7f918d3b4709ce712e7d08efafd8c9601. e3dd1cc7f918d3b4709ce712e7d08efafd8c9601 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:25.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/d1efa0ece53e4651ba2a6949fcc5db45...937284c98f2444468f81a81b4b8fb8fb/)
[Failed :arrow_down:0.8% :arrow_up:0.06%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/5001d46d72484211ac5429497f1752e8...2fec335b5c374099a9d409a1ce39b973/)
[Finished :arrow_down:0.51% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/80854e40008e41ee8586abc477deb4d9...e43586d579b7454b99923f9496034800/)
[Finished :arrow_down:0.15% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/019ee3c0a2a5482fad7a0c77735775b8...4aca0fc12d9e4d758ee5f080f70321ec/)
Buildkite builds:
[Finished] [`e3dd1cc7` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2662)
[Finished] [`e3dd1cc7` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2695)
[Finished] [`e3dd1cc7` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2660)
[Finished] [`e3dd1cc7` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2686)
[Finished] [`311cc52d` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2661)
[Failed] [`311cc52d` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2694)
[Finished] [`311cc52d` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2659)
[Finished] [`311cc52d` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2685)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34954: GH-34953: [Ruby] Change null selection behavior in `Table.slice` to `:drop`
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34954:
URL: https://github.com/apache/arrow/pull/34954#issuecomment-1499874169
:warning: GitHub issue #34953 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou merged pull request #34954: GH-34953: [Ruby] Change null selection behavior in `Table.slice` to `:drop`
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #34954:
URL: https://github.com/apache/arrow/pull/34954
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34954: GH-34953: [Ruby] Change null selection behavior in `Table.slice` to `:drop`
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34954:
URL: https://github.com/apache/arrow/pull/34954#issuecomment-1499874148
* Closes: #34953
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] heronshoes commented on pull request #34954: GH-34953: [Ruby] Change null selection behavior in `Table.slice` to `:drop`
Posted by "heronshoes (via GitHub)" <gi...@apache.org>.
heronshoes commented on PR #34954:
URL: https://github.com/apache/arrow/pull/34954#issuecomment-1499903164
Waiting for #34951 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org