You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by Maxim Solodovnik <so...@gmail.com> on 2015/11/01 07:13:46 UTC

Re: [VOTE] Integration of the FileSystemResourceReference

+1
this new component will be very useful in our project

On Sat, Oct 31, 2015 at 3:47 PM, Tobias Soloschenko <
tobiassoloschenko@googlemail.com> wrote:

> Hi,
>
> I just wanted to ask if we should integrate the
> FileSystemResourceReference into wicket core which is mentioned and already
> discussed here:
>
>
> http://apache-wicket.1842946.n4.nabble.com/Generic-resource-reference-for-video-audio-playback-td4672337.html
>
> I provided two examples:
>
> * Reading jar / zip files (Example >
> jar:file:///myFolder/test.zip!/myFolderInsideTheZip/video1.mp4)
> * Unified reading of files out of the file system (unix, windows, solaris)
> (Example > file:///myFolder/video1.mp4)
>
>
> https://github.com/klopfdreh/wicket-components-playground/blob/master/wicket-components-playground/src/main/java/org/apache/wicket/markup/html/media/FileSystemExamplePage.java
>
> Further FileSystemProviders and the corresponding FileSystems can be
> implemented as described here:
>
>
> http://docs.oracle.com/javase/7/docs/technotes/guides/io/fsp/filesystemprovider.html
>
> WDYT?
>
> kind regards
>
> Tobias
>
> P.S.: If all tend the FileSystemResourceReference to be integrated I am
> going to create a PR and write some unit tests.
>



-- 
WBR
Maxim aka solomax

Re: [VOTE] Integration of the FileSystemResourceReference

Posted by Tobias Soloschenko <to...@googlemail.com>.
Hi Martin,

thank you very much for reviewing! 

Jep - if it is finished we can of course port it to the Wicket 7.x branch. :-)

1) Are you able to help me a bit out with this task? I am afraid to break the functionality - that's the reason why I decided to handle it within a FSRR and don't change something in the Resource/Stream-Layer.

2) Good points! I used static because the API can be invoked without creating an object (because it has to be created after the path has been received) I used a HashMap because I didn't find a way to check if the file system already exists.

I am going to work through the review as fast as possible!

kind regards

Tobias

> Am 01.11.2015 um 16:18 schrieb Martin Grigorov <mg...@apache.org>:
> 
> Hi Tobias,
> 
> I've added some comments to the Pull Request.
> 
> I think it is a useful addition1 I don't see any Java 8 APIs used there so
> it can go even in Wicket 7.
> 
> The main issues I see:
> 1) I think we should extract most of the logic in FileSystemResource to
> PathResourceStream (a new class), similar to FileResourceStream. This way
> it will benefit from locale/style/variation support.
> 2) The helper methods #getPath() in FSRR bother me a bit. At the moment
> there are concurrency issues with it. This is easy to fix. But the usage of
> 'static' is a usually problematic. If caching is really needed then I think
> we should use Application's metadata instead.
> 
> Martin Grigorov
> Wicket Training and Consulting
> https://twitter.com/mtgrigorov
> 
> On Sun, Nov 1, 2015 at 10:38 AM, Tobias Soloschenko <
> tobiassoloschenko@googlemail.com> wrote:
> 
>> I wrote some unit tests even with mime type detection and created a pull
>> request to review the implementation:
>> 
>> https://github.com/apache/wicket/pull/142
>> 
>> kind regards
>> 
>> Tobias
>> 
>> Am 01.11.15 um 07:13 schrieb Maxim Solodovnik:
>> 
>> +1
>>> this new component will be very useful in our project
>>> 
>>> On Sat, Oct 31, 2015 at 3:47 PM, Tobias Soloschenko <
>>> tobiassoloschenko@googlemail.com> wrote:
>>> 
>>> Hi,
>>>> 
>>>> I just wanted to ask if we should integrate the
>>>> FileSystemResourceReference into wicket core which is mentioned and
>>>> already
>>>> discussed here:
>>>> 
>>>> 
>>>> 
>>>> http://apache-wicket.1842946.n4.nabble.com/Generic-resource-reference-for-video-audio-playback-td4672337.html
>>>> 
>>>> I provided two examples:
>>>> 
>>>> * Reading jar / zip files (Example >
>>>> jar:file:///myFolder/test.zip!/myFolderInsideTheZip/video1.mp4)
>>>> * Unified reading of files out of the file system (unix, windows,
>>>> solaris)
>>>> (Example > file:///myFolder/video1.mp4)
>>>> 
>>>> 
>>>> 
>>>> https://github.com/klopfdreh/wicket-components-playground/blob/master/wicket-components-playground/src/main/java/org/apache/wicket/markup/html/media/FileSystemExamplePage.java
>>>> 
>>>> Further FileSystemProviders and the corresponding FileSystems can be
>>>> implemented as described here:
>>>> 
>>>> 
>>>> 
>>>> http://docs.oracle.com/javase/7/docs/technotes/guides/io/fsp/filesystemprovider.html
>>>> 
>>>> WDYT?
>>>> 
>>>> kind regards
>>>> 
>>>> Tobias
>>>> 
>>>> P.S.: If all tend the FileSystemResourceReference to be integrated I am
>>>> going to create a PR and write some unit tests.
>> 

Re: [VOTE] Integration of the FileSystemResourceReference

Posted by Martin Grigorov <mg...@apache.org>.
Hi Tobias,

I've added some comments to the Pull Request.

I think it is a useful addition1 I don't see any Java 8 APIs used there so
it can go even in Wicket 7.

The main issues I see:
1) I think we should extract most of the logic in FileSystemResource to
PathResourceStream (a new class), similar to FileResourceStream. This way
it will benefit from locale/style/variation support.
2) The helper methods #getPath() in FSRR bother me a bit. At the moment
there are concurrency issues with it. This is easy to fix. But the usage of
'static' is a usually problematic. If caching is really needed then I think
we should use Application's metadata instead.

Martin Grigorov
Wicket Training and Consulting
https://twitter.com/mtgrigorov

On Sun, Nov 1, 2015 at 10:38 AM, Tobias Soloschenko <
tobiassoloschenko@googlemail.com> wrote:

> I wrote some unit tests even with mime type detection and created a pull
> request to review the implementation:
>
> https://github.com/apache/wicket/pull/142
>
> kind regards
>
> Tobias
>
> Am 01.11.15 um 07:13 schrieb Maxim Solodovnik:
>
> +1
>> this new component will be very useful in our project
>>
>> On Sat, Oct 31, 2015 at 3:47 PM, Tobias Soloschenko <
>> tobiassoloschenko@googlemail.com> wrote:
>>
>> Hi,
>>>
>>> I just wanted to ask if we should integrate the
>>> FileSystemResourceReference into wicket core which is mentioned and
>>> already
>>> discussed here:
>>>
>>>
>>>
>>> http://apache-wicket.1842946.n4.nabble.com/Generic-resource-reference-for-video-audio-playback-td4672337.html
>>>
>>> I provided two examples:
>>>
>>> * Reading jar / zip files (Example >
>>> jar:file:///myFolder/test.zip!/myFolderInsideTheZip/video1.mp4)
>>> * Unified reading of files out of the file system (unix, windows,
>>> solaris)
>>> (Example > file:///myFolder/video1.mp4)
>>>
>>>
>>>
>>> https://github.com/klopfdreh/wicket-components-playground/blob/master/wicket-components-playground/src/main/java/org/apache/wicket/markup/html/media/FileSystemExamplePage.java
>>>
>>> Further FileSystemProviders and the corresponding FileSystems can be
>>> implemented as described here:
>>>
>>>
>>>
>>> http://docs.oracle.com/javase/7/docs/technotes/guides/io/fsp/filesystemprovider.html
>>>
>>> WDYT?
>>>
>>> kind regards
>>>
>>> Tobias
>>>
>>> P.S.: If all tend the FileSystemResourceReference to be integrated I am
>>> going to create a PR and write some unit tests.
>>>
>>>
>>
>>
>

Re: [VOTE] Integration of the FileSystemResourceReference

Posted by Tobias Soloschenko <to...@googlemail.com>.
I wrote some unit tests even with mime type detection and created a pull 
request to review the implementation:

https://github.com/apache/wicket/pull/142

kind regards

Tobias

Am 01.11.15 um 07:13 schrieb Maxim Solodovnik:
> +1
> this new component will be very useful in our project
>
> On Sat, Oct 31, 2015 at 3:47 PM, Tobias Soloschenko <
> tobiassoloschenko@googlemail.com> wrote:
>
>> Hi,
>>
>> I just wanted to ask if we should integrate the
>> FileSystemResourceReference into wicket core which is mentioned and already
>> discussed here:
>>
>>
>> http://apache-wicket.1842946.n4.nabble.com/Generic-resource-reference-for-video-audio-playback-td4672337.html
>>
>> I provided two examples:
>>
>> * Reading jar / zip files (Example >
>> jar:file:///myFolder/test.zip!/myFolderInsideTheZip/video1.mp4)
>> * Unified reading of files out of the file system (unix, windows, solaris)
>> (Example > file:///myFolder/video1.mp4)
>>
>>
>> https://github.com/klopfdreh/wicket-components-playground/blob/master/wicket-components-playground/src/main/java/org/apache/wicket/markup/html/media/FileSystemExamplePage.java
>>
>> Further FileSystemProviders and the corresponding FileSystems can be
>> implemented as described here:
>>
>>
>> http://docs.oracle.com/javase/7/docs/technotes/guides/io/fsp/filesystemprovider.html
>>
>> WDYT?
>>
>> kind regards
>>
>> Tobias
>>
>> P.S.: If all tend the FileSystemResourceReference to be integrated I am
>> going to create a PR and write some unit tests.
>>
>
>


Re: [VOTE] Integration of the FileSystemResourceReference

Posted by Tobias Soloschenko <to...@googlemail.com>.
Hi Maxim, hi others :-)

What do you think about this change:

https://github.com/apache/wicket/pull/145

kind regards

Tobias

> Am 11.12.2015 um 03:44 schrieb Maxim Solodovnik <so...@gmail.com>:
> 
> Actually yes,
> 
> I can reconstruct file name of resource only in newResourceResponse(Attributes attributes) method
> so it is impossible to construct FSRR(Path).
> It would be nice to have such ability :) it might be useful to provide for ex. user profile pictures by id of some other resources :)
> 
>> On Fri, Dec 11, 2015 at 12:52 AM, Tobias Soloschenko <to...@googlemail.com> wrote:
>> Hi Maxim,
>> 
>> do I understand you right that when it gets to static mounted resources the variable part can't be catched and used by the FSRR?
>> 
>> I have to dig into it and may extend the FSRR. Good Point!
>> 
>> @others: WDYT?
>> 
>> kind regards 
>> 
>> Tobias
>> 
>> Am Donnerstag, 10. Dezember 2015 schrieb Maxim Solodovnik :
>>> Hello Tobias,
>>> 
>>> I'm trying to use FileSystemResourceReference to provide dynamic mounted resources
>>> 
>>> I'm currently using "hand-made resource references" as follows
>>> mounting [1]
>>> get attribute and use [2]
>>> unfortunately I see no way to get/use dynamic id/name with new FSRR
>>> 
>>> will appreciate any hint :)
>>> Thanks in advance!
>>> 
>>> [1] https://github.com/apache/openmeetings/blob/trunk/singlewebapp/openmeetings-web/src/main/java/org/apache/openmeetings/web/app/Application.java#L152
>>> [2] https://github.com/apache/openmeetings/blob/trunk/singlewebapp/openmeetings-web/src/main/java/org/apache/openmeetings/web/util/RecordingResourceReference.java#L72
>>> 
>>>> On Sun, Nov 8, 2015 at 3:38 PM, Tobias Soloschenko <to...@googlemail.com> wrote:
>>>> Just wanted to provide the information that it's integrated, now.
>>>> 
>>>> https://issues.apache.org/jira/plugins/servlet/mobile#issue/WICKET-6025
>>>> 
>>>> kind regards
>>>> 
>>>> Tobias
>>>> 
>>>> > Am 01.11.2015 um 07:13 schrieb Maxim Solodovnik <so...@gmail.com>:
>>>> >
>>>> > +1
>>>> > this new component will be very useful in our project
>>>> >
>>>> > On Sat, Oct 31, 2015 at 3:47 PM, Tobias Soloschenko <
>>>> > tobiassoloschenko@googlemail.com> wrote:
>>>> >
>>>> >> Hi,
>>>> >>
>>>> >> I just wanted to ask if we should integrate the
>>>> >> FileSystemResourceReference into wicket core which is mentioned and already
>>>> >> discussed here:
>>>> >>
>>>> >>
>>>> >> http://apache-wicket.1842946.n4.nabble.com/Generic-resource-reference-for-video-audio-playback-td4672337.html
>>>> >>
>>>> >> I provided two examples:
>>>> >>
>>>> >> * Reading jar / zip files (Example >
>>>> >> jar:file:///myFolder/test.zip!/myFolderInsideTheZip/video1.mp4)
>>>> >> * Unified reading of files out of the file system (unix, windows, solaris)
>>>> >> (Example > file:///myFolder/video1.mp4)
>>>> >>
>>>> >>
>>>> >> https://github.com/klopfdreh/wicket-components-playground/blob/master/wicket-components-playground/src/main/java/org/apache/wicket/markup/html/media/FileSystemExamplePage.java
>>>> >>
>>>> >> Further FileSystemProviders and the corresponding FileSystems can be
>>>> >> implemented as described here:
>>>> >>
>>>> >>
>>>> >> http://docs.oracle.com/javase/7/docs/technotes/guides/io/fsp/filesystemprovider.html
>>>> >>
>>>> >> WDYT?
>>>> >>
>>>> >> kind regards
>>>> >>
>>>> >> Tobias
>>>> >>
>>>> >> P.S.: If all tend the FileSystemResourceReference to be integrated I am
>>>> >> going to create a PR and write some unit tests.
>>>> >
>>>> >
>>>> >
>>>> > --
>>>> > WBR
>>>> > Maxim aka solomax
>>> 
>>> 
>>> 
>>> -- 
>>> WBR
>>> Maxim aka solomax
> 
> 
> 
> -- 
> WBR
> Maxim aka solomax

Re: [VOTE] Integration of the FileSystemResourceReference

Posted by Maxim Solodovnik <so...@gmail.com>.
Actually yes,

I can reconstruct file name of resource only in newResourceResponse(
Attributes attributes) method
so it is impossible to construct FSRR(Path).
It would be nice to have such ability :) it might be useful to provide for
ex. user profile pictures by id of some other resources :)

On Fri, Dec 11, 2015 at 12:52 AM, Tobias Soloschenko <
tobiassoloschenko@googlemail.com> wrote:

> Hi Maxim,
>
> do I understand you right that when it gets to static mounted resources
> the variable part can't be catched and used by the FSRR?
>
> I have to dig into it and may extend the FSRR. Good Point!
>
> @others: WDYT?
>
> kind regards
>
> Tobias
>
> Am Donnerstag, 10. Dezember 2015 schrieb Maxim Solodovnik :
>
>> Hello Tobias,
>>
>> I'm trying to use FileSystemResourceReference to provide dynamic mounted
>> resources
>>
>> I'm currently using "hand-made resource references" as follows
>> mounting [1]
>> get attribute and use [2]
>> unfortunately I see no way to get/use dynamic id/name with new FSRR
>>
>> will appreciate any hint :)
>> Thanks in advance!
>>
>> [1]
>> https://github.com/apache/openmeetings/blob/trunk/singlewebapp/openmeetings-web/src/main/java/org/apache/openmeetings/web/app/Application.java#L152
>> [2]
>> https://github.com/apache/openmeetings/blob/trunk/singlewebapp/openmeetings-web/src/main/java/org/apache/openmeetings/web/util/RecordingResourceReference.java#L72
>>
>> On Sun, Nov 8, 2015 at 3:38 PM, Tobias Soloschenko <
>> tobiassoloschenko@googlemail.com> wrote:
>>
>>> Just wanted to provide the information that it's integrated, now.
>>>
>>> https://issues.apache.org/jira/plugins/servlet/mobile#issue/WICKET-6025
>>>
>>> kind regards
>>>
>>> Tobias
>>>
>>> > Am 01.11.2015 um 07:13 schrieb Maxim Solodovnik <solomax666@gmail.com
>>> >:
>>> >
>>> > +1
>>> > this new component will be very useful in our project
>>> >
>>> > On Sat, Oct 31, 2015 at 3:47 PM, Tobias Soloschenko <
>>> > tobiassoloschenko@googlemail.com> wrote:
>>> >
>>> >> Hi,
>>> >>
>>> >> I just wanted to ask if we should integrate the
>>> >> FileSystemResourceReference into wicket core which is mentioned and
>>> already
>>> >> discussed here:
>>> >>
>>> >>
>>> >>
>>> http://apache-wicket.1842946.n4.nabble.com/Generic-resource-reference-for-video-audio-playback-td4672337.html
>>> >>
>>> >> I provided two examples:
>>> >>
>>> >> * Reading jar / zip files (Example >
>>> >> jar:file:///myFolder/test.zip!/myFolderInsideTheZip/video1.mp4)
>>> >> * Unified reading of files out of the file system (unix, windows,
>>> solaris)
>>> >> (Example > file:///myFolder/video1.mp4)
>>> >>
>>> >>
>>> >>
>>> https://github.com/klopfdreh/wicket-components-playground/blob/master/wicket-components-playground/src/main/java/org/apache/wicket/markup/html/media/FileSystemExamplePage.java
>>> >>
>>> >> Further FileSystemProviders and the corresponding FileSystems can be
>>> >> implemented as described here:
>>> >>
>>> >>
>>> >>
>>> http://docs.oracle.com/javase/7/docs/technotes/guides/io/fsp/filesystemprovider.html
>>> >>
>>> >> WDYT?
>>> >>
>>> >> kind regards
>>> >>
>>> >> Tobias
>>> >>
>>> >> P.S.: If all tend the FileSystemResourceReference to be integrated I
>>> am
>>> >> going to create a PR and write some unit tests.
>>> >
>>> >
>>> >
>>> > --
>>> > WBR
>>> > Maxim aka solomax
>>>
>>
>>
>>
>> --
>> WBR
>> Maxim aka solomax
>>
>


-- 
WBR
Maxim aka solomax

Re: [VOTE] Integration of the FileSystemResourceReference

Posted by Tobias Soloschenko <to...@googlemail.com>.
Hi Maxim,

do I understand you right that when it gets to static mounted resources the
variable part can't be catched and used by the FSRR?

I have to dig into it and may extend the FSRR. Good Point!

@others: WDYT?

kind regards

Tobias

Am Donnerstag, 10. Dezember 2015 schrieb Maxim Solodovnik :

> Hello Tobias,
>
> I'm trying to use FileSystemResourceReference to provide dynamic mounted
> resources
>
> I'm currently using "hand-made resource references" as follows
> mounting [1]
> get attribute and use [2]
> unfortunately I see no way to get/use dynamic id/name with new FSRR
>
> will appreciate any hint :)
> Thanks in advance!
>
> [1]
> https://github.com/apache/openmeetings/blob/trunk/singlewebapp/openmeetings-web/src/main/java/org/apache/openmeetings/web/app/Application.java#L152
> [2]
> https://github.com/apache/openmeetings/blob/trunk/singlewebapp/openmeetings-web/src/main/java/org/apache/openmeetings/web/util/RecordingResourceReference.java#L72
>
> On Sun, Nov 8, 2015 at 3:38 PM, Tobias Soloschenko <
> tobiassoloschenko@googlemail.com
> <javascript:_e(%7B%7D,'cvml','tobiassoloschenko@googlemail.com');>> wrote:
>
>> Just wanted to provide the information that it's integrated, now.
>>
>> https://issues.apache.org/jira/plugins/servlet/mobile#issue/WICKET-6025
>>
>> kind regards
>>
>> Tobias
>>
>> > Am 01.11.2015 um 07:13 schrieb Maxim Solodovnik <solomax666@gmail.com
>> <javascript:_e(%7B%7D,'cvml','solomax666@gmail.com');>>:
>> >
>> > +1
>> > this new component will be very useful in our project
>> >
>> > On Sat, Oct 31, 2015 at 3:47 PM, Tobias Soloschenko <
>> > tobiassoloschenko@googlemail.com
>> <javascript:_e(%7B%7D,'cvml','tobiassoloschenko@googlemail.com');>>
>> wrote:
>> >
>> >> Hi,
>> >>
>> >> I just wanted to ask if we should integrate the
>> >> FileSystemResourceReference into wicket core which is mentioned and
>> already
>> >> discussed here:
>> >>
>> >>
>> >>
>> http://apache-wicket.1842946.n4.nabble.com/Generic-resource-reference-for-video-audio-playback-td4672337.html
>> >>
>> >> I provided two examples:
>> >>
>> >> * Reading jar / zip files (Example >
>> >> jar:file:///myFolder/test.zip!/myFolderInsideTheZip/video1.mp4)
>> >> * Unified reading of files out of the file system (unix, windows,
>> solaris)
>> >> (Example > file:///myFolder/video1.mp4)
>> >>
>> >>
>> >>
>> https://github.com/klopfdreh/wicket-components-playground/blob/master/wicket-components-playground/src/main/java/org/apache/wicket/markup/html/media/FileSystemExamplePage.java
>> >>
>> >> Further FileSystemProviders and the corresponding FileSystems can be
>> >> implemented as described here:
>> >>
>> >>
>> >>
>> http://docs.oracle.com/javase/7/docs/technotes/guides/io/fsp/filesystemprovider.html
>> >>
>> >> WDYT?
>> >>
>> >> kind regards
>> >>
>> >> Tobias
>> >>
>> >> P.S.: If all tend the FileSystemResourceReference to be integrated I am
>> >> going to create a PR and write some unit tests.
>> >
>> >
>> >
>> > --
>> > WBR
>> > Maxim aka solomax
>>
>
>
>
> --
> WBR
> Maxim aka solomax
>

Re: [VOTE] Integration of the FileSystemResourceReference

Posted by Maxim Solodovnik <so...@gmail.com>.
Hello Tobias,

I'm trying to use FileSystemResourceReference to provide dynamic mounted
resources

I'm currently using "hand-made resource references" as follows
mounting [1]
get attribute and use [2]
unfortunately I see no way to get/use dynamic id/name with new FSRR

will appreciate any hint :)
Thanks in advance!

[1]
https://github.com/apache/openmeetings/blob/trunk/singlewebapp/openmeetings-web/src/main/java/org/apache/openmeetings/web/app/Application.java#L152
[2]
https://github.com/apache/openmeetings/blob/trunk/singlewebapp/openmeetings-web/src/main/java/org/apache/openmeetings/web/util/RecordingResourceReference.java#L72

On Sun, Nov 8, 2015 at 3:38 PM, Tobias Soloschenko <
tobiassoloschenko@googlemail.com> wrote:

> Just wanted to provide the information that it's integrated, now.
>
> https://issues.apache.org/jira/plugins/servlet/mobile#issue/WICKET-6025
>
> kind regards
>
> Tobias
>
> > Am 01.11.2015 um 07:13 schrieb Maxim Solodovnik <so...@gmail.com>:
> >
> > +1
> > this new component will be very useful in our project
> >
> > On Sat, Oct 31, 2015 at 3:47 PM, Tobias Soloschenko <
> > tobiassoloschenko@googlemail.com> wrote:
> >
> >> Hi,
> >>
> >> I just wanted to ask if we should integrate the
> >> FileSystemResourceReference into wicket core which is mentioned and
> already
> >> discussed here:
> >>
> >>
> >>
> http://apache-wicket.1842946.n4.nabble.com/Generic-resource-reference-for-video-audio-playback-td4672337.html
> >>
> >> I provided two examples:
> >>
> >> * Reading jar / zip files (Example >
> >> jar:file:///myFolder/test.zip!/myFolderInsideTheZip/video1.mp4)
> >> * Unified reading of files out of the file system (unix, windows,
> solaris)
> >> (Example > file:///myFolder/video1.mp4)
> >>
> >>
> >>
> https://github.com/klopfdreh/wicket-components-playground/blob/master/wicket-components-playground/src/main/java/org/apache/wicket/markup/html/media/FileSystemExamplePage.java
> >>
> >> Further FileSystemProviders and the corresponding FileSystems can be
> >> implemented as described here:
> >>
> >>
> >>
> http://docs.oracle.com/javase/7/docs/technotes/guides/io/fsp/filesystemprovider.html
> >>
> >> WDYT?
> >>
> >> kind regards
> >>
> >> Tobias
> >>
> >> P.S.: If all tend the FileSystemResourceReference to be integrated I am
> >> going to create a PR and write some unit tests.
> >
> >
> >
> > --
> > WBR
> > Maxim aka solomax
>



-- 
WBR
Maxim aka solomax

Re: [VOTE] Integration of the FileSystemResourceReference

Posted by Tobias Soloschenko <to...@googlemail.com>.
Just wanted to provide the information that it's integrated, now.

https://issues.apache.org/jira/plugins/servlet/mobile#issue/WICKET-6025

kind regards

Tobias

> Am 01.11.2015 um 07:13 schrieb Maxim Solodovnik <so...@gmail.com>:
> 
> +1
> this new component will be very useful in our project
> 
> On Sat, Oct 31, 2015 at 3:47 PM, Tobias Soloschenko <
> tobiassoloschenko@googlemail.com> wrote:
> 
>> Hi,
>> 
>> I just wanted to ask if we should integrate the
>> FileSystemResourceReference into wicket core which is mentioned and already
>> discussed here:
>> 
>> 
>> http://apache-wicket.1842946.n4.nabble.com/Generic-resource-reference-for-video-audio-playback-td4672337.html
>> 
>> I provided two examples:
>> 
>> * Reading jar / zip files (Example >
>> jar:file:///myFolder/test.zip!/myFolderInsideTheZip/video1.mp4)
>> * Unified reading of files out of the file system (unix, windows, solaris)
>> (Example > file:///myFolder/video1.mp4)
>> 
>> 
>> https://github.com/klopfdreh/wicket-components-playground/blob/master/wicket-components-playground/src/main/java/org/apache/wicket/markup/html/media/FileSystemExamplePage.java
>> 
>> Further FileSystemProviders and the corresponding FileSystems can be
>> implemented as described here:
>> 
>> 
>> http://docs.oracle.com/javase/7/docs/technotes/guides/io/fsp/filesystemprovider.html
>> 
>> WDYT?
>> 
>> kind regards
>> 
>> Tobias
>> 
>> P.S.: If all tend the FileSystemResourceReference to be integrated I am
>> going to create a PR and write some unit tests.
> 
> 
> 
> -- 
> WBR
> Maxim aka solomax