You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@dubbo.apache.org by "leihuazhe (GitHub)" <gi...@apache.org> on 2018/12/16 08:47:12 UTC

[GitHub] [incubator-dubbo] leihuazhe opened issue #2973: CallbackServiceCodec.referOrdestroyCallbackService method should be Camel-Case

- [ ] I have searched the [issues](https://github.com/apache/incubator-dubbo/issues) of this repository and believe that this is not a duplicate.
- [ ] I have checked the [FAQ](https://github.com/apache/incubator-dubbo/blob/master/FAQ.md) of this repository and believe that this is not a duplicate.

### Environment

* Dubbo version: master
* Operating System version: mac
* Java version: 1.8

### Steps to reproduce this issue

CallbackServiceCodec has a method referOrdestroyCallbackService,

I think it would be referOrDestroyCallbackService better ,so we can understand the method mean more simple.


Pls. provide [GitHub address] to reproduce this issue.




[ Full content available at: https://github.com/apache/incubator-dubbo/issues/2973 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] leihuazhe commented on issue #2973: CallbackServiceCodec.referOrdestroyCallbackService method should be Camel-Case

Posted by "leihuazhe (GitHub)" <gi...@apache.org>.

I just fix it ,and make a pull request number #2974 

[ Full content available at: https://github.com/apache/incubator-dubbo/issues/2973 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] leihuazhe closed issue #2973: CallbackServiceCodec.referOrdestroyCallbackService method should be Camel-Case

Posted by "leihuazhe (GitHub)" <gi...@apache.org>.

[ issue closed by leihuazhe ]

[ Full content available at: https://github.com/apache/incubator-dubbo/issues/2973 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] leihuazhe commented on issue #2973: CallbackServiceCodec.referOrdestroyCallbackService method should be Camel-Case

Posted by "leihuazhe (GitHub)" <gi...@apache.org>.

just fixed by  #2979 , already merge to master ,so close this issues

[ Full content available at: https://github.com/apache/incubator-dubbo/issues/2973 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] leihuazhe commented on issue #2973: CallbackServiceCodec.referOrdestroyCallbackService method should be Camel-Case

Posted by "leihuazhe (GitHub)" <gi...@apache.org>.

I take a pull request for it again which is #2979

[ Full content available at: https://github.com/apache/incubator-dubbo/issues/2973 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org