[GitHub] [spark] xuanyuanking commented on a change in pull request #30521: [SPARK-33577][SS] Add support for V1Table in stream writer table API

[GitBox <gi...@apache.org>]

xuanyuanking commented on a change in pull request #30521:
URL: https://github.com/apache/spark/pull/30521#discussion_r531463427



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/streaming/DataStreamWriter.scala
##########
@@ -304,46 +308,68 @@ final class DataStreamWriter[T] private[sql](ds: Dataset[T]) {
    * @since 3.1.0
    */
   @throws[TimeoutException]
-  def saveAsTable(tableName: String): StreamingQuery = {
-    this.source = SOURCE_NAME_TABLE
+  def table(tableName: String): StreamingQuery = {

Review comment:
       cc @cloud-fan, I want to raise the discussion about the API name(https://github.com/apache/spark/pull/29767#discussion_r500081260) again in this PR.
   I still think maybe the previous name is better as the StreamWriter.table returns a `StreamingQuery` directly. I think the naming for `saveAsTable` in DataFrameWriter because it has the API `save`, but DataStreamWriter doesn't. WDYT?
   Also cc @HeartSaVioR and @zsxwing 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org