You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Hongyuan Li (JIRA)" <ji...@apache.org> on 2017/06/02 16:17:04 UTC

[jira] [Comment Edited] (HADOOP-14429) getFsAction method of FTPFileSystem always return FsAction.NONE

    [ https://issues.apache.org/jira/browse/HADOOP-14429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16032531#comment-16032531 ] 

Hongyuan Li edited comment on HADOOP-14429 at 6/2/17 4:16 PM:
--------------------------------------------------------------

[~yzhangal] patch-002 does as what you comment.
[~stevel@apache.org] Would you mind giving me a code review?


was (Author: hongyuan li):
[~yzhangal] patch-002 does as what you comment.

> getFsAction method of FTPFileSystem  always return FsAction.NONE
> ----------------------------------------------------------------
>
>                 Key: HADOOP-14429
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14429
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs
>    Affects Versions: 3.0.0-alpha2
>            Reporter: Hongyuan Li
>            Assignee: Hongyuan Li
>            Priority: Trivial
>         Attachments: HADOOP-14429-001.patch, HADOOP-14429-002.patch, HADOOP-14429-003.patch
>
>
>   
> {code}
> private FsAction getFsAction(int accessGroup, FTPFile ftpFile) {
>       FsAction action = FsAction.NONE;
>       if (ftpFile.hasPermission(accessGroup, FTPFile.READ_PERMISSION)) {
>       action.or(FsAction.READ);
>   }
>     if (ftpFile.hasPermission(accessGroup, FTPFile.WRITE_PERMISSION)) {
>       action.or(FsAction.WRITE);
>     }
>     if (ftpFile.hasPermission(accessGroup, FTPFile.EXECUTE_PERMISSION)) {
>       action.or(FsAction.EXECUTE);
>     }
>     return action;
>   }
> {code}
> from code above, we can see that the  getFsAction method doesnot modify the action generated by FsAction action = FsAction.NONE,which means it return FsAction.NONE all the time;



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org