You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/10/26 02:14:10 UTC
[GitHub] [superset] kamalkeshavani-aiinside opened a new issue #17227: [dashboard-rbac] Support Fallback to dataset permissions even when ff is on
kamalkeshavani-aiinside opened a new issue #17227:
URL: https://github.com/apache/superset/issues/17227
**Is your feature request related to a problem? Please describe.**
With 'DASHBOARD_RBAC' ff on, when I don’t assign any role in dashboard props but the role has access to required dataset, still I get this error `You don't have access to this dashboard.`
**Describe the solution you'd like**
As the documentation mentions [here](https://superset.apache.org/docs/creating-charts-dashboards/first-dashboard#:~:text=Having%20dashboard%20access%20implicitly%20grants%20read%20access%20to%20the%20associated%20datasets%2C%20therefore%20all%20charts%20will%20load%20their%20data%20even%20if%20feature%20flag%20is%20turned%20on%20and%20no%20roles%20assigned%20to%20roles%20the%20access%20will%20fallback%20to%20Dataset%20permissions), the fallback to dataset permission should work with ff enabled.
**Describe alternatives you've considered**
A clear and concise description of any alternative solutions or features you've considered.
**Additional context**
I confirmed the same behavior in 1.3.2.
https://apache-superset.slack.com/archives/C01B6H6U8S2/p1625000708004100
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido commented on issue #17227: [dashboard-rbac] Support Fallback to dataset permissions even when ff is on
Posted by GitBox <gi...@apache.org>.
geido commented on issue #17227:
URL: https://github.com/apache/superset/issues/17227#issuecomment-1021955722
Hello @kamalkeshavani-aiinside I am marking this as a bug as you pointed out that should be the default behavior. I am also marking the issue as requiring validation from a committer. Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] nikhil-kuyya edited a comment on issue #17227: [dashboard-rbac] Support Fallback to dataset permissions even when ff is on
Posted by GitBox <gi...@apache.org>.
nikhil-kuyya edited a comment on issue #17227:
URL: https://github.com/apache/superset/issues/17227#issuecomment-1070351678
i understanding this and tested in my forked repo.
- DASHBORAD_RBAC : True
- User has acess to datasets or alpha role kind.
- If admin published the dashboard alpha role user can see the dashboard in dashboard list view page but not able to view the dashboard in /dashboard/<idorslug>
- If the role to the dashboard for the alpha is given then only able to view the dashoard in `dashboard/<idorslug>`
this is what my understanding is. hope other is seeing these and not my custom changes in my fork.(which hadn't done to dashboard stuff majorly).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] MM-Lehmann commented on issue #17227: [dashboard-rbac] Support Fallback to dataset permissions even when ff is on
Posted by GitBox <gi...@apache.org>.
MM-Lehmann commented on issue #17227:
URL: https://github.com/apache/superset/issues/17227#issuecomment-1064070754
I can confirm this bug in 1.4.1. the `dashboard_rbac` feature, although being 'stable', does not work for me in this context.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] nikhil-kuyya commented on issue #17227: [dashboard-rbac] Support Fallback to dataset permissions even when ff is on
Posted by GitBox <gi...@apache.org>.
nikhil-kuyya commented on issue #17227:
URL: https://github.com/apache/superset/issues/17227#issuecomment-1070351678
i understanding this and tested in my forked repo.
- DASHBORAD_RBAC : True
- User has acess to datasets or alpha role kind.
- If admin published the dashboard alpha role user can see the dashboard in dashboard list view page but not able to view the dashboard in /dashboard/<idorslug>
- If the role to the dashboard for the alpha is given then only able to view the dashoard in `dashboard/<idorslug>`
this is what my understanding is. hope other is seeing these and not my custom changes in my fork.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org