You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@myfaces.apache.org by GitBox <gi...@apache.org> on 2022/03/10 17:14:42 UTC

[GitHub] [myfaces] glynn29 opened a new pull request #233: JSF provides a encodeBegin() and an encodeEnd() method on a Renderer.…

glynn29 opened a new pull request #233:
URL: https://github.com/apache/myfaces/pull/233


   … MyFaces currently performs "begin tag" and "end tag" encoding in the encodeEnd(), which breaks any vendor-neutral path for extensibility. This patch moves the "begin tag" encoding logic to the encodeBegin() function so the renderkit can be extended without needed to extend myfaces classes explicitly, but instead be called through the standard JSF api to start a tag.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [myfaces] melloware commented on pull request #233: JSF provides a encodeBegin() and an encodeEnd() method on a Renderer.…

Posted by GitBox <gi...@apache.org>.

melloware commented on pull request #233:
URL: https://github.com/apache/myfaces/pull/233#issuecomment-1085793491


   @glynn29 thanks for your excellent contribution!  I am going to merge these and then I am going to try and write a unit test that checks the output of this component. I noticed there are no real unit tests for HTML components in this suite so its a gap.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [myfaces] melloware commented on pull request #233: JSF provides a encodeBegin() and an encodeEnd() method on a Renderer.…

Posted by GitBox <gi...@apache.org>.

melloware commented on pull request #233:
URL: https://github.com/apache/myfaces/pull/233#issuecomment-1064360961


   Wasn't this already done in this PR?
   
   https://github.com/apache/myfaces/pull/228
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [myfaces] glynn29 commented on pull request #233: JSF provides a encodeBegin() and an encodeEnd() method on a Renderer.…

Posted by GitBox <gi...@apache.org>.

glynn29 commented on pull request #233:
URL: https://github.com/apache/myfaces/pull/233#issuecomment-1072604934


   Thank you for the feedback, I'm hoping my following explanation helps. Perhaps I should add the following as comments? 
   
   This renderer actually handles two classes: UISelectBoolean and UISelectMany. We are merely trying to fix UISelectBoolean in this patch, and not UISelectMany at this time to try to keep merge requests small and focused. 
   
   The single checkbox INPUT_ELEM for UISelectBoolean is opened in `encodeBegin()`, and closed in the `encodeEnd()`. 
   
   The INPUT_ELEM for UISelectMany is left alone in `encodeEnd()`. In `renderCheckboxList()` for UISelectMany, it calls the single checkbox renderer `renderCheckbox()`. The additional branch to check for an instanceof UISelectMany leaves the the current behavior for writing the end element unchanged for this class. 
   
   We can make changes to handle both classes in this patch, but we'd prefer to handle in a separate PR. 
   
   We have tested this manually and it is passing the unit tests written in `HtmlCheckboxRendererTest`. 
   
   Hopefully this clears things up. Thank you!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [myfaces] glynn29 commented on pull request #233: JSF provides a encodeBegin() and an encodeEnd() method on a Renderer.…

Posted by GitBox <gi...@apache.org>.

glynn29 commented on pull request #233:
URL: https://github.com/apache/myfaces/pull/233#issuecomment-1070971205


   Hello, I have posted a backport PR for each version and was checking to see if there were any changes or improvements i can make to them. Thank you!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [myfaces] glynn29 commented on pull request #233: JSF provides a encodeBegin() and an encodeEnd() method on a Renderer.…

Posted by GitBox <gi...@apache.org>.

glynn29 commented on pull request #233:
URL: https://github.com/apache/myfaces/pull/233#issuecomment-1070971205


   Hello, I have posted a backport PR for each version and was checking to see if there were any changes or improvements i can make to them. Thank you!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [myfaces] exabrial edited a comment on pull request #233: JSF provides a encodeBegin() and an encodeEnd() method on a Renderer.…

Posted by GitBox <gi...@apache.org>.

exabrial edited a comment on pull request #233:
URL: https://github.com/apache/myfaces/pull/233#issuecomment-1065344813


   @glynn29 actually works at the same company as I do :) We ran into the same issue with another renderer. We're going to try and fix these in the same manner as #228 as we find them. The fix here should hopefully be up to the same standards as the other patch. If not, let us know and we're more then willing to help out. Thank you guys!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [myfaces] exabrial commented on pull request #233: JSF provides a encodeBegin() and an encodeEnd() method on a Renderer.…

Posted by GitBox <gi...@apache.org>.

exabrial commented on pull request #233:
URL: https://github.com/apache/myfaces/pull/233#issuecomment-1065344813


   @glynn29 actually works at the same company as I do :) We ran into the same issue with another renderer. We're going to try and fix these in the same manner as #228 as we find them. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [myfaces] glynn29 commented on pull request #233: JSF provides a encodeBegin() and an encodeEnd() method on a Renderer.…

Posted by GitBox <gi...@apache.org>.

glynn29 commented on pull request #233:
URL: https://github.com/apache/myfaces/pull/233#issuecomment-1064362856


   It is very similar, but for a different base renderer class. This one is for HtmlCheckboxRendererBase, the other was for HtmlTextRendererBase.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [myfaces] melloware commented on pull request #233: JSF provides a encodeBegin() and an encodeEnd() method on a Renderer.…

Posted by GitBox <gi...@apache.org>.

melloware commented on pull request #233:
URL: https://github.com/apache/myfaces/pull/233#issuecomment-1064369163


   cc @exabrial


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [myfaces] melloware merged pull request #233: JSF provides a encodeBegin() and an encodeEnd() method on a Renderer.…

Posted by GitBox <gi...@apache.org>.

melloware merged pull request #233:
URL: https://github.com/apache/myfaces/pull/233


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [myfaces] melloware commented on pull request #233: JSF provides a encodeBegin() and an encodeEnd() method on a Renderer.…

Posted by GitBox <gi...@apache.org>.

melloware commented on pull request #233:
URL: https://github.com/apache/myfaces/pull/233#issuecomment-1065367212


   Excellent.  Please make sure to have backport PR for each version like last time.  Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [myfaces] tandraschko commented on pull request #233: JSF provides a encodeBegin() and an encodeEnd() method on a Renderer.…

Posted by GitBox <gi...@apache.org>.

tandraschko commented on pull request #233:
URL: https://github.com/apache/myfaces/pull/233#issuecomment-1072494055


   it looks weird for me that sometimes the INPUT_ELEM is closed in the method, sometimes out of the method?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [myfaces] tandraschko edited a comment on pull request #233: JSF provides a encodeBegin() and an encodeEnd() method on a Renderer.…

Posted by GitBox <gi...@apache.org>.

tandraschko edited a comment on pull request #233:
URL: https://github.com/apache/myfaces/pull/233#issuecomment-1072494055


   it looks weird for me that sometimes the INPUT_ELEM is closed in the method, sometimes out of the method?
   
   it looks weird in general, it needs a deep review 
   
   do we have tests for this components?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org