[GitHub] [ratis] adoroszlai commented on pull request #702: RATIS-1656. Leftover usage of ForkJoinPool.commonPool() in RaftServerImpl

[GitBox <gi...@apache.org>]

adoroszlai commented on PR #702:
URL: https://github.com/apache/ratis/pull/702#issuecomment-1206454041

   Tested `TestInstallSnapshotNotificationWithGrpc` repeatedly both without and with this patch.
   
   1. [without the patch](https://github.com/adoroszlai/incubator-ratis/actions/runs/2803202957)
      * timeout: 1%
      * `IllegalArgumentException: ...-SegmentedRaftLog is expected to be opened but it is CLOSED`: 10%
   2. [with the patch](https://github.com/adoroszlai/incubator-ratis/actions/runs/2803208217)
      * timeout: 8%
      * `IllegalArgumentException: ...-SegmentedRaftLog is expected to be opened but it is CLOSED`: none
   
   Timeout happens while cluster is shutting down:
   
   ```
   TestTimedOutException: test timed out after 100 seconds
   	at org.apache.ratis.server.impl.RaftServerProxy$ImplMap.toString(RaftServerProxy.java:159)
   	at java.lang.String.valueOf(String.java:2994)
   	at java.lang.StringBuilder.append(StringBuilder.java:136)
   	at org.apache.ratis.server.impl.RaftServerProxy.toString(RaftServerProxy.java:637)
   	...
   	at org.apache.ratis.server.impl.MiniRaftCluster.printServers(MiniRaftCluster.java:534)
   	at org.apache.ratis.server.impl.MiniRaftCluster.shutdown(MiniRaftCluster.java:832)
   	at org.apache.ratis.server.impl.MiniRaftCluster$Factory$Get.runWithNewCluster(MiniRaftCluster.java:144)
   	at org.apache.ratis.server.impl.MiniRaftCluster$Factory$Get.runWithNewCluster(MiniRaftCluster.java:118)
   	at org.apache.ratis.InstallSnapshotNotificationTests.testInstallSnapshotDuringBootstrap(InstallSnapshotNotificationTests.java:501)
   ```
   
   Looking into that I've found `parallelStream` in `RaftServerProxy`: https://github.com/adoroszlai/incubator-ratis/commit/374396d6b6547f479371435f97bb7b0163bd0d77
   
   With that additional change
    * `testInstallSnapshotDuringBootstrap` [timed out](https://github.com/adoroszlai/incubator-ratis/runs/7691221109?check_suite_focus=true#step:5:1117) 1%
    * `testInstallSnapshotInstalledEvent` [timed out](https://github.com/adoroszlai/incubator-ratis/runs/7691221280?check_suite_focus=true#step:5:11127) 1%
    * `testInstallSnapshotInstalledEvent` [failed](https://github.com/adoroszlai/incubator-ratis/runs/7691221372?check_suite_focus=true#step:5:3617) 1%
    * `testRestartFollower` [failed](https://github.com/adoroszlai/incubator-ratis/runs/7691221280?check_suite_focus=true#step:5:10492) with `IllegalArgumentException` 1%
   
   ```
   TestTimedOutException: test timed out after 100 seconds
   	...
   	at org.apache.ratis.grpc.client.GrpcClientProtocolClient.setConfiguration(GrpcClientProtocolClient.java:200)
   	at org.apache.ratis.grpc.client.GrpcClientRpc.sendRequest(GrpcClientRpc.java:102)
   	at org.apache.ratis.client.impl.BlockingImpl.sendRequest(BlockingImpl.java:134)
   	at org.apache.ratis.client.impl.BlockingImpl.sendRequestWithRetry(BlockingImpl.java:99)
   	at org.apache.ratis.client.impl.AdminImpl.setConfiguration(AdminImpl.java:46)
   	at org.apache.ratis.client.api.AdminApi.setConfiguration(AdminApi.java:51)
   	at org.apache.ratis.client.api.AdminApi.setConfiguration(AdminApi.java:45)
   	at org.apache.ratis.server.impl.MiniRaftCluster.setConfiguration(MiniRaftCluster.java:816)
   	at org.apache.ratis.InstallSnapshotNotificationTests.testInstallSnapshotInstalledEvent(InstallSnapshotNotificationTests.java:463)
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org