You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/04/14 06:59:39 UTC
[GitHub] [spark] sarutak opened a new pull request #32162: [MINOR][SQL] Refactor the comments in HiveClientImpl.withHiveState
sarutak opened a new pull request #32162:
URL: https://github.com/apache/spark/pull/32162
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This PR refactors three parts of the comments in `HiveClientImpl.withHiveState`
One is about the following comment.
```
// The classloader in clientLoader could be changed after addJar, always use the latest
// classloader.
```
The comment was added in SPARK-10810 (#8909) because `IsolatedClientLoader.classLoader` was declared as `var`.
But the field is now `val` and cannot be changed after instanciation.
So, the comment can confuse developers.
One is about the following code and comment.
```
// classloader. We explicitly set the context class loader since "conf.setClassLoader" does
// not do that, and the Hive client libraries may need to load classes defined by the client's
// class loader.
Thread.currentThread().setContextClassLoader(clientLoader.classLoader)
```
It's not trivial why this part is necessary and it's difficult when we can remove this code in the future.
So, I revised the comment by adding the reference of the related JIRA.
And the last one is about the following code and comment.
```
// Replace conf in the thread local Hive with current conf
Hive.get(conf)
```
It's also not trivial why this part is necessary.
I revised the comment by adding the reference of the related discussion.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
To make code more readable.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
It's just a comment refactoring so I add no new test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32162: [MINOR][SQL] Refactor the comments in HiveClientImpl.withHiveState
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32162:
URL: https://github.com/apache/spark/pull/32162#issuecomment-819957837
**[Test build #137385 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137385/testReport)** for PR 32162 at commit [`badeb87`](https://github.com/apache/spark/commit/badeb87a363d68ac92349c9edfa9c921fd37d750).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32162: [MINOR][SQL] Refactor the comments in HiveClientImpl.withHiveState
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32162:
URL: https://github.com/apache/spark/pull/32162#issuecomment-820043597
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137385/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32162: [MINOR][SQL] Refactor the comments in HiveClientImpl.withHiveState
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32162:
URL: https://github.com/apache/spark/pull/32162#issuecomment-819340774
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41914/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32162: [MINOR][SQL] Refactor the comments in HiveClientImpl.withHiveState
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32162:
URL: https://github.com/apache/spark/pull/32162#issuecomment-820012228
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32162: [MINOR][SQL] Refactor the comments in HiveClientImpl.withHiveState
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32162:
URL: https://github.com/apache/spark/pull/32162#issuecomment-820040096
**[Test build #137385 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137385/testReport)** for PR 32162 at commit [`badeb87`](https://github.com/apache/spark/commit/badeb87a363d68ac92349c9edfa9c921fd37d750).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `public class VectorizedBLAS extends F2jBLAS `
* `trait AnalysisOnlyCommand extends Command `
* ` implicit class MetadataColumnHelper(attr: Attribute) `
* `case class WriteToDataSourceV2(`
* `case class WriteToMicroBatchDataSource(`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #32162: [MINOR][SQL] Refactor the comments in HiveClientImpl.withHiveState
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #32162:
URL: https://github.com/apache/spark/pull/32162
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32162: [MINOR][SQL] Refactor the comments in HiveClientImpl.withHiveState
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32162:
URL: https://github.com/apache/spark/pull/32162#issuecomment-819340774
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41914/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32162: [MINOR][SQL] Refactor the comments in HiveClientImpl.withHiveState
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32162:
URL: https://github.com/apache/spark/pull/32162#issuecomment-819389811
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137334/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32162: [MINOR][SQL] Refactor the comments in HiveClientImpl.withHiveState
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32162:
URL: https://github.com/apache/spark/pull/32162#issuecomment-819302859
**[Test build #137334 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137334/testReport)** for PR 32162 at commit [`867b8ad`](https://github.com/apache/spark/commit/867b8ad779a335a14aef5e51a4e531de0fd5f28f).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32162: [MINOR][SQL] Refactor the comments in HiveClientImpl.withHiveState
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32162:
URL: https://github.com/apache/spark/pull/32162#issuecomment-819302859
**[Test build #137334 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137334/testReport)** for PR 32162 at commit [`867b8ad`](https://github.com/apache/spark/commit/867b8ad779a335a14aef5e51a4e531de0fd5f28f).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32162: [MINOR][SQL] Refactor the comments in HiveClientImpl.withHiveState
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32162:
URL: https://github.com/apache/spark/pull/32162#issuecomment-819388809
**[Test build #137334 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137334/testReport)** for PR 32162 at commit [`867b8ad`](https://github.com/apache/spark/commit/867b8ad779a335a14aef5e51a4e531de0fd5f28f).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #32162: [MINOR][SQL] Refactor the comments in HiveClientImpl.withHiveState
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #32162:
URL: https://github.com/apache/spark/pull/32162#issuecomment-820090451
Thank you, @sarutak .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32162: [MINOR][SQL] Refactor the comments in HiveClientImpl.withHiveState
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32162:
URL: https://github.com/apache/spark/pull/32162#issuecomment-820043597
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137385/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32162: [MINOR][SQL] Refactor the comments in HiveClientImpl.withHiveState
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32162:
URL: https://github.com/apache/spark/pull/32162#issuecomment-819338060
Kubernetes integration test unable to build dist.
exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41914/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32162: [MINOR][SQL] Refactor the comments in HiveClientImpl.withHiveState
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32162:
URL: https://github.com/apache/spark/pull/32162#issuecomment-820014891
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41962/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32162: [MINOR][SQL] Refactor the comments in HiveClientImpl.withHiveState
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32162:
URL: https://github.com/apache/spark/pull/32162#issuecomment-819389811
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137334/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] commented on pull request #32162: [MINOR][SQL] Refactor the comments in HiveClientImpl.withHiveState
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #32162:
URL: https://github.com/apache/spark/pull/32162#issuecomment-819950836
**[Test build #750330910](https://github.com/sarutak/spark/actions/runs/750330910)** for PR 32162 at commit [`badeb87`](https://github.com/sarutak/spark/commit/badeb87a363d68ac92349c9edfa9c921fd37d750).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32162: [MINOR][SQL] Refactor the comments in HiveClientImpl.withHiveState
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32162:
URL: https://github.com/apache/spark/pull/32162#issuecomment-820014891
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41962/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32162: [MINOR][SQL] Refactor the comments in HiveClientImpl.withHiveState
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32162:
URL: https://github.com/apache/spark/pull/32162#issuecomment-819957837
**[Test build #137385 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137385/testReport)** for PR 32162 at commit [`badeb87`](https://github.com/apache/spark/commit/badeb87a363d68ac92349c9edfa9c921fd37d750).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org