You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Andrew Onischuk <ao...@hortonworks.com> on 2014/03/31 16:31:41 UTC

Review Request 19846: Storm daemons need to run under supervision

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19846/
-----------------------------------------------------------

Review request for Ambari and Dmytro Sen.


Bugs: AMBARI-5280
    https://issues.apache.org/jira/browse/AMBARI-5280


Repository: ambari


Description
-------

This is critical. A storm cluster cannot run in production unless its daemons
are run under supervision. If we were to release without this, I would
personally be embarrassed. Supervisord is an easy install via rpm, and
supports starting/stopping individual services from the command line:
`supervisorctl stop storm-nimbus` So we should be able to do that from ambari,
right? I will drop everything else to help out with this - work nights,
weekends, etc. This is very important.


Diffs
-----

  ambari-server/src/main/resources/stacks/HDP/2.1/services/STORM/package/scripts/nimbus.py 4ddc28f 
  ambari-server/src/main/resources/stacks/HDP/2.1/services/STORM/package/scripts/nimbus_prod.py PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.1/services/STORM/package/scripts/supervisor_prod.py PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.1/services/STORM/package/scripts/supervisord_service.py PRE-CREATION 

Diff: https://reviews.apache.org/r/19846/diff/


Testing
-------


Thanks,

Andrew Onischuk


Re: Review Request 19846: Storm daemons need to run under supervision

Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19846/#review39045
-----------------------------------------------------------

Ship it!


[INFO] Ambari Server ..................................... SUCCESS [13:09.042s]


- Dmytro Sen


On March 31, 2014, 2:50 p.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19846/
> -----------------------------------------------------------
> 
> (Updated March 31, 2014, 2:50 p.m.)
> 
> 
> Review request for Ambari and Dmytro Sen.
> 
> 
> Bugs: AMBARI-5280
>     https://issues.apache.org/jira/browse/AMBARI-5280
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> This is critical. A storm cluster cannot run in production unless its daemons
> are run under supervision. If we were to release without this, I would
> personally be embarrassed. Supervisord is an easy install via rpm, and
> supports starting/stopping individual services from the command line:
> `supervisorctl stop storm-nimbus`
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/2.1/services/STORM/package/scripts/nimbus.py 4ddc28f 
>   ambari-server/src/main/resources/stacks/HDP/2.1/services/STORM/package/scripts/nimbus_prod.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.1/services/STORM/package/scripts/supervisor_prod.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.1/services/STORM/package/scripts/supervisord_service.py PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.1/STORM/test_storm_nimbus_prod.py PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.1/STORM/test_storm_supervisor_prod.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/19846/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>


Re: Review Request 19846: Storm daemons need to run under supervision

Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19846/
-----------------------------------------------------------

(Updated March 31, 2014, 2:50 p.m.)


Review request for Ambari and Dmytro Sen.


Bugs: AMBARI-5280
    https://issues.apache.org/jira/browse/AMBARI-5280


Repository: ambari


Description (updated)
-------

This is critical. A storm cluster cannot run in production unless its daemons
are run under supervision. If we were to release without this, I would
personally be embarrassed. Supervisord is an easy install via rpm, and
supports starting/stopping individual services from the command line:
`supervisorctl stop storm-nimbus`


Diffs
-----

  ambari-server/src/main/resources/stacks/HDP/2.1/services/STORM/package/scripts/nimbus.py 4ddc28f 
  ambari-server/src/main/resources/stacks/HDP/2.1/services/STORM/package/scripts/nimbus_prod.py PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.1/services/STORM/package/scripts/supervisor_prod.py PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.1/services/STORM/package/scripts/supervisord_service.py PRE-CREATION 
  ambari-server/src/test/python/stacks/2.1/STORM/test_storm_nimbus_prod.py PRE-CREATION 
  ambari-server/src/test/python/stacks/2.1/STORM/test_storm_supervisor_prod.py PRE-CREATION 

Diff: https://reviews.apache.org/r/19846/diff/


Testing
-------


Thanks,

Andrew Onischuk


Re: Review Request 19846: Storm daemons need to run under supervision

Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19846/
-----------------------------------------------------------

(Updated March 31, 2014, 2:33 p.m.)


Review request for Ambari and Dmytro Sen.


Bugs: AMBARI-5280
    https://issues.apache.org/jira/browse/AMBARI-5280


Repository: ambari


Description
-------

This is critical. A storm cluster cannot run in production unless its daemons
are run under supervision. If we were to release without this, I would
personally be embarrassed. Supervisord is an easy install via rpm, and
supports starting/stopping individual services from the command line:
`supervisorctl stop storm-nimbus` So we should be able to do that from ambari,
right? I will drop everything else to help out with this - work nights,
weekends, etc. This is very important.


Diffs (updated)
-----

  ambari-server/src/main/resources/stacks/HDP/2.1/services/STORM/package/scripts/nimbus.py 4ddc28f 
  ambari-server/src/main/resources/stacks/HDP/2.1/services/STORM/package/scripts/nimbus_prod.py PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.1/services/STORM/package/scripts/supervisor_prod.py PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.1/services/STORM/package/scripts/supervisord_service.py PRE-CREATION 
  ambari-server/src/test/python/stacks/2.1/STORM/test_storm_nimbus_prod.py PRE-CREATION 
  ambari-server/src/test/python/stacks/2.1/STORM/test_storm_supervisor_prod.py PRE-CREATION 

Diff: https://reviews.apache.org/r/19846/diff/


Testing
-------


Thanks,

Andrew Onischuk