You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "zhaorui2022 (via GitHub)" <gi...@apache.org> on 2023/10/06 22:11:11 UTC

[I] Sqllab UI regession where it's not displaying certain string values [superset]

zhaorui2022 opened a new issue, #25561:
URL: https://github.com/apache/superset/issues/25561

   After we upgraded to 3.0.0, we have received user reporting query results not rendering in sqllab results. I have checked the api call results in network tab and can confirm the correct value has been returned from the backend database. So this seems like an issue with front end.
   
   #### How to reproduce the bug
   
   1. Go to Sqllab, select any database (I tested this on Presto and MySQL)
   2. Run `SELECT '<abcdef:12345>' as test_str`
   3. Run the query
   4. See error
   
   ### Expected results
   
   String values rendered as in 2.0.0
   
   ### Actual results
   
   String values not being rendered
   
   #### Screenshots
   
   If applicable, add screenshots to help explain your problem.
   
   ![Screenshot 2023-10-06 at 3 09 52 PM](https://github.com/apache/superset/assets/105950525/61a19af1-2be2-4fb4-9f22-ab3be0a0e1b0)
   
   ![Screenshot 2023-10-06 at 3 10 06 PM](https://github.com/apache/superset/assets/105950525/3c2ed50c-e5ee-4866-8e9e-8b0ef769efdc)
   
   
   ### Environment
   
   (please complete the following information):
   
   - browser type and version: Chrome latest stable version
   - superset version: `superset version` 3.0.0
   - python version: `python --version`3.9
   - node.js version: `node -v` v20.8.0
   - any feature flags active: N/A
   
   ### Checklist
   
   Make sure to follow these steps before submitting your issue - thank you!
   
   - [x] I have checked the superset logs for python stacktraces and included it here as text if there are any.
   - [x] I have reproduced the issue with at least the latest released version of superset.
   - [x] I have checked the issue tracker for the same issue and I haven't found one similar.
   
   ### Additional context
   
   Add any other context about the problem here.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [I] Sqllab UI regession in 3.0.0 where it's not displaying certain string values [superset]

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #25561:
URL: https://github.com/apache/superset/issues/25561#issuecomment-3145840819

   Opened a PR ^^


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [I] Sqllab UI regession in 3.0.0 where it's not displaying certain string values [superset]

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas closed issue #25561: Sqllab UI regession in 3.0.0 where it's not displaying certain string values
URL: https://github.com/apache/superset/issues/25561


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [I] Sqllab UI regession in 3.0.0 where it's not displaying certain string values [superset]

Posted by "bkyryliuk (via GitHub)" <gi...@apache.org>.
bkyryliuk commented on issue #25561:
URL: https://github.com/apache/superset/issues/25561#issuecomment-1751788713

   probably related code: https://github.com/apache/superset/blob/178607093fa826947d9130386705a2e3ed3d9a88/superset-frontend/packages/superset-ui-core/src/utils/html.tsx#L35
   
   See: https://github.com/apache/superset/blob/178607093fa826947d9130386705a2e3ed3d9a88/superset-frontend/packages/superset-ui-core/src/utils/html.tsx#L31
   Effectively it removes all it thinks is html.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [I] Sqllab UI regession in 3.0.0 where it's not displaying certain string values [superset]

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #25561:
URL: https://github.com/apache/superset/issues/25561#issuecomment-3145779178

   I meant, maybe @dosu can help. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [I] Sqllab UI regession in 3.0.0 where it's not displaying certain string values [superset]

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #25561:
URL: https://github.com/apache/superset/issues/25561#issuecomment-2447908229

   I know @mistercrunch has looked at some of this HTML rendering business, just in case he sees any obvious solution here


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [I] Sqllab UI regession in 3.0.0 where it's not displaying certain string values [superset]

Posted by "mistercrunch (via GitHub)" <gi...@apache.org>.
mistercrunch commented on issue #25561:
URL: https://github.com/apache/superset/issues/25561#issuecomment-2447967468

   Recent related feature -> https://github.com/apache/superset/pull/27969, so it looks like it can be switched off, but given the issue here, better/smarter html detection could help as well. For SQL Lab specifically looks like the flag is here, but idk how these flags get set/managed (?)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [I] Sqllab UI regession in 3.0.0 where it's not displaying certain string values [superset]

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #25561:
URL: https://github.com/apache/superset/issues/25561#issuecomment-1992551532

   This is still happening on current master. We're open to proposals/PRs to fix this. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [I] Sqllab UI regession in 3.0.0 where it's not displaying certain string values [superset]

Posted by "mistercrunch (via GitHub)" <gi...@apache.org>.
mistercrunch commented on issue #25561:
URL: https://github.com/apache/superset/issues/25561#issuecomment-2448185350

   For the record I think this is the area that would need to be improved if we wanted to be smarter around detecting html -> https://github.com/apache/superset/blob/master/superset-frontend/packages/superset-ui-core/src/utils/html.tsx#L43-L45


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [I] Sqllab UI regession in 3.0.0 where it's not displaying certain string values [superset]

Posted by "dosubot[bot] (via GitHub)" <gi...@apache.org>.
dosubot[bot] commented on issue #25561:
URL: https://github.com/apache/superset/issues/25561#issuecomment-3145786673

   <!-- Answer -->
   The root cause is the frontend’s aggressive HTML detection logic: any string with angle brackets (like `<abcdef:12345>`) is classified as HTML by the isProbablyHTML function, even if it’s not valid HTML. When this happens, Superset tries to render it as HTML using dangerouslySetInnerHTML, but browsers ignore unknown tags, so nothing appears in the cell. This is why toggling the “Render HTML” option doesn’t fix the issue—the detection logic still treats these strings as HTML and hides them, regardless of the toggle’s state. The relevant code is in superset-frontend/packages/superset-ui-core/src/utils/html.tsx and is global and hardcoded, so there’s no user-facing way to adjust this behavior without a code change. See [this related issue and explanation](https://github.com/apache/superset/issues/34082).
   
   Workarounds include disabling HTML rendering for affected columns (where possible) or preprocessing your data to escape angle brackets (replace `<` with `&lt;` and `>` with `&gt;`). To truly fix this, the detection logic in isProbablyHTML would need to be refined to better distinguish between actual HTML and plain strings with angle brackets. No recent PRs address this yet.
   
   
   <!-- Dosu Comment Footer -->
   *To reply, just mention [@dosu](https://go.dosu.dev/dosubot).*
   
   ---
   <sup>How did I do? [Good](https://app.dosu.dev/response-feedback/d628baeb-5732-4539-ae69-df2fed9f19fd?feedback_type=great_response) | [Irrelevant](https://app.dosu.dev/response-feedback/d628baeb-5732-4539-ae69-df2fed9f19fd?feedback_type=irrelevant_answer) | [Incorrect](https://app.dosu.dev/response-feedback/d628baeb-5732-4539-ae69-df2fed9f19fd?feedback_type=incorrect_sources) | [Verbose](https://app.dosu.dev/response-feedback/d628baeb-5732-4539-ae69-df2fed9f19fd?feedback_type=too_verbose) | [Hallucination](https://app.dosu.dev/response-feedback/d628baeb-5732-4539-ae69-df2fed9f19fd?feedback_type=hallucination) | [Report 🐛](https://app.dosu.dev/response-feedback/d628baeb-5732-4539-ae69-df2fed9f19fd?feedback_type=bug_report) | [Other](https://app.dosu.dev/response-feedback/d628baeb-5732-4539-ae69-df2fed9f19fd?feedback_type=other)</sup>&nbsp;&nbsp;[![Chat with Dosu](https://dosu.dev/dosu-chat-badge.svg)](https://app.dosu.dev/a28d3c7e-a9d3-459e-9fb6-3a6f9ff4f357/ask?utm_source=githu
 b)&nbsp;[![Join Discord](https://img.shields.io/badge/join-5865F2?logo=discord&logoColor=white&label=)](https://go.dosu.dev/discord-bot)&nbsp;[![Share on X](https://img.shields.io/badge/X-share-black)](https://twitter.com/intent/tweet?text=%40dosu_ai%20helped%20me%20solve%20this%20issue!&url=https%3A//github.com/apache/superset/issues/25561)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [I] Sqllab UI regession in 3.0.0 where it's not displaying certain string values [superset]

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #25561:
URL: https://github.com/apache/superset/issues/25561#issuecomment-2819645972

   Still happening in 4.1.2, but this has been silent for upward of 6 months, and is likely to be closed as "not planned" before long, unless anyone here on the thread wants to tackle it. PRs welcome!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [I] Sqllab UI regession in 3.0.0 where it's not displaying certain string values [superset]

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #25561:
URL: https://github.com/apache/superset/issues/25561#issuecomment-2822600339

   Maybe @dosu-bot can help move this forward.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [I] Sqllab UI regession in 3.0.0 where it's not displaying certain string values [superset]

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #25561:
URL: https://github.com/apache/superset/issues/25561#issuecomment-2447905434

   Noting that in the chart builder, unchecking HTML rendering doesn't fix the issue there either.
   <img width="1700" alt="image" src="https://github.com/user-attachments/assets/670565f2-df05-40fe-ba36-cdd81da36afd">
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [I] Sqllab UI regession in 3.0.0 where it's not displaying certain string values [superset]

Posted by "zhaorui2022 (via GitHub)" <gi...@apache.org>.
zhaorui2022 commented on issue #25561:
URL: https://github.com/apache/superset/issues/25561#issuecomment-1751455045

   I have taken a look at the code but don't have a clue due to lack of front end code knowledge. @justinpark Do you happen to know what the problem might be?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org