You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by ru jia <82...@163.com> on 2020/10/10 07:14:27 UTC

Review Request 72946: RANGER-3032:The log4j properties of rangeradmin cannot take effect dynamically

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72946/
-----------------------------------------------------------

Review request for ranger.


Bugs: RANGER-3032
    https://issues.apache.org/jira/browse/RANGER-3032


Repository: ranger


Description
-------

log4j.properties of rangeradmin should be watched by default.


Diffs
-----

  embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/EmbeddedServer.java 9df95fbe7 


Diff: https://reviews.apache.org/r/72946/diff/1/


Testing
-------

already used in production environment


Thanks,

ru jia


Re: Review Request 72946: RANGER-3032:The log4j properties of rangeradmin cannot take effect dynamically

Posted by bhavik patel <bh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72946/#review222017
-----------------------------------------------------------



This improvement can be applicable to Usersync and Tagsync service.

- bhavik patel


On Oct. 10, 2020, 7:14 a.m., ru jia wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72946/
> -----------------------------------------------------------
> 
> (Updated Oct. 10, 2020, 7:14 a.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-3032
>     https://issues.apache.org/jira/browse/RANGER-3032
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> log4j.properties of rangeradmin should be watched by default.
> 
> 
> Diffs
> -----
> 
>   embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/EmbeddedServer.java 9df95fbe7 
> 
> 
> Diff: https://reviews.apache.org/r/72946/diff/1/
> 
> 
> Testing
> -------
> 
> already used in production environment
> 
> 
> Thanks,
> 
> ru jia
> 
>


Re: Review Request 72946: RANGER-3032:The log4j properties of rangeradmin cannot take effect dynamically

Posted by bhavik patel <bh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72946/#review222045
-----------------------------------------------------------


Ship it!




Ship It!

- bhavik patel


On Oct. 13, 2020, 10:14 a.m., ru jia wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72946/
> -----------------------------------------------------------
> 
> (Updated Oct. 13, 2020, 10:14 a.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-3032
>     https://issues.apache.org/jira/browse/RANGER-3032
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> log4j.properties of rangeradmin should be watched by default.
> 
> 
> Diffs
> -----
> 
>   embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/EmbeddedServer.java 9df95fbe7 
>   tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSynchronizer.java fefb6bfb5 
>   unixauthservice/src/main/java/org/apache/ranger/authentication/UnixAuthenticationService.java fa146c26a 
> 
> 
> Diff: https://reviews.apache.org/r/72946/diff/2/
> 
> 
> Testing
> -------
> 
> already used in production environment
> 
> 
> Thanks,
> 
> ru jia
> 
>


Re: Review Request 72946: RANGER-3032:The log4j properties of rangeradmin cannot take effect dynamically

Posted by ru jia <82...@163.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72946/
-----------------------------------------------------------

(Updated 十月 13, 2020, 10:14 a.m.)


Review request for ranger.


Bugs: RANGER-3032
    https://issues.apache.org/jira/browse/RANGER-3032


Repository: ranger


Description
-------

log4j.properties of rangeradmin should be watched by default.


Diffs (updated)
-----

  embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/EmbeddedServer.java 9df95fbe7 
  tagsync/src/main/java/org/apache/ranger/tagsync/process/TagSynchronizer.java fefb6bfb5 
  unixauthservice/src/main/java/org/apache/ranger/authentication/UnixAuthenticationService.java fa146c26a 


Diff: https://reviews.apache.org/r/72946/diff/2/

Changes: https://reviews.apache.org/r/72946/diff/1-2/


Testing
-------

already used in production environment


Thanks,

ru jia