[GitHub] spark pull request: [SPARK-2710] [SQL] Build SchemaRDD from a Jdbc...

[chenghao-intel <gi...@git.apache.org>]

Github user chenghao-intel commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1612#discussion_r16642061
  
    --- Diff: core/src/main/scala/org/apache/spark/rdd/JdbcRDD.scala ---
    @@ -57,6 +61,8 @@ class JdbcRDD[T: ClassTag](
         mapRow: (ResultSet) => T = JdbcRDD.resultSetToObjectArray _)
       extends RDD[T](sc, Nil) with Logging {
     
    +  private var schema: Seq[(String, Int, Boolean)] = null
    --- End diff --
    
    Move the schema stuff to `JdbcResultSetRDD`? We'd better keep the Spark core clean and same implementation pattern with the other Core RDDs.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org