You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by shroman <gi...@git.apache.org> on 2017/03/08 02:53:25 UTC
[GitHub] incubator-rocketmq-site pull request #8: Added having unit tests as a necess...
GitHub user shroman opened a pull request:
https://github.com/apache/incubator-rocketmq-site/pull/8
Added having unit tests as a necessary condition for PR (when applica\u2026
\u2026ble).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shroman/incubator-rocketmq-site pr-add-unit-tests
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-rocketmq-site/pull/8.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #8
----
commit 7de72692774474ddab9c7a8ff8f46c3fbc730113
Author: shtykh_roman <rs...@yahoo.com>
Date: 2017-03-08T02:50:14Z
Added having unit tests as a necessary condition for PR (when applicable).
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq-site issue #8: Added having unit tests as a necessary con...
Posted by shroman <gi...@git.apache.org>.
Github user shroman commented on the issue:
https://github.com/apache/incubator-rocketmq-site/pull/8
@zhouxinyu Sure, I just wanted to be sure this addition to the PR submission policy is ok ;)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq-site issue #8: Added having unit tests as a necessary con...
Posted by zhouxinyu <gi...@git.apache.org>.
Github user zhouxinyu commented on the issue:
https://github.com/apache/incubator-rocketmq-site/pull/8
@shroman Could you please merge this PR by yourself \u2299\u25bd\u2299?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq-site issue #8: Added having unit tests as a necessary con...
Posted by vongosling <gi...@git.apache.org>.
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq-site/pull/8
@shroman LGTM :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq-site pull request #8: Added having unit tests as a necess...
Posted by shroman <gi...@git.apache.org>.
Github user shroman closed the pull request at:
https://github.com/apache/incubator-rocketmq-site/pull/8
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---