[GitHub] [pulsar] liangyepianzhou commented on a diff in pull request #20229: [fix] [broker] Producer created by replicator is not displayed in topic stats

["liangyepianzhou (via GitHub)" <gi...@apache.org>]

liangyepianzhou commented on code in PR #20229:
URL: https://github.com/apache/pulsar/pull/20229#discussion_r1186245826


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java:
##########
@@ -2226,9 +2226,8 @@ public CompletableFuture<TopicStatsImpl> asyncGetStats(boolean getPreciseBacklog
 
             if (producer.isRemote()) {
                 remotePublishersStats.put(producer.getRemoteCluster(), publisherStats);
-            } else {
-                stats.addPublisher(publisherStats);
             }
+            stats.addPublisher(publisherStats);

Review Comment:
   LGTM. But I have a little question, whether all the producers (remote or not)  will be included in this TopicStats?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org