You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@struts.apache.org by James Mitchell <jm...@apache.org> on 2005/02/03 04:14:45 UTC
duplicate files
In case anyone missed it in the last batch of commits, there are duplicate
files under:
core/src/test
and
taglib/src/webapp/test/java
I'm sure I screwed up somewhere, but the weird thing is....under core/src,
there's a "test" and a "test-cactus", which only serves to split
TestActionServlet.java (and that's it!) Other than that, there's no
difference. I'm guessing this was an attempt to split off what is needed by
cactus, and what can be handled by Mock objects....but not sure.
Anyone care to comment on this, or give me a suggestion which way to go?
I was planning to remove the ones from core, since the corresponding JSPs
are already in taglib...your thoughts?
--
James Mitchell
Software Engineer / Open Source Evangelist
EdgeTech, Inc.
678.910.8017
AIM: jmitchtx
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: duplicate files
Posted by Martin Cooper <mf...@gmail.com>.
On Thu, 3 Feb 2005 05:47:00 -0500, James Mitchell <jm...@apache.org> wrote:
> Yes, I remember you mentioning that. However, I don't see the cactus test
> being run when I do "maven dist", am I missing something?
No, you're not missing anything. I just haven't tried to do that yet. ;-)
--
Martin Cooper
>
> --
> James Mitchell
> Software Engineer / Open Source Evangelist
> EdgeTech, Inc.
> 678.910.8017
> AIM: jmitchtx
>
> ----- Original Message -----
> From: "Martin Cooper" <mf...@gmail.com>
> To: "Struts Developers List" <de...@struts.apache.org>
> Sent: Wednesday, February 02, 2005 10:40 PM
> Subject: Re: duplicate files
>
> >I moved TestActionServlet to test-cactus recently, as part of the
> > Maven build cleanup for core. The point is that Maven expects to find
> > JUnit tests in 'test' and the Cactus plugin expects to find Cactus
> > unit tests in 'test-cactus'. Once I moved that one class, both the
> > JUnit tests and the Cactus tests "just worked". I'd like to keep it
> > that way. ;-)
> >
> > As far as duplicate files go, shouldn't it just be a case of
> > taglib-independent stuff goes in core, and taglib-dependent stuff goes
> > in taglib? Am I missing something?
> >
> > --
> > Martin Cooper
> >
> >
> > On Wed, 2 Feb 2005 22:14:45 -0500, James Mitchell <jm...@apache.org>
> > wrote:
> >> In case anyone missed it in the last batch of commits, there are
> >> duplicate
> >> files under:
> >>
> >> core/src/test
> >>
> >> and
> >>
> >> taglib/src/webapp/test/java
> >>
> >> I'm sure I screwed up somewhere, but the weird thing is....under
> >> core/src,
> >> there's a "test" and a "test-cactus", which only serves to split
> >> TestActionServlet.java (and that's it!) Other than that, there's no
> >> difference. I'm guessing this was an attempt to split off what is needed
> >> by
> >> cactus, and what can be handled by Mock objects....but not sure.
> >>
> >> Anyone care to comment on this, or give me a suggestion which way to go?
> >>
> >> I was planning to remove the ones from core, since the corresponding JSPs
> >> are already in taglib...your thoughts?
> >>
> >> --
> >> James Mitchell
> >> Software Engineer / Open Source Evangelist
> >> EdgeTech, Inc.
> >> 678.910.8017
> >> AIM: jmitchtx
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> >> For additional commands, e-mail: dev-help@struts.apache.org
> >>
> >>
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> > For additional commands, e-mail: dev-help@struts.apache.org
> >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: duplicate files
Posted by James Mitchell <jm...@apache.org>.
Yes, I remember you mentioning that. However, I don't see the cactus test
being run when I do "maven dist", am I missing something?
--
James Mitchell
Software Engineer / Open Source Evangelist
EdgeTech, Inc.
678.910.8017
AIM: jmitchtx
----- Original Message -----
From: "Martin Cooper" <mf...@gmail.com>
To: "Struts Developers List" <de...@struts.apache.org>
Sent: Wednesday, February 02, 2005 10:40 PM
Subject: Re: duplicate files
>I moved TestActionServlet to test-cactus recently, as part of the
> Maven build cleanup for core. The point is that Maven expects to find
> JUnit tests in 'test' and the Cactus plugin expects to find Cactus
> unit tests in 'test-cactus'. Once I moved that one class, both the
> JUnit tests and the Cactus tests "just worked". I'd like to keep it
> that way. ;-)
>
> As far as duplicate files go, shouldn't it just be a case of
> taglib-independent stuff goes in core, and taglib-dependent stuff goes
> in taglib? Am I missing something?
>
> --
> Martin Cooper
>
>
> On Wed, 2 Feb 2005 22:14:45 -0500, James Mitchell <jm...@apache.org>
> wrote:
>> In case anyone missed it in the last batch of commits, there are
>> duplicate
>> files under:
>>
>> core/src/test
>>
>> and
>>
>> taglib/src/webapp/test/java
>>
>> I'm sure I screwed up somewhere, but the weird thing is....under
>> core/src,
>> there's a "test" and a "test-cactus", which only serves to split
>> TestActionServlet.java (and that's it!) Other than that, there's no
>> difference. I'm guessing this was an attempt to split off what is needed
>> by
>> cactus, and what can be handled by Mock objects....but not sure.
>>
>> Anyone care to comment on this, or give me a suggestion which way to go?
>>
>> I was planning to remove the ones from core, since the corresponding JSPs
>> are already in taglib...your thoughts?
>>
>> --
>> James Mitchell
>> Software Engineer / Open Source Evangelist
>> EdgeTech, Inc.
>> 678.910.8017
>> AIM: jmitchtx
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
>> For additional commands, e-mail: dev-help@struts.apache.org
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
Re: duplicate files
Posted by Martin Cooper <mf...@gmail.com>.
I moved TestActionServlet to test-cactus recently, as part of the
Maven build cleanup for core. The point is that Maven expects to find
JUnit tests in 'test' and the Cactus plugin expects to find Cactus
unit tests in 'test-cactus'. Once I moved that one class, both the
JUnit tests and the Cactus tests "just worked". I'd like to keep it
that way. ;-)
As far as duplicate files go, shouldn't it just be a case of
taglib-independent stuff goes in core, and taglib-dependent stuff goes
in taglib? Am I missing something?
--
Martin Cooper
On Wed, 2 Feb 2005 22:14:45 -0500, James Mitchell <jm...@apache.org> wrote:
> In case anyone missed it in the last batch of commits, there are duplicate
> files under:
>
> core/src/test
>
> and
>
> taglib/src/webapp/test/java
>
> I'm sure I screwed up somewhere, but the weird thing is....under core/src,
> there's a "test" and a "test-cactus", which only serves to split
> TestActionServlet.java (and that's it!) Other than that, there's no
> difference. I'm guessing this was an attempt to split off what is needed by
> cactus, and what can be handled by Mock objects....but not sure.
>
> Anyone care to comment on this, or give me a suggestion which way to go?
>
> I was planning to remove the ones from core, since the corresponding JSPs
> are already in taglib...your thoughts?
>
> --
> James Mitchell
> Software Engineer / Open Source Evangelist
> EdgeTech, Inc.
> 678.910.8017
> AIM: jmitchtx
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
> For additional commands, e-mail: dev-help@struts.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org