You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "CSoulode (via GitHub)" <gi...@apache.org> on 2026/03/17 06:17:51 UTC
[PR] [fix](storage) avoid duplicate exported compaction metrics [doris]
CSoulode opened a new pull request, #61420:
URL: https://github.com/apache/doris/pull/61420
issue: #60791
Add missing labels for compaction task state and compaction io metrics to avoid duplicate Prometheus time series.
### What problem does this PR solve?
Issue Number: close #60791
Related PR: #N/A
Problem Summary:
This PR fixes duplicate Prometheus time series exported by BE compaction metrics.
Although issue #60791 was reported in compute-storage decoupled mode, the root cause is not specific to cloud mode itself. The duplicate series come from shared BE metric definitions/export semantics, where multiple internal metrics were exported with the same metric name and the same label set.
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [x] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
Manual test:
1. Start a local Doris cluster and prepare a tablet with compaction candidates.
2. Trigger cumulative compaction:
```bash
curl -X POST "http://$BE_HOST:$BE_HTTP/api/compaction/run?tablet_id=$TABLET_ID&compact_type=cumulative"
```
3. Check exported compaction task metrics:
```bash
curl -s "http://$BE_HOST:$BE_HTTP/metrics" \
| grep '^doris_be_compaction_task_state_total' \
| sed -E 's/ [^ ]+$//' \
| sort \
| uniq -c
```
Before:
```text
2 doris_be_compaction_task_state_total{type="base"}
2 doris_be_compaction_task_state_total{type="cumulative"}
```
After:
```text
1 doris_be_compaction_task_state_total{state="pending",type="base"}
1 doris_be_compaction_task_state_total{state="pending",type="cumulative"}
1 doris_be_compaction_task_state_total{state="running",type="base"}
1 doris_be_compaction_task_state_total{state="running",type="cumulative"}
```
- Behavior changed:
- [ ] No.
- [x] Yes. <!-- Explain the behavior change --> The exported metric labels in /metrics are changed to avoid duplicate Prometheus series.
- Does this need documentation?
- [x] No.
- [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](storage) avoid duplicate exported compaction metrics [doris]
Posted by "luwei16 (via GitHub)" <gi...@apache.org>.
luwei16 commented on code in PR #61420:
URL: https://github.com/apache/doris/pull/61420#discussion_r3009445033
##########
be/src/common/metrics/doris_metrics.cpp:
##########
@@ -103,15 +103,17 @@ DEFINE_COUNTER_METRIC_PROTOTYPE_5ARG(full_compaction_bytes_total, MetricUnit::BY
compaction_bytes_total, Labels({{"type", "full"}}));
DEFINE_COUNTER_METRIC_PROTOTYPE_5ARG(base_compaction_task_running_total, MetricUnit::ROWSETS, "",
- compaction_task_state_total, Labels({{"type", "base"}}));
+ compaction_task_state_total,
Review Comment:
please add ut
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](storage) avoid duplicate exported compaction metrics [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #61420:
URL: https://github.com/apache/doris/pull/61420#issuecomment-4072651852
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](storage) avoid duplicate exported compaction metrics [doris]
Posted by "fcuello-fudo (via GitHub)" <gi...@apache.org>.
fcuello-fudo commented on PR #61420:
URL: https://github.com/apache/doris/pull/61420#issuecomment-5250774526
Hello, are there any plans to merge this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](storage) avoid duplicate exported compaction metrics [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #61420:
URL: https://github.com/apache/doris/pull/61420#issuecomment-4182170370
# BE UT Coverage Report
Increment line coverage ` ` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/329382bc53c69a06467ad1958c056695036706ec_329382bc53c69a06467ad1958c056695036706ec/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/329382bc53c69a06467ad1958c056695036706ec_329382bc53c69a06467ad1958c056695036706ec/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 52.96% (20068/37895) |
| Line Coverage | 36.54% (188505/515938) |
| Region Coverage | 32.80% (146434/446389) |
| Branch Coverage | 33.95% (64112/188840) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](storage) avoid duplicate exported compaction metrics [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #61420:
URL: https://github.com/apache/doris/pull/61420#issuecomment-4073658059
<details>
<summary>TPC-DS: <b>Total hot run time: 167912 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 36233087b6e50345100ff50f22badfb463bd0ac5, data reload: false
query5 4325 640 519 519
query6 331 222 198 198
query7 4223 466 261 261
query8 332 238 223 223
query9 8725 2729 2730 2729
query10 537 373 333 333
query11 6996 5085 4850 4850
query12 180 132 120 120
query13 1271 444 328 328
query14 5795 3692 3457 3457
query14_1 2813 2774 2773 2773
query15 205 194 174 174
query16 955 445 439 439
query17 880 697 600 600
query18 2427 452 349 349
query19 218 208 186 186
query20 135 128 127 127
query21 213 141 115 115
query22 13197 13776 14692 13776
query23 16381 15786 15621 15621
query23_1 15835 15603 15339 15339
query24 7195 1645 1225 1225
query24_1 1229 1234 1232 1232
query25 566 509 438 438
query26 1253 284 154 154
query27 2752 482 302 302
query28 4521 1883 1876 1876
query29 851 605 512 512
query30 301 230 195 195
query31 1011 967 877 877
query32 89 78 72 72
query33 531 357 296 296
query34 894 871 527 527
query35 637 699 627 627
query36 1111 1182 965 965
query37 138 102 84 84
query38 2973 2900 2881 2881
query39 879 830 829 829
query39_1 787 822 794 794
query40 253 159 145 145
query41 69 64 66 64
query42 264 261 264 261
query43 246 242 222 222
query44
query45 200 189 186 186
query46 886 991 618 618
query47 2130 2154 2078 2078
query48 315 324 249 249
query49 661 476 404 404
query50 703 294 221 221
query51 4060 4086 4047 4047
query52 268 269 260 260
query53 296 335 285 285
query54 315 281 283 281
query55 100 92 84 84
query56 338 348 338 338
query57 1921 1833 1788 1788
query58 302 279 277 277
query59 2783 2971 2742 2742
query60 357 356 350 350
query61 174 178 177 177
query62 639 601 552 552
query63 314 291 281 281
query64 5111 1277 1004 1004
query65
query66 1474 467 356 356
query67 24203 24243 24170 24170
query68
query69 418 321 286 286
query70 996 987 940 940
query71 340 310 286 286
query72 2827 2684 2168 2168
query73 550 542 321 321
query74 9653 9545 9412 9412
query75 2872 2734 2437 2437
query76 2363 1029 665 665
query77 360 387 304 304
query78 11027 11163 10505 10505
query79 1092 828 568 568
query80 1354 616 557 557
query81 533 266 230 230
query82 1370 161 120 120
query83 356 262 244 244
query84 331 122 95 95
query85 984 490 469 469
query86 403 307 298 298
query87 3176 3101 2997 2997
query88 3582 2679 2685 2679
query89 422 369 344 344
query90 1807 180 177 177
query91 172 174 138 138
query92 79 73 69 69
query93 907 860 508 508
query94 522 308 291 291
query95 596 350 318 318
query96 646 533 230 230
query97 2470 2519 2386 2386
query98 241 246 224 224
query99 1025 992 919 919
Total cold run time: 249645 ms
Total hot run time: 167912 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](storage) avoid duplicate exported compaction metrics [doris]
Posted by "CSoulode (via GitHub)" <gi...@apache.org>.
CSoulode commented on PR #61420:
URL: https://github.com/apache/doris/pull/61420#issuecomment-4181725302
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](storage) avoid duplicate exported compaction metrics [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #61420:
URL: https://github.com/apache/doris/pull/61420#issuecomment-4182210525
# BE Regression && UT Coverage Report
Increment line coverage `100% (0/0)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/61420_329382bc53c69a06467ad1958c056695036706ec_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/61420_329382bc53c69a06467ad1958c056695036706ec_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 71.84% (26663/37114) |
| Line Coverage | 54.78% (281764/514367) |
| Region Coverage | 51.91% (233873/450527) |
| Branch Coverage | 53.30% (100957/189422) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](storage) avoid duplicate exported compaction metrics [doris]
Posted by "CSoulode (via GitHub)" <gi...@apache.org>.
CSoulode commented on code in PR #61420:
URL: https://github.com/apache/doris/pull/61420#discussion_r3031322926
##########
be/src/common/metrics/doris_metrics.cpp:
##########
@@ -103,15 +103,17 @@ DEFINE_COUNTER_METRIC_PROTOTYPE_5ARG(full_compaction_bytes_total, MetricUnit::BY
compaction_bytes_total, Labels({{"type", "full"}}));
DEFINE_COUNTER_METRIC_PROTOTYPE_5ARG(base_compaction_task_running_total, MetricUnit::ROWSETS, "",
- compaction_task_state_total, Labels({{"type", "base"}}));
+ compaction_task_state_total,
Review Comment:
ut has been added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](storage) avoid duplicate exported compaction metrics [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #61420:
URL: https://github.com/apache/doris/pull/61420#issuecomment-4182152319
<details>
<summary>TPC-DS: <b>Total hot run time: 177695 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 329382bc53c69a06467ad1958c056695036706ec, data reload: false
query5 4335 672 526 526
query6 336 224 218 218
query7 4245 617 352 352
query8 327 242 224 224
query9 8766 3910 3943 3910
query10 457 349 297 297
query11 6730 5525 5120 5120
query12 185 131 126 126
query13 1270 613 397 397
query14 5657 5171 4731 4731
query14_1 4144 4104 4049 4049
query15 209 203 178 178
query16 998 453 468 453
query17 933 741 609 609
query18 2446 480 369 369
query19 228 202 165 165
query20 139 133 136 133
query21 222 146 122 122
query22 13626 13531 13308 13308
query23 17864 17491 16821 16821
query23_1 16782 16809 16851 16809
query24 8062 1906 1433 1433
query24_1 1498 1435 1398 1398
query25 668 548 544 544
query26 1376 339 183 183
query27 2987 655 378 378
query28 4506 1908 1894 1894
query29 975 657 550 550
query30 294 229 190 190
query31 1095 1033 931 931
query32 90 73 68 68
query33 521 329 288 288
query34 1188 1165 668 668
query35 746 753 660 660
query36 1239 1235 1069 1069
query37 153 94 94 94
query38 3117 3021 2969 2969
query39 921 906 853 853
query39_1 850 828 837 828
query40 230 147 131 131
query41 64 60 58 58
query42 109 105 108 105
query43 308 313 269 269
query44
query45 204 195 193 193
query46 1183 1241 805 805
query47 2340 2320 2211 2211
query48 403 429 322 322
query49 627 565 436 436
query50 773 282 220 220
query51 4421 4255 4202 4202
query52 109 108 96 96
query53 244 276 201 201
query54 315 274 261 261
query55 97 93 87 87
query56 294 312 301 301
query57 1746 1671 1608 1608
query58 297 281 273 273
query59 2915 2991 2739 2739
query60 334 339 324 324
query61 156 153 157 153
query62 704 618 562 562
query63 243 197 193 193
query64 5404 1307 1004 1004
query65
query66 1503 496 375 375
query67 24386 24295 24284 24284
query68
query69 431 343 304 304
query70 986 1038 979 979
query71 316 275 276 275
query72 2976 2738 2697 2697
query73 831 790 461 461
query74 9893 9761 9514 9514
query75 2739 2615 2314 2314
query76 2358 1099 719 719
query77 394 415 327 327
query78 11363 11282 10769 10769
query79 1548 1019 859 859
query80 961 565 488 488
query81 501 280 236 236
query82 1377 160 132 132
query83 395 291 257 257
query84 328 149 117 117
query85 942 523 455 455
query86 432 334 318 318
query87 3307 3223 3086 3086
query88 3636 2754 2750 2750
query89 445 388 351 351
query90 1874 180 191 180
query91 177 166 142 142
query92 75 78 69 69
query93 968 967 557 557
query94 607 320 285 285
query95 626 455 335 335
query96 1041 805 338 338
query97 2666 2656 2559 2559
query98 244 235 223 223
query99 1058 1074 958 958
Total cold run time: 258206 ms
Total hot run time: 177695 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](storage) avoid duplicate exported compaction metrics [doris]
Posted by "CSoulode (via GitHub)" <gi...@apache.org>.
CSoulode commented on PR #61420:
URL: https://github.com/apache/doris/pull/61420#issuecomment-4073308989
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](storage) avoid duplicate exported compaction metrics [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #61420:
URL: https://github.com/apache/doris/pull/61420#issuecomment-4073594128
<details>
<summary>TPC-H: <b>Total hot run time: 26810 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 36233087b6e50345100ff50f22badfb463bd0ac5, data reload: false
------ Round 1 ----------------------------------
orders Doris NULL NULL 0 0 0 NULL 0 NULL NULL 2023-12-26 18:27:23 2023-12-26 18:42:55 NULL utf-8 NULL NULL
============================================
q1 17599 4638 4329 4329
q2 q3 10645 813 524 524
q4 4679 352 250 250
q5 7559 1222 1015 1015
q6 176 177 146 146
q7 783 847 677 677
q8 9302 1428 1307 1307
q9 4786 4706 4656 4656
q10 6251 1890 1662 1662
q11 464 263 258 258
q12 701 590 463 463
q13 18054 2939 2164 2164
q14 233 232 214 214
q15 q16 725 741 669 669
q17 730 840 433 433
q18 5993 5380 5316 5316
q19 1104 997 603 603
q20 529 494 381 381
q21 4375 1842 1409 1409
q22 334 470 334 334
Total cold run time: 95022 ms
Total hot run time: 26810 ms
----- Round 2, with runtime_filter_mode=off -----
orders Doris NULL NULL 150000000 42 6422171781 NULL 22778155 NULL NULL 2023-12-26 18:27:23 2023-12-26 18:42:55 NULL utf-8 NULL NULL
============================================
q1 4868 4662 4543 4543
q2 q3 3860 4341 3843 3843
q4 876 1199 781 781
q5 4098 4383 4345 4345
q6 186 175 138 138
q7 1761 1649 1551 1551
q8 2475 2707 2628 2628
q9 7613 7395 7396 7395
q10 3812 4063 3667 3667
q11 509 423 421 421
q12 495 595 456 456
q13 2736 3283 2343 2343
q14 277 307 273 273
q15 q16 737 758 706 706
q17 1149 1292 1324 1292
q18 7291 6803 6750 6750
q19 983 928 878 878
q20 2127 2165 1979 1979
q21 4100 3499 3321 3321
q22 481 426 400 400
Total cold run time: 50434 ms
Total hot run time: 47710 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](storage) avoid duplicate exported compaction metrics [doris]
Posted by "CSoulode (via GitHub)" <gi...@apache.org>.
CSoulode commented on PR #61420:
URL: https://github.com/apache/doris/pull/61420#issuecomment-4072898397
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](storage) avoid duplicate exported compaction metrics [doris]
Posted by "CSoulode (via GitHub)" <gi...@apache.org>.
CSoulode commented on code in PR #61420:
URL: https://github.com/apache/doris/pull/61420#discussion_r3031322413
##########
be/src/common/metrics/doris_metrics.cpp:
##########
@@ -103,15 +103,17 @@ DEFINE_COUNTER_METRIC_PROTOTYPE_5ARG(full_compaction_bytes_total, MetricUnit::BY
compaction_bytes_total, Labels({{"type", "full"}}));
DEFINE_COUNTER_METRIC_PROTOTYPE_5ARG(base_compaction_task_running_total, MetricUnit::ROWSETS, "",
- compaction_task_state_total, Labels({{"type", "base"}}));
+ compaction_task_state_total,
Review Comment:
ut has been added
##########
be/src/common/metrics/doris_metrics.cpp:
##########
@@ -103,15 +103,17 @@ DEFINE_COUNTER_METRIC_PROTOTYPE_5ARG(full_compaction_bytes_total, MetricUnit::BY
compaction_bytes_total, Labels({{"type", "full"}}));
DEFINE_COUNTER_METRIC_PROTOTYPE_5ARG(base_compaction_task_running_total, MetricUnit::ROWSETS, "",
- compaction_task_state_total, Labels({{"type", "base"}}));
+ compaction_task_state_total,
Review Comment:
ut has been added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](storage) avoid duplicate exported compaction metrics [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #61420:
URL: https://github.com/apache/doris/pull/61420#issuecomment-4182119606
<details>
<summary>TPC-H: <b>Total hot run time: 29069 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 329382bc53c69a06467ad1958c056695036706ec, data reload: false
------ Round 1 ----------------------------------
orders Doris NULL NULL 0 0 0 NULL 0 NULL NULL 2023-12-26 18:27:23 2023-12-26 18:42:55 NULL utf-8 NULL NULL
============================================
q1 17778 3899 3803 3803
q2 q3 10680 877 606 606
q4 4682 464 365 365
q5 7470 1334 1143 1143
q6 194 175 145 145
q7 915 947 796 796
q8 9324 1388 1309 1309
q9 5478 5328 5305 5305
q10 6258 2024 1758 1758
q11 475 276 288 276
q12 631 408 284 284
q13 18062 2775 2159 2159
q14 287 282 263 263
q15 q16 852 866 784 784
q17 1009 1172 696 696
q18 6394 5652 5575 5575
q19 1173 1256 974 974
q20 563 436 293 293
q21 3956 2588 2141 2141
q22 490 441 394 394
Total cold run time: 96671 ms
Total hot run time: 29069 ms
----- Round 2, with runtime_filter_mode=off -----
orders Doris NULL NULL 150000000 42 6422171781 NULL 22778155 NULL NULL 2023-12-26 18:27:23 2023-12-26 18:42:55 NULL utf-8 NULL NULL
============================================
q1 4760 4598 4889 4598
q2 q3 4587 4768 4174 4174
q4 2110 2187 1321 1321
q5 4857 5005 5164 5005
q6 219 188 142 142
q7 2028 1757 1658 1658
q8 3239 3131 3029 3029
q9 8178 8216 8213 8213
q10 4672 4629 4380 4380
q11 599 450 428 428
q12 671 706 486 486
q13 2663 2997 2373 2373
q14 297 302 266 266
q15 q16 773 799 684 684
q17 1299 1356 1302 1302
q18 8004 7082 6997 6997
q19 1232 1123 1089 1089
q20 2272 2321 1986 1986
q21 6104 5506 4809 4809
q22 607 516 422 422
Total cold run time: 59171 ms
Total hot run time: 53362 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org