You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by shen guoquan <gu...@intel.com> on 2015/03/02 08:58:24 UTC
Review Request 31617: SENTRY-646:Add Sqoop policy engine for sentry
authorization
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31617/
-----------------------------------------------------------
Review request for sentry.
Repository: sentry
Description
-------
Add Sqoop policy engine in Sentry for Sqoop role-based authorizaiton
Diffs
-----
pom.xml 4c80916
sentry-dist/pom.xml f63b33b
sentry-policy/pom.xml 4fb4f3c
sentry-policy/sentry-policy-sqoop/pom.xml PRE-CREATION
sentry-policy/sentry-policy-sqoop/src/main/java/org/apache/sentry/policy/sqoop/ServerNameRequiredMatch.java PRE-CREATION
sentry-policy/sentry-policy-sqoop/src/main/java/org/apache/sentry/policy/sqoop/SimpleSqoopPolicyEngine.java PRE-CREATION
sentry-policy/sentry-policy-sqoop/src/main/java/org/apache/sentry/policy/sqoop/SqoopModelAuthorizables.java PRE-CREATION
sentry-policy/sentry-policy-sqoop/src/main/java/org/apache/sentry/policy/sqoop/SqoopWildcardPrivilege.java PRE-CREATION
sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/AbstractTestSqoopPolicyEngine.java PRE-CREATION
sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/SqoopPolicyFileProviderBackend.java PRE-CREATION
sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestServerNameRequiredMatch.java PRE-CREATION
sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopAuthorizationProviderGeneralCases.java PRE-CREATION
sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopAuthorizationProviderSpecialCases.java PRE-CREATION
sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopModelAuthorizables.java PRE-CREATION
sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopPolicyEngineDFS.java PRE-CREATION
sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopPolicyEngineLocalFS.java PRE-CREATION
sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopWildcardPrivilege.java PRE-CREATION
sentry-policy/sentry-policy-sqoop/src/test/resources/log4j.properties PRE-CREATION
sentry-policy/sentry-policy-sqoop/src/test/resources/test-authz-provider.ini PRE-CREATION
Diff: https://reviews.apache.org/r/31617/diff/
Testing
-------
Ran the unit tests.
Thanks,
shen guoquan
Re: Review Request 31617: SENTRY-646:Add Sqoop policy engine for
sentry authorization
Posted by shen guoquan <gu...@intel.com>.
> On 三月 21, 2015, 4:58 p.m., Prasad Mujumdar wrote:
> > sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/SqoopPolicyFileProviderBackend.java, line 28
> > <https://reviews.apache.org/r/31617/diff/2/?file=898537#file898537line28>
> >
> > I think we should add a warning that db provider is the preferred option over file.
Ok, I will add a warning
- shen
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31617/#review77334
-----------------------------------------------------------
On 三月 18, 2015, 2:02 a.m., shen guoquan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31617/
> -----------------------------------------------------------
>
> (Updated 三月 18, 2015, 2:02 a.m.)
>
>
> Review request for sentry, Sqoop, Abraham Elmahrek, Xiaomeng Huang, Colin Ma, Dapeng Sun, and Prasad Mujumdar.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Add Sqoop policy engine in Sentry for Sqoop role-based authorizaiton
>
>
> Diffs
> -----
>
> pom.xml 4c80916
> sentry-dist/pom.xml f63b33b
> sentry-policy/pom.xml 4fb4f3c
> sentry-policy/sentry-policy-sqoop/pom.xml PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/main/java/org/apache/sentry/policy/sqoop/ServerNameRequiredMatch.java PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/main/java/org/apache/sentry/policy/sqoop/SimpleSqoopPolicyEngine.java PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/main/java/org/apache/sentry/policy/sqoop/SqoopModelAuthorizables.java PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/main/java/org/apache/sentry/policy/sqoop/SqoopWildcardPrivilege.java PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/AbstractTestSqoopPolicyEngine.java PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/SqoopPolicyFileProviderBackend.java PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestServerNameRequiredMatch.java PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopAuthorizationProviderGeneralCases.java PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopAuthorizationProviderSpecialCases.java PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopModelAuthorizables.java PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopPolicyEngineDFS.java PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopPolicyEngineLocalFS.java PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopWildcardPrivilege.java PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/test/resources/log4j.properties PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/test/resources/test-authz-provider.ini PRE-CREATION
>
> Diff: https://reviews.apache.org/r/31617/diff/
>
>
> Testing
> -------
>
> Ran the unit tests.
>
>
> Thanks,
>
> shen guoquan
>
>
Re: Review Request 31617: SENTRY-646:Add Sqoop policy engine for
sentry authorization
Posted by shen guoquan <gu...@intel.com>.
> On 三月 21, 2015, 4:58 p.m., Prasad Mujumdar wrote:
> > sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/SqoopPolicyFileProviderBackend.java, line 28
> > <https://reviews.apache.org/r/31617/diff/2/?file=898537#file898537line28>
> >
> > I think we should add a warning that db provider is the preferred option over file.
Ok, I will add a warning
- shen
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31617/#review77334
-----------------------------------------------------------
On 三月 18, 2015, 2:02 a.m., shen guoquan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31617/
> -----------------------------------------------------------
>
> (Updated 三月 18, 2015, 2:02 a.m.)
>
>
> Review request for sentry, Sqoop, Abraham Elmahrek, Xiaomeng Huang, Colin Ma, Dapeng Sun, and Prasad Mujumdar.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Add Sqoop policy engine in Sentry for Sqoop role-based authorizaiton
>
>
> Diffs
> -----
>
> pom.xml 4c80916
> sentry-dist/pom.xml f63b33b
> sentry-policy/pom.xml 4fb4f3c
> sentry-policy/sentry-policy-sqoop/pom.xml PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/main/java/org/apache/sentry/policy/sqoop/ServerNameRequiredMatch.java PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/main/java/org/apache/sentry/policy/sqoop/SimpleSqoopPolicyEngine.java PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/main/java/org/apache/sentry/policy/sqoop/SqoopModelAuthorizables.java PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/main/java/org/apache/sentry/policy/sqoop/SqoopWildcardPrivilege.java PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/AbstractTestSqoopPolicyEngine.java PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/SqoopPolicyFileProviderBackend.java PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestServerNameRequiredMatch.java PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopAuthorizationProviderGeneralCases.java PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopAuthorizationProviderSpecialCases.java PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopModelAuthorizables.java PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopPolicyEngineDFS.java PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopPolicyEngineLocalFS.java PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopWildcardPrivilege.java PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/test/resources/log4j.properties PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/test/resources/test-authz-provider.ini PRE-CREATION
>
> Diff: https://reviews.apache.org/r/31617/diff/
>
>
> Testing
> -------
>
> Ran the unit tests.
>
>
> Thanks,
>
> shen guoquan
>
>
Re: Review Request 31617: SENTRY-646:Add Sqoop policy engine for
sentry authorization
Posted by shen guoquan <gu...@intel.com>.
> On 三月 21, 2015, 4:58 p.m., Prasad Mujumdar wrote:
> > sentry-policy/sentry-policy-sqoop/pom.xml, line 83
> > <https://reviews.apache.org/r/31617/diff/2/?file=898531#file898531line83>
> >
> > Nit: Do we need to specify version here ?
hi prasad. You are right. It isn't required. I will fix it. Thanks for your suggest.
> On 三月 21, 2015, 4:58 p.m., Prasad Mujumdar wrote:
> > sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestServerNameRequiredMatch.java, line 44
> > <https://reviews.apache.org/r/31617/diff/2/?file=898538#file898538line44>
> >
> > It should check that the exception is actually authorization exception so that other unexpected errors won't go unnoticed.
I agree with your comment. I will fix it.
> On 三月 21, 2015, 4:58 p.m., Prasad Mujumdar wrote:
> > sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopAuthorizationProviderGeneralCases.java, lines 83-85
> > <https://reviews.apache.org/r/31617/diff/2/?file=898539#file898539line83>
> >
> > Nit: It would be nice if these are defined as constants.
Ok, I will fix it. Thanks
> On 三月 21, 2015, 4:58 p.m., Prasad Mujumdar wrote:
> > sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopAuthorizationProviderGeneralCases.java, line 91
> > <https://reviews.apache.org/r/31617/diff/2/?file=898539#file898539line91>
> >
> > It would be good add some negative scenarios for analyst and developer roles.
Ok, Thanks for your comment. I will fix it.
> On 三月 21, 2015, 4:58 p.m., Prasad Mujumdar wrote:
> > sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopPolicyEngineDFS.java, line 34
> > <https://reviews.apache.org/r/31617/diff/2/?file=898542#file898542line34>
> >
> > Do we need this to be a new class in sqoop package ? If this is direct copy/paste from other modules, would be it be possible to move these common helper classes to a new test-common module ?
I will have a try about your advice. Thanks
- shen
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31617/#review77334
-----------------------------------------------------------
On 三月 18, 2015, 2:02 a.m., shen guoquan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31617/
> -----------------------------------------------------------
>
> (Updated 三月 18, 2015, 2:02 a.m.)
>
>
> Review request for sentry, Sqoop, Abraham Elmahrek, Xiaomeng Huang, Colin Ma, Dapeng Sun, and Prasad Mujumdar.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Add Sqoop policy engine in Sentry for Sqoop role-based authorizaiton
>
>
> Diffs
> -----
>
> pom.xml 4c80916
> sentry-dist/pom.xml f63b33b
> sentry-policy/pom.xml 4fb4f3c
> sentry-policy/sentry-policy-sqoop/pom.xml PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/main/java/org/apache/sentry/policy/sqoop/ServerNameRequiredMatch.java PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/main/java/org/apache/sentry/policy/sqoop/SimpleSqoopPolicyEngine.java PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/main/java/org/apache/sentry/policy/sqoop/SqoopModelAuthorizables.java PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/main/java/org/apache/sentry/policy/sqoop/SqoopWildcardPrivilege.java PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/AbstractTestSqoopPolicyEngine.java PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/SqoopPolicyFileProviderBackend.java PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestServerNameRequiredMatch.java PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopAuthorizationProviderGeneralCases.java PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopAuthorizationProviderSpecialCases.java PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopModelAuthorizables.java PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopPolicyEngineDFS.java PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopPolicyEngineLocalFS.java PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopWildcardPrivilege.java PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/test/resources/log4j.properties PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/test/resources/test-authz-provider.ini PRE-CREATION
>
> Diff: https://reviews.apache.org/r/31617/diff/
>
>
> Testing
> -------
>
> Ran the unit tests.
>
>
> Thanks,
>
> shen guoquan
>
>
Re: Review Request 31617: SENTRY-646:Add Sqoop policy engine for
sentry authorization
Posted by shen guoquan <gu...@intel.com>.
> On 三月 21, 2015, 4:58 p.m., Prasad Mujumdar wrote:
> > sentry-policy/sentry-policy-sqoop/pom.xml, line 83
> > <https://reviews.apache.org/r/31617/diff/2/?file=898531#file898531line83>
> >
> > Nit: Do we need to specify version here ?
hi prasad. You are right. It isn't required. I will fix it. Thanks for your suggest.
> On 三月 21, 2015, 4:58 p.m., Prasad Mujumdar wrote:
> > sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestServerNameRequiredMatch.java, line 44
> > <https://reviews.apache.org/r/31617/diff/2/?file=898538#file898538line44>
> >
> > It should check that the exception is actually authorization exception so that other unexpected errors won't go unnoticed.
I agree with your comment. I will fix it.
> On 三月 21, 2015, 4:58 p.m., Prasad Mujumdar wrote:
> > sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopAuthorizationProviderGeneralCases.java, lines 83-85
> > <https://reviews.apache.org/r/31617/diff/2/?file=898539#file898539line83>
> >
> > Nit: It would be nice if these are defined as constants.
Ok, I will fix it. Thanks
> On 三月 21, 2015, 4:58 p.m., Prasad Mujumdar wrote:
> > sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopAuthorizationProviderGeneralCases.java, line 91
> > <https://reviews.apache.org/r/31617/diff/2/?file=898539#file898539line91>
> >
> > It would be good add some negative scenarios for analyst and developer roles.
Ok, Thanks for your comment. I will fix it.
> On 三月 21, 2015, 4:58 p.m., Prasad Mujumdar wrote:
> > sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopPolicyEngineDFS.java, line 34
> > <https://reviews.apache.org/r/31617/diff/2/?file=898542#file898542line34>
> >
> > Do we need this to be a new class in sqoop package ? If this is direct copy/paste from other modules, would be it be possible to move these common helper classes to a new test-common module ?
I will have a try about your advice. Thanks
- shen
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31617/#review77334
-----------------------------------------------------------
On 三月 18, 2015, 2:02 a.m., shen guoquan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31617/
> -----------------------------------------------------------
>
> (Updated 三月 18, 2015, 2:02 a.m.)
>
>
> Review request for sentry, Sqoop, Abraham Elmahrek, Xiaomeng Huang, Colin Ma, Dapeng Sun, and Prasad Mujumdar.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Add Sqoop policy engine in Sentry for Sqoop role-based authorizaiton
>
>
> Diffs
> -----
>
> pom.xml 4c80916
> sentry-dist/pom.xml f63b33b
> sentry-policy/pom.xml 4fb4f3c
> sentry-policy/sentry-policy-sqoop/pom.xml PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/main/java/org/apache/sentry/policy/sqoop/ServerNameRequiredMatch.java PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/main/java/org/apache/sentry/policy/sqoop/SimpleSqoopPolicyEngine.java PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/main/java/org/apache/sentry/policy/sqoop/SqoopModelAuthorizables.java PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/main/java/org/apache/sentry/policy/sqoop/SqoopWildcardPrivilege.java PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/AbstractTestSqoopPolicyEngine.java PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/SqoopPolicyFileProviderBackend.java PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestServerNameRequiredMatch.java PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopAuthorizationProviderGeneralCases.java PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopAuthorizationProviderSpecialCases.java PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopModelAuthorizables.java PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopPolicyEngineDFS.java PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopPolicyEngineLocalFS.java PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopWildcardPrivilege.java PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/test/resources/log4j.properties PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/test/resources/test-authz-provider.ini PRE-CREATION
>
> Diff: https://reviews.apache.org/r/31617/diff/
>
>
> Testing
> -------
>
> Ran the unit tests.
>
>
> Thanks,
>
> shen guoquan
>
>
Re: Review Request 31617: SENTRY-646:Add Sqoop policy engine for
sentry authorization
Posted by Prasad Mujumdar <pr...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31617/#review77334
-----------------------------------------------------------
Looks fine overall. A few comments/suggestions below.
sentry-policy/sentry-policy-sqoop/pom.xml
<https://reviews.apache.org/r/31617/#comment125245>
Nit: Do we need to specify version here ?
sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/SqoopPolicyFileProviderBackend.java
<https://reviews.apache.org/r/31617/#comment125249>
I think we should add a warning that db provider is the preferred option over file.
sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestServerNameRequiredMatch.java
<https://reviews.apache.org/r/31617/#comment125250>
It should check that the exception is actually authorization exception so that other unexpected errors won't go unnoticed.
sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopAuthorizationProviderGeneralCases.java
<https://reviews.apache.org/r/31617/#comment125248>
Nit: It would be nice if these are defined as constants.
sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopAuthorizationProviderGeneralCases.java
<https://reviews.apache.org/r/31617/#comment125251>
It would be good add some negative scenarios for analyst and developer roles.
sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopPolicyEngineDFS.java
<https://reviews.apache.org/r/31617/#comment125252>
Do we need this to be a new class in sqoop package ? If this is direct copy/paste from other modules, would be it be possible to move these common helper classes to a new test-common module ?
- Prasad Mujumdar
On March 18, 2015, 2:02 a.m., shen guoquan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31617/
> -----------------------------------------------------------
>
> (Updated March 18, 2015, 2:02 a.m.)
>
>
> Review request for sentry, Sqoop, Abraham Elmahrek, Xiaomeng Huang, Colin Ma, Dapeng Sun, and Prasad Mujumdar.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Add Sqoop policy engine in Sentry for Sqoop role-based authorizaiton
>
>
> Diffs
> -----
>
> pom.xml 4c80916
> sentry-dist/pom.xml f63b33b
> sentry-policy/pom.xml 4fb4f3c
> sentry-policy/sentry-policy-sqoop/pom.xml PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/main/java/org/apache/sentry/policy/sqoop/ServerNameRequiredMatch.java PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/main/java/org/apache/sentry/policy/sqoop/SimpleSqoopPolicyEngine.java PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/main/java/org/apache/sentry/policy/sqoop/SqoopModelAuthorizables.java PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/main/java/org/apache/sentry/policy/sqoop/SqoopWildcardPrivilege.java PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/AbstractTestSqoopPolicyEngine.java PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/SqoopPolicyFileProviderBackend.java PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestServerNameRequiredMatch.java PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopAuthorizationProviderGeneralCases.java PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopAuthorizationProviderSpecialCases.java PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopModelAuthorizables.java PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopPolicyEngineDFS.java PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopPolicyEngineLocalFS.java PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopWildcardPrivilege.java PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/test/resources/log4j.properties PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/test/resources/test-authz-provider.ini PRE-CREATION
>
> Diff: https://reviews.apache.org/r/31617/diff/
>
>
> Testing
> -------
>
> Ran the unit tests.
>
>
> Thanks,
>
> shen guoquan
>
>
Re: Review Request 31617: SENTRY-646:Add Sqoop policy engine for
sentry authorization
Posted by Prasad Mujumdar <pr...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31617/#review77334
-----------------------------------------------------------
Looks fine overall. A few comments/suggestions below.
sentry-policy/sentry-policy-sqoop/pom.xml
<https://reviews.apache.org/r/31617/#comment125245>
Nit: Do we need to specify version here ?
sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/SqoopPolicyFileProviderBackend.java
<https://reviews.apache.org/r/31617/#comment125249>
I think we should add a warning that db provider is the preferred option over file.
sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestServerNameRequiredMatch.java
<https://reviews.apache.org/r/31617/#comment125250>
It should check that the exception is actually authorization exception so that other unexpected errors won't go unnoticed.
sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopAuthorizationProviderGeneralCases.java
<https://reviews.apache.org/r/31617/#comment125248>
Nit: It would be nice if these are defined as constants.
sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopAuthorizationProviderGeneralCases.java
<https://reviews.apache.org/r/31617/#comment125251>
It would be good add some negative scenarios for analyst and developer roles.
sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopPolicyEngineDFS.java
<https://reviews.apache.org/r/31617/#comment125252>
Do we need this to be a new class in sqoop package ? If this is direct copy/paste from other modules, would be it be possible to move these common helper classes to a new test-common module ?
- Prasad Mujumdar
On March 18, 2015, 2:02 a.m., shen guoquan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31617/
> -----------------------------------------------------------
>
> (Updated March 18, 2015, 2:02 a.m.)
>
>
> Review request for sentry, Sqoop, Abraham Elmahrek, Xiaomeng Huang, Colin Ma, Dapeng Sun, and Prasad Mujumdar.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Add Sqoop policy engine in Sentry for Sqoop role-based authorizaiton
>
>
> Diffs
> -----
>
> pom.xml 4c80916
> sentry-dist/pom.xml f63b33b
> sentry-policy/pom.xml 4fb4f3c
> sentry-policy/sentry-policy-sqoop/pom.xml PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/main/java/org/apache/sentry/policy/sqoop/ServerNameRequiredMatch.java PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/main/java/org/apache/sentry/policy/sqoop/SimpleSqoopPolicyEngine.java PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/main/java/org/apache/sentry/policy/sqoop/SqoopModelAuthorizables.java PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/main/java/org/apache/sentry/policy/sqoop/SqoopWildcardPrivilege.java PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/AbstractTestSqoopPolicyEngine.java PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/SqoopPolicyFileProviderBackend.java PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestServerNameRequiredMatch.java PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopAuthorizationProviderGeneralCases.java PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopAuthorizationProviderSpecialCases.java PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopModelAuthorizables.java PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopPolicyEngineDFS.java PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopPolicyEngineLocalFS.java PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopWildcardPrivilege.java PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/test/resources/log4j.properties PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/test/resources/test-authz-provider.ini PRE-CREATION
>
> Diff: https://reviews.apache.org/r/31617/diff/
>
>
> Testing
> -------
>
> Ran the unit tests.
>
>
> Thanks,
>
> shen guoquan
>
>
Re: Review Request 31617: SENTRY-646:Add Sqoop policy engine for
sentry authorization
Posted by Prasad Mujumdar <pr...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31617/#review78459
-----------------------------------------------------------
Ship it!
- Prasad Mujumdar
On March 26, 2015, 6:43 a.m., shen guoquan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31617/
> -----------------------------------------------------------
>
> (Updated March 26, 2015, 6:43 a.m.)
>
>
> Review request for sentry, Sqoop, Abraham Elmahrek, Xiaomeng Huang, Colin Ma, Dapeng Sun, and Prasad Mujumdar.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Add Sqoop policy engine in Sentry for Sqoop role-based authorizaiton
>
>
> Diffs
> -----
>
> pom.xml 2f97880
> sentry-dist/pom.xml f7a663b
> sentry-policy/pom.xml 4fb4f3c
> sentry-policy/sentry-policy-sqoop/pom.xml PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/main/java/org/apache/sentry/policy/sqoop/ServerNameRequiredMatch.java PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/main/java/org/apache/sentry/policy/sqoop/SimpleSqoopPolicyEngine.java PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/main/java/org/apache/sentry/policy/sqoop/SqoopModelAuthorizables.java PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/main/java/org/apache/sentry/policy/sqoop/SqoopWildcardPrivilege.java PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/AbstractTestSqoopPolicyEngine.java PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/MockGroupMappingServiceProvider.java PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/SqoopPolicyFileProviderBackend.java PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestServerNameRequiredMatch.java PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopAuthorizationProviderGeneralCases.java PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopAuthorizationProviderSpecialCases.java PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopModelAuthorizables.java PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopPolicyEngineDFS.java PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopPolicyEngineLocalFS.java PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopPolicyNegative.java PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopWildcardPrivilege.java PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/test/resources/log4j.properties PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/test/resources/test-authz-provider.ini PRE-CREATION
>
> Diff: https://reviews.apache.org/r/31617/diff/
>
>
> Testing
> -------
>
> Ran the unit tests.
>
>
> Thanks,
>
> shen guoquan
>
>
Re: Review Request 31617: SENTRY-646:Add Sqoop policy engine for
sentry authorization
Posted by Prasad Mujumdar <pr...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31617/#review78459
-----------------------------------------------------------
Ship it!
- Prasad Mujumdar
On March 26, 2015, 6:43 a.m., shen guoquan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31617/
> -----------------------------------------------------------
>
> (Updated March 26, 2015, 6:43 a.m.)
>
>
> Review request for sentry, Sqoop, Abraham Elmahrek, Xiaomeng Huang, Colin Ma, Dapeng Sun, and Prasad Mujumdar.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Add Sqoop policy engine in Sentry for Sqoop role-based authorizaiton
>
>
> Diffs
> -----
>
> pom.xml 2f97880
> sentry-dist/pom.xml f7a663b
> sentry-policy/pom.xml 4fb4f3c
> sentry-policy/sentry-policy-sqoop/pom.xml PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/main/java/org/apache/sentry/policy/sqoop/ServerNameRequiredMatch.java PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/main/java/org/apache/sentry/policy/sqoop/SimpleSqoopPolicyEngine.java PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/main/java/org/apache/sentry/policy/sqoop/SqoopModelAuthorizables.java PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/main/java/org/apache/sentry/policy/sqoop/SqoopWildcardPrivilege.java PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/AbstractTestSqoopPolicyEngine.java PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/MockGroupMappingServiceProvider.java PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/SqoopPolicyFileProviderBackend.java PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestServerNameRequiredMatch.java PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopAuthorizationProviderGeneralCases.java PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopAuthorizationProviderSpecialCases.java PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopModelAuthorizables.java PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopPolicyEngineDFS.java PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopPolicyEngineLocalFS.java PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopPolicyNegative.java PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopWildcardPrivilege.java PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/test/resources/log4j.properties PRE-CREATION
> sentry-policy/sentry-policy-sqoop/src/test/resources/test-authz-provider.ini PRE-CREATION
>
> Diff: https://reviews.apache.org/r/31617/diff/
>
>
> Testing
> -------
>
> Ran the unit tests.
>
>
> Thanks,
>
> shen guoquan
>
>
Re: Review Request 31617: SENTRY-646:Add Sqoop policy engine for
sentry authorization
Posted by shen guoquan <gu...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31617/
-----------------------------------------------------------
(Updated 三月 26, 2015, 6:43 a.m.)
Review request for sentry, Sqoop, Abraham Elmahrek, Xiaomeng Huang, Colin Ma, Dapeng Sun, and Prasad Mujumdar.
Repository: sentry
Description
-------
Add Sqoop policy engine in Sentry for Sqoop role-based authorizaiton
Diffs (updated)
-----
pom.xml 2f97880
sentry-dist/pom.xml f7a663b
sentry-policy/pom.xml 4fb4f3c
sentry-policy/sentry-policy-sqoop/pom.xml PRE-CREATION
sentry-policy/sentry-policy-sqoop/src/main/java/org/apache/sentry/policy/sqoop/ServerNameRequiredMatch.java PRE-CREATION
sentry-policy/sentry-policy-sqoop/src/main/java/org/apache/sentry/policy/sqoop/SimpleSqoopPolicyEngine.java PRE-CREATION
sentry-policy/sentry-policy-sqoop/src/main/java/org/apache/sentry/policy/sqoop/SqoopModelAuthorizables.java PRE-CREATION
sentry-policy/sentry-policy-sqoop/src/main/java/org/apache/sentry/policy/sqoop/SqoopWildcardPrivilege.java PRE-CREATION
sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/AbstractTestSqoopPolicyEngine.java PRE-CREATION
sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/MockGroupMappingServiceProvider.java PRE-CREATION
sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/SqoopPolicyFileProviderBackend.java PRE-CREATION
sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestServerNameRequiredMatch.java PRE-CREATION
sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopAuthorizationProviderGeneralCases.java PRE-CREATION
sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopAuthorizationProviderSpecialCases.java PRE-CREATION
sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopModelAuthorizables.java PRE-CREATION
sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopPolicyEngineDFS.java PRE-CREATION
sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopPolicyEngineLocalFS.java PRE-CREATION
sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopPolicyNegative.java PRE-CREATION
sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopWildcardPrivilege.java PRE-CREATION
sentry-policy/sentry-policy-sqoop/src/test/resources/log4j.properties PRE-CREATION
sentry-policy/sentry-policy-sqoop/src/test/resources/test-authz-provider.ini PRE-CREATION
Diff: https://reviews.apache.org/r/31617/diff/
Testing
-------
Ran the unit tests.
Thanks,
shen guoquan
Re: Review Request 31617: SENTRY-646:Add Sqoop policy engine for
sentry authorization
Posted by shen guoquan <gu...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31617/
-----------------------------------------------------------
(Updated 三月 26, 2015, 6:43 a.m.)
Review request for sentry, Sqoop, Abraham Elmahrek, Xiaomeng Huang, Colin Ma, Dapeng Sun, and Prasad Mujumdar.
Repository: sentry
Description
-------
Add Sqoop policy engine in Sentry for Sqoop role-based authorizaiton
Diffs (updated)
-----
pom.xml 2f97880
sentry-dist/pom.xml f7a663b
sentry-policy/pom.xml 4fb4f3c
sentry-policy/sentry-policy-sqoop/pom.xml PRE-CREATION
sentry-policy/sentry-policy-sqoop/src/main/java/org/apache/sentry/policy/sqoop/ServerNameRequiredMatch.java PRE-CREATION
sentry-policy/sentry-policy-sqoop/src/main/java/org/apache/sentry/policy/sqoop/SimpleSqoopPolicyEngine.java PRE-CREATION
sentry-policy/sentry-policy-sqoop/src/main/java/org/apache/sentry/policy/sqoop/SqoopModelAuthorizables.java PRE-CREATION
sentry-policy/sentry-policy-sqoop/src/main/java/org/apache/sentry/policy/sqoop/SqoopWildcardPrivilege.java PRE-CREATION
sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/AbstractTestSqoopPolicyEngine.java PRE-CREATION
sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/MockGroupMappingServiceProvider.java PRE-CREATION
sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/SqoopPolicyFileProviderBackend.java PRE-CREATION
sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestServerNameRequiredMatch.java PRE-CREATION
sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopAuthorizationProviderGeneralCases.java PRE-CREATION
sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopAuthorizationProviderSpecialCases.java PRE-CREATION
sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopModelAuthorizables.java PRE-CREATION
sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopPolicyEngineDFS.java PRE-CREATION
sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopPolicyEngineLocalFS.java PRE-CREATION
sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopPolicyNegative.java PRE-CREATION
sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopWildcardPrivilege.java PRE-CREATION
sentry-policy/sentry-policy-sqoop/src/test/resources/log4j.properties PRE-CREATION
sentry-policy/sentry-policy-sqoop/src/test/resources/test-authz-provider.ini PRE-CREATION
Diff: https://reviews.apache.org/r/31617/diff/
Testing
-------
Ran the unit tests.
Thanks,
shen guoquan
Re: Review Request 31617: SENTRY-646:Add Sqoop policy engine for
sentry authorization
Posted by shen guoquan <gu...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31617/
-----------------------------------------------------------
(Updated 三月 18, 2015, 2:02 a.m.)
Review request for sentry, Sqoop, Abraham Elmahrek, Xiaomeng Huang, Colin Ma, Dapeng Sun, and Prasad Mujumdar.
Repository: sentry
Description
-------
Add Sqoop policy engine in Sentry for Sqoop role-based authorizaiton
Diffs (updated)
-----
pom.xml 4c80916
sentry-dist/pom.xml f63b33b
sentry-policy/pom.xml 4fb4f3c
sentry-policy/sentry-policy-sqoop/pom.xml PRE-CREATION
sentry-policy/sentry-policy-sqoop/src/main/java/org/apache/sentry/policy/sqoop/ServerNameRequiredMatch.java PRE-CREATION
sentry-policy/sentry-policy-sqoop/src/main/java/org/apache/sentry/policy/sqoop/SimpleSqoopPolicyEngine.java PRE-CREATION
sentry-policy/sentry-policy-sqoop/src/main/java/org/apache/sentry/policy/sqoop/SqoopModelAuthorizables.java PRE-CREATION
sentry-policy/sentry-policy-sqoop/src/main/java/org/apache/sentry/policy/sqoop/SqoopWildcardPrivilege.java PRE-CREATION
sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/AbstractTestSqoopPolicyEngine.java PRE-CREATION
sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/SqoopPolicyFileProviderBackend.java PRE-CREATION
sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestServerNameRequiredMatch.java PRE-CREATION
sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopAuthorizationProviderGeneralCases.java PRE-CREATION
sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopAuthorizationProviderSpecialCases.java PRE-CREATION
sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopModelAuthorizables.java PRE-CREATION
sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopPolicyEngineDFS.java PRE-CREATION
sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopPolicyEngineLocalFS.java PRE-CREATION
sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopWildcardPrivilege.java PRE-CREATION
sentry-policy/sentry-policy-sqoop/src/test/resources/log4j.properties PRE-CREATION
sentry-policy/sentry-policy-sqoop/src/test/resources/test-authz-provider.ini PRE-CREATION
Diff: https://reviews.apache.org/r/31617/diff/
Testing
-------
Ran the unit tests.
Thanks,
shen guoquan
Re: Review Request 31617: SENTRY-646:Add Sqoop policy engine for
sentry authorization
Posted by shen guoquan <gu...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31617/
-----------------------------------------------------------
(Updated 三月 18, 2015, 2:02 a.m.)
Review request for sentry, Sqoop, Abraham Elmahrek, Xiaomeng Huang, Colin Ma, Dapeng Sun, and Prasad Mujumdar.
Repository: sentry
Description
-------
Add Sqoop policy engine in Sentry for Sqoop role-based authorizaiton
Diffs (updated)
-----
pom.xml 4c80916
sentry-dist/pom.xml f63b33b
sentry-policy/pom.xml 4fb4f3c
sentry-policy/sentry-policy-sqoop/pom.xml PRE-CREATION
sentry-policy/sentry-policy-sqoop/src/main/java/org/apache/sentry/policy/sqoop/ServerNameRequiredMatch.java PRE-CREATION
sentry-policy/sentry-policy-sqoop/src/main/java/org/apache/sentry/policy/sqoop/SimpleSqoopPolicyEngine.java PRE-CREATION
sentry-policy/sentry-policy-sqoop/src/main/java/org/apache/sentry/policy/sqoop/SqoopModelAuthorizables.java PRE-CREATION
sentry-policy/sentry-policy-sqoop/src/main/java/org/apache/sentry/policy/sqoop/SqoopWildcardPrivilege.java PRE-CREATION
sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/AbstractTestSqoopPolicyEngine.java PRE-CREATION
sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/SqoopPolicyFileProviderBackend.java PRE-CREATION
sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestServerNameRequiredMatch.java PRE-CREATION
sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopAuthorizationProviderGeneralCases.java PRE-CREATION
sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopAuthorizationProviderSpecialCases.java PRE-CREATION
sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopModelAuthorizables.java PRE-CREATION
sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopPolicyEngineDFS.java PRE-CREATION
sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopPolicyEngineLocalFS.java PRE-CREATION
sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopWildcardPrivilege.java PRE-CREATION
sentry-policy/sentry-policy-sqoop/src/test/resources/log4j.properties PRE-CREATION
sentry-policy/sentry-policy-sqoop/src/test/resources/test-authz-provider.ini PRE-CREATION
Diff: https://reviews.apache.org/r/31617/diff/
Testing
-------
Ran the unit tests.
Thanks,
shen guoquan
Re: Review Request 31617: SENTRY-646:Add Sqoop policy engine for
sentry authorization
Posted by shen guoquan <gu...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31617/
-----------------------------------------------------------
(Updated 三月 5, 2015, 2:34 a.m.)
Review request for sentry, Sqoop, Abraham Elmahrek, Xiaomeng Huang, Colin Ma, Dapeng Sun, and Prasad Mujumdar.
Repository: sentry
Description
-------
Add Sqoop policy engine in Sentry for Sqoop role-based authorizaiton
Diffs
-----
pom.xml 4c80916
sentry-dist/pom.xml f63b33b
sentry-policy/pom.xml 4fb4f3c
sentry-policy/sentry-policy-sqoop/pom.xml PRE-CREATION
sentry-policy/sentry-policy-sqoop/src/main/java/org/apache/sentry/policy/sqoop/ServerNameRequiredMatch.java PRE-CREATION
sentry-policy/sentry-policy-sqoop/src/main/java/org/apache/sentry/policy/sqoop/SimpleSqoopPolicyEngine.java PRE-CREATION
sentry-policy/sentry-policy-sqoop/src/main/java/org/apache/sentry/policy/sqoop/SqoopModelAuthorizables.java PRE-CREATION
sentry-policy/sentry-policy-sqoop/src/main/java/org/apache/sentry/policy/sqoop/SqoopWildcardPrivilege.java PRE-CREATION
sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/AbstractTestSqoopPolicyEngine.java PRE-CREATION
sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/SqoopPolicyFileProviderBackend.java PRE-CREATION
sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestServerNameRequiredMatch.java PRE-CREATION
sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopAuthorizationProviderGeneralCases.java PRE-CREATION
sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopAuthorizationProviderSpecialCases.java PRE-CREATION
sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopModelAuthorizables.java PRE-CREATION
sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopPolicyEngineDFS.java PRE-CREATION
sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopPolicyEngineLocalFS.java PRE-CREATION
sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopWildcardPrivilege.java PRE-CREATION
sentry-policy/sentry-policy-sqoop/src/test/resources/log4j.properties PRE-CREATION
sentry-policy/sentry-policy-sqoop/src/test/resources/test-authz-provider.ini PRE-CREATION
Diff: https://reviews.apache.org/r/31617/diff/
Testing
-------
Ran the unit tests.
Thanks,
shen guoquan