You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/04/29 11:28:49 UTC

[GitHub] [shardingsphere] yu199195 opened a new pull request #5382: build base framework for metrics

yu199195 opened a new pull request #5382:
URL: https://github.com/apache/shardingsphere/pull/5382


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] coveralls edited a comment on pull request #5382: build base framework for metrics

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #5382:
URL: https://github.com/apache/shardingsphere/pull/5382#issuecomment-621168653


   ## Pull Request Test Coverage Report for [Build 11372](https://coveralls.io/builds/30455111)
   
   * **56** of **118**   **(47.46%)**  changed or added relevant lines in **12** files are covered.
   * **5** unchanged lines in **1** file lost coverage.
   * Overall coverage decreased (**-0.05%**) to **57.473%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [sharding-metrics/sharding-metrics-prometheus/src/main/java/org/apache/shardingsphere/metrics/prometheus/impl/counter/RequestTotalCounterMetricsTracker.java](https://coveralls.io/builds/30455111/source?filename=sharding-metrics%2Fsharding-metrics-prometheus%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fmetrics%2Fprometheus%2Fimpl%2Fcounter%2FRequestTotalCounterMetricsTracker.java#L36) | 6 | 8 | 75.0%
   | [sharding-metrics/sharding-metrics-prometheus/src/main/java/org/apache/shardingsphere/metrics/prometheus/impl/counter/SQLStatementCounterMetricsTracker.java](https://coveralls.io/builds/30455111/source?filename=sharding-metrics%2Fsharding-metrics-prometheus%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fmetrics%2Fprometheus%2Fimpl%2Fcounter%2FSQLStatementCounterMetricsTracker.java#L37) | 7 | 9 | 77.78%
   | [sharding-metrics/sharding-metrics-prometheus/src/main/java/org/apache/shardingsphere/metrics/prometheus/impl/histogram/PrometheusHistogramMetricsTrackerDelegate.java](https://coveralls.io/builds/30455111/source?filename=sharding-metrics%2Fsharding-metrics-prometheus%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fmetrics%2Fprometheus%2Fimpl%2Fhistogram%2FPrometheusHistogramMetricsTrackerDelegate.java#L34) | 0 | 2 | 0.0%
   | [sharding-metrics/sharding-metrics-prometheus/src/main/java/org/apache/shardingsphere/metrics/prometheus/impl/histogram/RequestLatencyHistogramMetricsTracker.java](https://coveralls.io/builds/30455111/source?filename=sharding-metrics%2Fsharding-metrics-prometheus%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fmetrics%2Fprometheus%2Fimpl%2Fhistogram%2FRequestLatencyHistogramMetricsTracker.java#L37) | 6 | 8 | 75.0%
   | [sharding-metrics/sharding-metrics-prometheus/src/main/java/org/apache/shardingsphere/metrics/prometheus/impl/summary/PrometheusSummaryMetricsTrackerDelegate.java](https://coveralls.io/builds/30455111/source?filename=sharding-metrics%2Fsharding-metrics-prometheus%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fmetrics%2Fprometheus%2Fimpl%2Fsummary%2FPrometheusSummaryMetricsTrackerDelegate.java#L34) | 0 | 2 | 0.0%
   | [sharding-metrics/sharding-metrics-prometheus/src/main/java/org/apache/shardingsphere/metrics/prometheus/impl/summary/RequestLatencySummaryMetricsTracker.java](https://coveralls.io/builds/30455111/source?filename=sharding-metrics%2Fsharding-metrics-prometheus%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fmetrics%2Fprometheus%2Fimpl%2Fsummary%2FRequestLatencySummaryMetricsTracker.java#L43) | 10 | 12 | 83.33%
   | [sharding-metrics/sharding-metrics-prometheus/src/main/java/org/apache/shardingsphere/metrics/prometheus/impl/gauge/ChannelCountGaugeMetricsTracker.java](https://coveralls.io/builds/30455111/source?filename=sharding-metrics%2Fsharding-metrics-prometheus%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fmetrics%2Fprometheus%2Fimpl%2Fgauge%2FChannelCountGaugeMetricsTracker.java#L33) | 3 | 7 | 42.86%
   | [sharding-metrics/sharding-metrics-spi/src/main/java/org/apache/shardingsphere/metrics/enums/MetricsLabelEnum.java](https://coveralls.io/builds/30455111/source?filename=sharding-metrics%2Fsharding-metrics-spi%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fmetrics%2Fenums%2FMetricsLabelEnum.java#L26) | 0 | 5 | 0.0%
   | [sharding-metrics/sharding-metrics-spi/src/main/java/org/apache/shardingsphere/metrics/enums/MetricsTypeEnum.java](https://coveralls.io/builds/30455111/source?filename=sharding-metrics%2Fsharding-metrics-spi%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fmetrics%2Fenums%2FMetricsTypeEnum.java#L23) | 0 | 5 | 0.0%
   | [sharding-metrics/sharding-metrics-prometheus/src/main/java/org/apache/shardingsphere/metrics/prometheus/PrometheusMetricsTrackerManager.java](https://coveralls.io/builds/30455111/source?filename=sharding-metrics%2Fsharding-metrics-prometheus%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fmetrics%2Fprometheus%2FPrometheusMetricsTrackerManager.java#L36) | 0 | 7 | 0.0%
   <!-- | **Total:** | **56** | **118** | **47.46%** | -->
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/strategy/algorithm/sharding/inline/InlineShardingAlgorithm.java](https://coveralls.io/builds/30455111/source?filename=sharding-core%2Fsharding-core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Fstrategy%2Falgorithm%2Fsharding%2Finline%2FInlineShardingAlgorithm.java#L55) | 5 | 58.82% |
   <!-- | **Total:** | **5** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/30455111/badge)](https://coveralls.io/builds/30455111) |
   | :-- | --: |
   | Change from base [Build 11349](https://coveralls.io/builds/30426921): |  -0.05% |
   | Covered Lines: | 11975 |
   | Relevant Lines: | 20836 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] kimmking commented on a change in pull request #5382: build base framework for metrics

Posted by GitBox <gi...@apache.org>.
kimmking commented on a change in pull request #5382:
URL: https://github.com/apache/shardingsphere/pull/5382#discussion_r417254085



##########
File path: sharding-metrics/sharding-metrics-facade/pom.xml
##########
@@ -0,0 +1,42 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+  ~ Licensed to the Apache Software Foundation (ASF) under one or more
+  ~ contributor license agreements.  See the NOTICE file distributed with
+  ~ this work for additional information regarding copyright ownership.
+  ~ The ASF licenses this file to You under the Apache License, Version 2.0
+  ~ (the "License"); you may not use this file except in compliance with
+  ~ the License.  You may obtain a copy of the License at
+  ~
+  ~     http://www.apache.org/licenses/LICENSE-2.0
+  ~
+  ~ Unless required by applicable law or agreed to in writing, software
+  ~ distributed under the License is distributed on an "AS IS" BASIS,
+  ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  ~ See the License for the specific language governing permissions and
+  ~ limitations under the License.
+  -->
+
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+    <parent>
+        <artifactId>sharding-metrics</artifactId>
+        <groupId>org.apache.shardingsphere</groupId>
+        <version>5.0.0-RC1-SNAPSHOT</version>
+    </parent>
+    <modelVersion>4.0.0</modelVersion>
+
+    <artifactId>sharding-metrics-facade</artifactId>
+
+    <dependencies>
+
+        <dependency>
+            <groupId>org.apache.shardingsphere</groupId>
+            <artifactId>sharding-metrics-spi</artifactId>
+            <version>${project.version}</version>
+        </dependency>
+
+    </dependencies>
+

Review comment:
       one more line

##########
File path: sharding-metrics/sharding-metrics-facade/src/main/java/org/apache/shardingsphere/metrics/facade/MetricsTrackerFacade.java
##########
@@ -0,0 +1,183 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.metrics.facade;
+
+import lombok.extern.slf4j.Slf4j;
+import org.apache.shardingsphere.metrics.api.CounterMetricsTracker;
+import org.apache.shardingsphere.metrics.api.GaugeMetricsTracker;
+import org.apache.shardingsphere.metrics.api.HistogramMetricsTracker;
+import org.apache.shardingsphere.metrics.api.HistogramMetricsTrackerDelegate;
+import org.apache.shardingsphere.metrics.api.MetricsTracker;
+import org.apache.shardingsphere.metrics.api.NoneHistogramMetricsTrackerDelegate;
+import org.apache.shardingsphere.metrics.api.NoneSummaryMetricsTrackerDelegate;
+import org.apache.shardingsphere.metrics.api.SummaryMetricsTracker;
+import org.apache.shardingsphere.metrics.api.SummaryMetricsTrackerDelegate;
+import org.apache.shardingsphere.metrics.enums.MetricsTypeEnum;
+import org.apache.shardingsphere.metrics.spi.MetricsTrackerManager;
+
+import java.util.HashMap;
+import java.util.Map;
+import java.util.Optional;
+import java.util.ServiceLoader;
+import java.util.concurrent.atomic.AtomicBoolean;
+
+/**
+ * Metrics tracker facade.
+ */
+@Slf4j
+public final class MetricsTrackerFacade {
+    
+    private static final Map<String, MetricsTrackerManager> METRICS_MAP = new HashMap<>();
+    
+    private static final MetricsTrackerFacade INSTANCE = new MetricsTrackerFacade();
+    
+    private volatile AtomicBoolean isInit = new AtomicBoolean(false);
+    
+    private Optional<MetricsTrackerManager> metricsTrackerManager = Optional.empty();
+    
+    private MetricsTrackerFacade() {
+        loadMetricsManager();
+    }
+    
+    /**
+     * Get metrics tracker facade.
+     *
+     * @return metrics tracker facade
+     */
+    public static MetricsTrackerFacade getInstance() {
+        return INSTANCE;
+    }
+    
+    /**
+     * Find metrics tracker manager.
+     *
+     * @param metricsName  metrics name
+     * @return metrics tracker manager
+     */
+    public Optional<MetricsTrackerManager> findMetricsTrackerManager(final String metricsName) {
+        return Optional.ofNullable(METRICS_MAP.get(metricsName));
+    }
+    
+    /**
+     * Init for metrics tracker manager.
+     *
+     * @param metricsName metrics name
+     * @param port port
+     */
+    public void init(final String metricsName, final int port) {
+        if (!isInit.compareAndSet(false, true)) {
+            return;
+        }
+        metricsTrackerManager = findMetricsTrackerManager(metricsName);
+        metricsTrackerManager.ifPresent(manager -> manager.init(port));
+    }
+    
+    /**
+     * Inc of counter metrics tracker.

Review comment:
       Increment instead

##########
File path: sharding-metrics/sharding-metrics-spi/pom.xml
##########
@@ -0,0 +1,40 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+  ~ Licensed to the Apache Software Foundation (ASF) under one or more
+  ~ contributor license agreements.  See the NOTICE file distributed with
+  ~ this work for additional information regarding copyright ownership.
+  ~ The ASF licenses this file to You under the Apache License, Version 2.0
+  ~ (the "License"); you may not use this file except in compliance with
+  ~ the License.  You may obtain a copy of the License at
+  ~
+  ~     http://www.apache.org/licenses/LICENSE-2.0
+  ~
+  ~ Unless required by applicable law or agreed to in writing, software
+  ~ distributed under the License is distributed on an "AS IS" BASIS,
+  ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  ~ See the License for the specific language governing permissions and
+  ~ limitations under the License.
+  -->
+
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+    <parent>
+        <artifactId>sharding-metrics</artifactId>
+        <groupId>org.apache.shardingsphere</groupId>
+        <version>5.0.0-RC1-SNAPSHOT</version>
+    </parent>
+    <modelVersion>4.0.0</modelVersion>
+
+    <artifactId>sharding-metrics-spi</artifactId>
+
+    <dependencies>
+        <dependency>
+            <groupId>org.apache.shardingsphere</groupId>
+            <artifactId>shardingsphere-spi</artifactId>
+            <version>${project.version}</version>
+        </dependency>
+    </dependencies>
+

Review comment:
       one more

##########
File path: sharding-metrics/sharding-metrics-prometheus/pom.xml
##########
@@ -0,0 +1,58 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+  ~ Licensed to the Apache Software Foundation (ASF) under one or more
+  ~ contributor license agreements.  See the NOTICE file distributed with
+  ~ this work for additional information regarding copyright ownership.
+  ~ The ASF licenses this file to You under the Apache License, Version 2.0
+  ~ (the "License"); you may not use this file except in compliance with
+  ~ the License.  You may obtain a copy of the License at
+  ~
+  ~     http://www.apache.org/licenses/LICENSE-2.0
+  ~
+  ~ Unless required by applicable law or agreed to in writing, software
+  ~ distributed under the License is distributed on an "AS IS" BASIS,
+  ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  ~ See the License for the specific language governing permissions and
+  ~ limitations under the License.
+  -->
+
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+    <parent>
+        <artifactId>sharding-metrics</artifactId>
+        <groupId>org.apache.shardingsphere</groupId>
+        <version>5.0.0-RC1-SNAPSHOT</version>
+    </parent>
+    <modelVersion>4.0.0</modelVersion>
+
+    <artifactId>sharding-metrics-prometheus</artifactId>
+
+    <dependencies>
+        <dependency>
+            <groupId>org.apache.shardingsphere</groupId>
+            <artifactId>sharding-metrics-spi</artifactId>
+            <version>${project.version}</version>
+        </dependency>
+
+        <dependency>
+            <groupId>org.projectlombok</groupId>
+            <artifactId>lombok</artifactId>
+            <version>1.16.20</version>
+        </dependency>
+
+        <dependency>
+            <groupId>io.prometheus</groupId>
+            <artifactId>simpleclient</artifactId>
+            <version>0.6.0</version>

Review comment:
       move to root pom




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] coveralls edited a comment on pull request #5382: build base framework for metrics

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #5382:
URL: https://github.com/apache/shardingsphere/pull/5382#issuecomment-621168653


   ## Pull Request Test Coverage Report for [Build 11354](https://coveralls.io/builds/30430078)
   
   * **56** of **118**   **(47.46%)**  changed or added relevant lines in **12** files are covered.
   * No unchanged relevant lines lost coverage.
   * Overall coverage decreased (**-0.06%**) to **57.471%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [sharding-metrics/sharding-metrics-prometheus/src/main/java/org/apache/shardingsphere/metrics/prometheus/impl/counter/RequestTotalCounterMetricsTracker.java](https://coveralls.io/builds/30430078/source?filename=sharding-metrics%2Fsharding-metrics-prometheus%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fmetrics%2Fprometheus%2Fimpl%2Fcounter%2FRequestTotalCounterMetricsTracker.java#L36) | 6 | 8 | 75.0%
   | [sharding-metrics/sharding-metrics-prometheus/src/main/java/org/apache/shardingsphere/metrics/prometheus/impl/counter/SQLStatementCounterMetricsTracker.java](https://coveralls.io/builds/30430078/source?filename=sharding-metrics%2Fsharding-metrics-prometheus%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fmetrics%2Fprometheus%2Fimpl%2Fcounter%2FSQLStatementCounterMetricsTracker.java#L37) | 7 | 9 | 77.78%
   | [sharding-metrics/sharding-metrics-prometheus/src/main/java/org/apache/shardingsphere/metrics/prometheus/impl/histogram/PrometheusHistogramMetricsTrackerDelegate.java](https://coveralls.io/builds/30430078/source?filename=sharding-metrics%2Fsharding-metrics-prometheus%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fmetrics%2Fprometheus%2Fimpl%2Fhistogram%2FPrometheusHistogramMetricsTrackerDelegate.java#L34) | 0 | 2 | 0.0%
   | [sharding-metrics/sharding-metrics-prometheus/src/main/java/org/apache/shardingsphere/metrics/prometheus/impl/histogram/RequestLatencyHistogramMetricsTracker.java](https://coveralls.io/builds/30430078/source?filename=sharding-metrics%2Fsharding-metrics-prometheus%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fmetrics%2Fprometheus%2Fimpl%2Fhistogram%2FRequestLatencyHistogramMetricsTracker.java#L37) | 6 | 8 | 75.0%
   | [sharding-metrics/sharding-metrics-prometheus/src/main/java/org/apache/shardingsphere/metrics/prometheus/impl/summary/PrometheusSummaryMetricsTrackerDelegate.java](https://coveralls.io/builds/30430078/source?filename=sharding-metrics%2Fsharding-metrics-prometheus%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fmetrics%2Fprometheus%2Fimpl%2Fsummary%2FPrometheusSummaryMetricsTrackerDelegate.java#L34) | 0 | 2 | 0.0%
   | [sharding-metrics/sharding-metrics-prometheus/src/main/java/org/apache/shardingsphere/metrics/prometheus/impl/summary/RequestLatencySummaryMetricsTracker.java](https://coveralls.io/builds/30430078/source?filename=sharding-metrics%2Fsharding-metrics-prometheus%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fmetrics%2Fprometheus%2Fimpl%2Fsummary%2FRequestLatencySummaryMetricsTracker.java#L43) | 10 | 12 | 83.33%
   | [sharding-metrics/sharding-metrics-prometheus/src/main/java/org/apache/shardingsphere/metrics/prometheus/impl/gauge/ChannelCountGaugeMetricsTracker.java](https://coveralls.io/builds/30430078/source?filename=sharding-metrics%2Fsharding-metrics-prometheus%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fmetrics%2Fprometheus%2Fimpl%2Fgauge%2FChannelCountGaugeMetricsTracker.java#L33) | 3 | 7 | 42.86%
   | [sharding-metrics/sharding-metrics-spi/src/main/java/org/apache/shardingsphere/metrics/enums/MetricsLabelEnum.java](https://coveralls.io/builds/30430078/source?filename=sharding-metrics%2Fsharding-metrics-spi%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fmetrics%2Fenums%2FMetricsLabelEnum.java#L26) | 0 | 5 | 0.0%
   | [sharding-metrics/sharding-metrics-spi/src/main/java/org/apache/shardingsphere/metrics/enums/MetricsTypeEnum.java](https://coveralls.io/builds/30430078/source?filename=sharding-metrics%2Fsharding-metrics-spi%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fmetrics%2Fenums%2FMetricsTypeEnum.java#L23) | 0 | 5 | 0.0%
   | [sharding-metrics/sharding-metrics-prometheus/src/main/java/org/apache/shardingsphere/metrics/prometheus/PrometheusMetricsTrackerManager.java](https://coveralls.io/builds/30430078/source?filename=sharding-metrics%2Fsharding-metrics-prometheus%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fmetrics%2Fprometheus%2FPrometheusMetricsTrackerManager.java#L36) | 0 | 7 | 0.0%
   <!-- | **Total:** | **56** | **118** | **47.46%** | -->
   
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/30430078/badge)](https://coveralls.io/builds/30430078) |
   | :-- | --: |
   | Change from base [Build 11349](https://coveralls.io/builds/30426921): |  -0.06% |
   | Covered Lines: | 11974 |
   | Relevant Lines: | 20835 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] coveralls commented on pull request #5382: build base framework for metrics

Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #5382:
URL: https://github.com/apache/shardingsphere/pull/5382#issuecomment-621168653


   ## Pull Request Test Coverage Report for [Build 11351](https://coveralls.io/builds/30429115)
   
   * **56** of **118**   **(47.46%)**  changed or added relevant lines in **12** files are covered.
   * No unchanged relevant lines lost coverage.
   * Overall coverage decreased (**-0.06%**) to **57.471%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [sharding-metrics/sharding-metrics-prometheus/src/main/java/org/apache/shardingsphere/metrics/prometheus/impl/counter/RequestTotalCounterMetricsTracker.java](https://coveralls.io/builds/30429115/source?filename=sharding-metrics%2Fsharding-metrics-prometheus%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fmetrics%2Fprometheus%2Fimpl%2Fcounter%2FRequestTotalCounterMetricsTracker.java#L36) | 6 | 8 | 75.0%
   | [sharding-metrics/sharding-metrics-prometheus/src/main/java/org/apache/shardingsphere/metrics/prometheus/impl/counter/SQLStatementCounterMetricsTracker.java](https://coveralls.io/builds/30429115/source?filename=sharding-metrics%2Fsharding-metrics-prometheus%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fmetrics%2Fprometheus%2Fimpl%2Fcounter%2FSQLStatementCounterMetricsTracker.java#L37) | 7 | 9 | 77.78%
   | [sharding-metrics/sharding-metrics-prometheus/src/main/java/org/apache/shardingsphere/metrics/prometheus/impl/histogram/PrometheusHistogramMetricsTrackerDelegate.java](https://coveralls.io/builds/30429115/source?filename=sharding-metrics%2Fsharding-metrics-prometheus%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fmetrics%2Fprometheus%2Fimpl%2Fhistogram%2FPrometheusHistogramMetricsTrackerDelegate.java#L34) | 0 | 2 | 0.0%
   | [sharding-metrics/sharding-metrics-prometheus/src/main/java/org/apache/shardingsphere/metrics/prometheus/impl/histogram/RequestLatencyHistogramMetricsTracker.java](https://coveralls.io/builds/30429115/source?filename=sharding-metrics%2Fsharding-metrics-prometheus%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fmetrics%2Fprometheus%2Fimpl%2Fhistogram%2FRequestLatencyHistogramMetricsTracker.java#L37) | 6 | 8 | 75.0%
   | [sharding-metrics/sharding-metrics-prometheus/src/main/java/org/apache/shardingsphere/metrics/prometheus/impl/summary/PrometheusSummaryMetricsTrackerDelegate.java](https://coveralls.io/builds/30429115/source?filename=sharding-metrics%2Fsharding-metrics-prometheus%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fmetrics%2Fprometheus%2Fimpl%2Fsummary%2FPrometheusSummaryMetricsTrackerDelegate.java#L34) | 0 | 2 | 0.0%
   | [sharding-metrics/sharding-metrics-prometheus/src/main/java/org/apache/shardingsphere/metrics/prometheus/impl/summary/RequestLatencySummaryMetricsTracker.java](https://coveralls.io/builds/30429115/source?filename=sharding-metrics%2Fsharding-metrics-prometheus%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fmetrics%2Fprometheus%2Fimpl%2Fsummary%2FRequestLatencySummaryMetricsTracker.java#L43) | 10 | 12 | 83.33%
   | [sharding-metrics/sharding-metrics-prometheus/src/main/java/org/apache/shardingsphere/metrics/prometheus/impl/gauge/ChannelCountGaugeMetricsTracker.java](https://coveralls.io/builds/30429115/source?filename=sharding-metrics%2Fsharding-metrics-prometheus%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fmetrics%2Fprometheus%2Fimpl%2Fgauge%2FChannelCountGaugeMetricsTracker.java#L33) | 3 | 7 | 42.86%
   | [sharding-metrics/sharding-metrics-spi/src/main/java/org/apache/shardingsphere/metrics/enums/MetricsLabelEnum.java](https://coveralls.io/builds/30429115/source?filename=sharding-metrics%2Fsharding-metrics-spi%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fmetrics%2Fenums%2FMetricsLabelEnum.java#L26) | 0 | 5 | 0.0%
   | [sharding-metrics/sharding-metrics-spi/src/main/java/org/apache/shardingsphere/metrics/enums/MetricsTypeEnum.java](https://coveralls.io/builds/30429115/source?filename=sharding-metrics%2Fsharding-metrics-spi%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fmetrics%2Fenums%2FMetricsTypeEnum.java#L23) | 0 | 5 | 0.0%
   | [sharding-metrics/sharding-metrics-prometheus/src/main/java/org/apache/shardingsphere/metrics/prometheus/PrometheusMetricsTrackerManager.java](https://coveralls.io/builds/30429115/source?filename=sharding-metrics%2Fsharding-metrics-prometheus%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fmetrics%2Fprometheus%2FPrometheusMetricsTrackerManager.java#L36) | 0 | 7 | 0.0%
   <!-- | **Total:** | **56** | **118** | **47.46%** | -->
   
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/30429115/badge)](https://coveralls.io/builds/30429115) |
   | :-- | --: |
   | Change from base [Build 11349](https://coveralls.io/builds/30426921): |  -0.06% |
   | Covered Lines: | 11974 |
   | Relevant Lines: | 20835 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] coveralls edited a comment on pull request #5382: build base framework for metrics

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #5382:
URL: https://github.com/apache/shardingsphere/pull/5382#issuecomment-621168653


   ## Pull Request Test Coverage Report for [Build 11358](https://coveralls.io/builds/30450915)
   
   * **56** of **118**   **(47.46%)**  changed or added relevant lines in **12** files are covered.
   * No unchanged relevant lines lost coverage.
   * Overall coverage decreased (**-0.06%**) to **57.471%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [sharding-metrics/sharding-metrics-prometheus/src/main/java/org/apache/shardingsphere/metrics/prometheus/impl/counter/RequestTotalCounterMetricsTracker.java](https://coveralls.io/builds/30450915/source?filename=sharding-metrics%2Fsharding-metrics-prometheus%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fmetrics%2Fprometheus%2Fimpl%2Fcounter%2FRequestTotalCounterMetricsTracker.java#L36) | 6 | 8 | 75.0%
   | [sharding-metrics/sharding-metrics-prometheus/src/main/java/org/apache/shardingsphere/metrics/prometheus/impl/counter/SQLStatementCounterMetricsTracker.java](https://coveralls.io/builds/30450915/source?filename=sharding-metrics%2Fsharding-metrics-prometheus%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fmetrics%2Fprometheus%2Fimpl%2Fcounter%2FSQLStatementCounterMetricsTracker.java#L37) | 7 | 9 | 77.78%
   | [sharding-metrics/sharding-metrics-prometheus/src/main/java/org/apache/shardingsphere/metrics/prometheus/impl/histogram/PrometheusHistogramMetricsTrackerDelegate.java](https://coveralls.io/builds/30450915/source?filename=sharding-metrics%2Fsharding-metrics-prometheus%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fmetrics%2Fprometheus%2Fimpl%2Fhistogram%2FPrometheusHistogramMetricsTrackerDelegate.java#L34) | 0 | 2 | 0.0%
   | [sharding-metrics/sharding-metrics-prometheus/src/main/java/org/apache/shardingsphere/metrics/prometheus/impl/histogram/RequestLatencyHistogramMetricsTracker.java](https://coveralls.io/builds/30450915/source?filename=sharding-metrics%2Fsharding-metrics-prometheus%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fmetrics%2Fprometheus%2Fimpl%2Fhistogram%2FRequestLatencyHistogramMetricsTracker.java#L37) | 6 | 8 | 75.0%
   | [sharding-metrics/sharding-metrics-prometheus/src/main/java/org/apache/shardingsphere/metrics/prometheus/impl/summary/PrometheusSummaryMetricsTrackerDelegate.java](https://coveralls.io/builds/30450915/source?filename=sharding-metrics%2Fsharding-metrics-prometheus%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fmetrics%2Fprometheus%2Fimpl%2Fsummary%2FPrometheusSummaryMetricsTrackerDelegate.java#L34) | 0 | 2 | 0.0%
   | [sharding-metrics/sharding-metrics-prometheus/src/main/java/org/apache/shardingsphere/metrics/prometheus/impl/summary/RequestLatencySummaryMetricsTracker.java](https://coveralls.io/builds/30450915/source?filename=sharding-metrics%2Fsharding-metrics-prometheus%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fmetrics%2Fprometheus%2Fimpl%2Fsummary%2FRequestLatencySummaryMetricsTracker.java#L43) | 10 | 12 | 83.33%
   | [sharding-metrics/sharding-metrics-prometheus/src/main/java/org/apache/shardingsphere/metrics/prometheus/impl/gauge/ChannelCountGaugeMetricsTracker.java](https://coveralls.io/builds/30450915/source?filename=sharding-metrics%2Fsharding-metrics-prometheus%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fmetrics%2Fprometheus%2Fimpl%2Fgauge%2FChannelCountGaugeMetricsTracker.java#L33) | 3 | 7 | 42.86%
   | [sharding-metrics/sharding-metrics-spi/src/main/java/org/apache/shardingsphere/metrics/enums/MetricsLabelEnum.java](https://coveralls.io/builds/30450915/source?filename=sharding-metrics%2Fsharding-metrics-spi%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fmetrics%2Fenums%2FMetricsLabelEnum.java#L26) | 0 | 5 | 0.0%
   | [sharding-metrics/sharding-metrics-spi/src/main/java/org/apache/shardingsphere/metrics/enums/MetricsTypeEnum.java](https://coveralls.io/builds/30450915/source?filename=sharding-metrics%2Fsharding-metrics-spi%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fmetrics%2Fenums%2FMetricsTypeEnum.java#L23) | 0 | 5 | 0.0%
   | [sharding-metrics/sharding-metrics-prometheus/src/main/java/org/apache/shardingsphere/metrics/prometheus/PrometheusMetricsTrackerManager.java](https://coveralls.io/builds/30450915/source?filename=sharding-metrics%2Fsharding-metrics-prometheus%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fmetrics%2Fprometheus%2FPrometheusMetricsTrackerManager.java#L36) | 0 | 7 | 0.0%
   <!-- | **Total:** | **56** | **118** | **47.46%** | -->
   
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/30450915/badge)](https://coveralls.io/builds/30450915) |
   | :-- | --: |
   | Change from base [Build 11349](https://coveralls.io/builds/30426921): |  -0.06% |
   | Covered Lines: | 11974 |
   | Relevant Lines: | 20835 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] yu199195 commented on a change in pull request #5382: build base framework for metrics

Posted by GitBox <gi...@apache.org>.
yu199195 commented on a change in pull request #5382:
URL: https://github.com/apache/shardingsphere/pull/5382#discussion_r417715532



##########
File path: sharding-metrics/sharding-metrics-prometheus/pom.xml
##########
@@ -0,0 +1,58 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+  ~ Licensed to the Apache Software Foundation (ASF) under one or more
+  ~ contributor license agreements.  See the NOTICE file distributed with
+  ~ this work for additional information regarding copyright ownership.
+  ~ The ASF licenses this file to You under the Apache License, Version 2.0
+  ~ (the "License"); you may not use this file except in compliance with
+  ~ the License.  You may obtain a copy of the License at
+  ~
+  ~     http://www.apache.org/licenses/LICENSE-2.0
+  ~
+  ~ Unless required by applicable law or agreed to in writing, software
+  ~ distributed under the License is distributed on an "AS IS" BASIS,
+  ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  ~ See the License for the specific language governing permissions and
+  ~ limitations under the License.
+  -->
+
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+    <parent>
+        <artifactId>sharding-metrics</artifactId>
+        <groupId>org.apache.shardingsphere</groupId>
+        <version>5.0.0-RC1-SNAPSHOT</version>
+    </parent>
+    <modelVersion>4.0.0</modelVersion>
+
+    <artifactId>sharding-metrics-prometheus</artifactId>
+
+    <dependencies>
+        <dependency>
+            <groupId>org.apache.shardingsphere</groupId>
+            <artifactId>sharding-metrics-spi</artifactId>
+            <version>${project.version}</version>
+        </dependency>
+
+        <dependency>
+            <groupId>org.projectlombok</groupId>
+            <artifactId>lombok</artifactId>
+            <version>1.16.20</version>
+        </dependency>
+
+        <dependency>
+            <groupId>io.prometheus</groupId>
+            <artifactId>simpleclient</artifactId>
+            <version>0.6.0</version>

Review comment:
       ok




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] yu199195 commented on a change in pull request #5382: build base framework for metrics

Posted by GitBox <gi...@apache.org>.
yu199195 commented on a change in pull request #5382:
URL: https://github.com/apache/shardingsphere/pull/5382#discussion_r417715567



##########
File path: sharding-metrics/sharding-metrics-spi/pom.xml
##########
@@ -0,0 +1,40 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+  ~ Licensed to the Apache Software Foundation (ASF) under one or more
+  ~ contributor license agreements.  See the NOTICE file distributed with
+  ~ this work for additional information regarding copyright ownership.
+  ~ The ASF licenses this file to You under the Apache License, Version 2.0
+  ~ (the "License"); you may not use this file except in compliance with
+  ~ the License.  You may obtain a copy of the License at
+  ~
+  ~     http://www.apache.org/licenses/LICENSE-2.0
+  ~
+  ~ Unless required by applicable law or agreed to in writing, software
+  ~ distributed under the License is distributed on an "AS IS" BASIS,
+  ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  ~ See the License for the specific language governing permissions and
+  ~ limitations under the License.
+  -->
+
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+    <parent>
+        <artifactId>sharding-metrics</artifactId>
+        <groupId>org.apache.shardingsphere</groupId>
+        <version>5.0.0-RC1-SNAPSHOT</version>
+    </parent>
+    <modelVersion>4.0.0</modelVersion>
+
+    <artifactId>sharding-metrics-spi</artifactId>
+
+    <dependencies>
+        <dependency>
+            <groupId>org.apache.shardingsphere</groupId>
+            <artifactId>shardingsphere-spi</artifactId>
+            <version>${project.version}</version>
+        </dependency>
+    </dependencies>
+

Review comment:
       ok




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-io commented on pull request #5382: build base framework for metrics

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #5382:
URL: https://github.com/apache/shardingsphere/pull/5382#issuecomment-621582821


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5382?src=pr&el=h1) Report
   > Merging [#5382](https://codecov.io/gh/apache/shardingsphere/pull/5382?src=pr&el=desc) into [master](https://codecov.io/gh/apache/shardingsphere/commit/d0d7648b8c44ecd55c0af7db0590a3cd43c4897b&el=desc) will **increase** coverage by `0.08%`.
   > The diff coverage is `46.61%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/5382/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/shardingsphere/pull/5382?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5382      +/-   ##
   ============================================
   + Coverage     53.89%   53.98%   +0.08%     
   - Complexity      412      418       +6     
   ============================================
     Files          1149     1162      +13     
     Lines         20704    20835     +131     
     Branches       3756     3760       +4     
   ============================================
   + Hits          11159    11247      +88     
   - Misses         8830     8874      +44     
   + Partials        715      714       -1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/5382?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...cs/prometheus/PrometheusMetricsTrackerManager.java](https://codecov.io/gh/apache/shardingsphere/pull/5382/diff?src=pr&el=tree#diff-c2hhcmRpbmctbWV0cmljcy9zaGFyZGluZy1tZXRyaWNzLXByb21ldGhldXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL21ldHJpY3MvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljc1RyYWNrZXJNYW5hZ2VyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...ram/PrometheusHistogramMetricsTrackerDelegate.java](https://codecov.io/gh/apache/shardingsphere/pull/5382/diff?src=pr&el=tree#diff-c2hhcmRpbmctbWV0cmljcy9zaGFyZGluZy1tZXRyaWNzLXByb21ldGhldXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL21ldHJpY3MvcHJvbWV0aGV1cy9pbXBsL2hpc3RvZ3JhbS9Qcm9tZXRoZXVzSGlzdG9ncmFtTWV0cmljc1RyYWNrZXJEZWxlZ2F0ZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...mmary/PrometheusSummaryMetricsTrackerDelegate.java](https://codecov.io/gh/apache/shardingsphere/pull/5382/diff?src=pr&el=tree#diff-c2hhcmRpbmctbWV0cmljcy9zaGFyZGluZy1tZXRyaWNzLXByb21ldGhldXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL21ldHJpY3MvcHJvbWV0aGV1cy9pbXBsL3N1bW1hcnkvUHJvbWV0aGV1c1N1bW1hcnlNZXRyaWNzVHJhY2tlckRlbGVnYXRlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...shardingsphere/metrics/enums/MetricsLabelEnum.java](https://codecov.io/gh/apache/shardingsphere/pull/5382/diff?src=pr&el=tree#diff-c2hhcmRpbmctbWV0cmljcy9zaGFyZGluZy1tZXRyaWNzLXNwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvbWV0cmljcy9lbnVtcy9NZXRyaWNzTGFiZWxFbnVtLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../shardingsphere/metrics/enums/MetricsTypeEnum.java](https://codecov.io/gh/apache/shardingsphere/pull/5382/diff?src=pr&el=tree#diff-c2hhcmRpbmctbWV0cmljcy9zaGFyZGluZy1tZXRyaWNzLXNwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvbWV0cmljcy9lbnVtcy9NZXRyaWNzVHlwZUVudW0uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...ingsphere/metrics/facade/MetricsTrackerFacade.java](https://codecov.io/gh/apache/shardingsphere/pull/5382/diff?src=pr&el=tree#diff-c2hhcmRpbmctbWV0cmljcy9zaGFyZGluZy1tZXRyaWNzLWZhY2FkZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvbWV0cmljcy9mYWNhZGUvTWV0cmljc1RyYWNrZXJGYWNhZGUuamF2YQ==) | `31.81% <31.81%> (ø)` | `0.00 <0.00> (?)` | |
   | [...us/impl/gauge/ChannelCountGaugeMetricsTracker.java](https://codecov.io/gh/apache/shardingsphere/pull/5382/diff?src=pr&el=tree#diff-c2hhcmRpbmctbWV0cmljcy9zaGFyZGluZy1tZXRyaWNzLXByb21ldGhldXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL21ldHJpY3MvcHJvbWV0aGV1cy9pbXBsL2dhdWdlL0NoYW5uZWxDb3VudEdhdWdlTWV0cmljc1RyYWNrZXIuamF2YQ==) | `42.85% <42.85%> (ø)` | `1.00 <1.00> (?)` | |
   | [...mpl/counter/RequestTotalCounterMetricsTracker.java](https://codecov.io/gh/apache/shardingsphere/pull/5382/diff?src=pr&el=tree#diff-c2hhcmRpbmctbWV0cmljcy9zaGFyZGluZy1tZXRyaWNzLXByb21ldGhldXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL21ldHJpY3MvcHJvbWV0aGV1cy9pbXBsL2NvdW50ZXIvUmVxdWVzdFRvdGFsQ291bnRlck1ldHJpY3NUcmFja2VyLmphdmE=) | `75.00% <75.00%> (ø)` | `1.00 <1.00> (?)` | |
   | [...stogram/RequestLatencyHistogramMetricsTracker.java](https://codecov.io/gh/apache/shardingsphere/pull/5382/diff?src=pr&el=tree#diff-c2hhcmRpbmctbWV0cmljcy9zaGFyZGluZy1tZXRyaWNzLXByb21ldGhldXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL21ldHJpY3MvcHJvbWV0aGV1cy9pbXBsL2hpc3RvZ3JhbS9SZXF1ZXN0TGF0ZW5jeUhpc3RvZ3JhbU1ldHJpY3NUcmFja2VyLmphdmE=) | `75.00% <75.00%> (ø)` | `1.00 <1.00> (?)` | |
   | [...mpl/counter/SQLStatementCounterMetricsTracker.java](https://codecov.io/gh/apache/shardingsphere/pull/5382/diff?src=pr&el=tree#diff-c2hhcmRpbmctbWV0cmljcy9zaGFyZGluZy1tZXRyaWNzLXByb21ldGhldXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL21ldHJpY3MvcHJvbWV0aGV1cy9pbXBsL2NvdW50ZXIvU1FMU3RhdGVtZW50Q291bnRlck1ldHJpY3NUcmFja2VyLmphdmE=) | `77.77% <77.77%> (ø)` | `1.00 <1.00> (?)` | |
   | ... and [34 more](https://codecov.io/gh/apache/shardingsphere/pull/5382/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5382?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5382?src=pr&el=footer). Last update [d0d7648...afb692c](https://codecov.io/gh/apache/shardingsphere/pull/5382?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-io edited a comment on pull request #5382: build base framework for metrics

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #5382:
URL: https://github.com/apache/shardingsphere/pull/5382#issuecomment-621582821


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5382?src=pr&el=h1) Report
   > Merging [#5382](https://codecov.io/gh/apache/shardingsphere/pull/5382?src=pr&el=desc) into [master](https://codecov.io/gh/apache/shardingsphere/commit/d0d7648b8c44ecd55c0af7db0590a3cd43c4897b&el=desc) will **increase** coverage by `0.08%`.
   > The diff coverage is `46.61%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/5382/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/shardingsphere/pull/5382?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5382      +/-   ##
   ============================================
   + Coverage     53.89%   53.98%   +0.08%     
   - Complexity      412      418       +6     
   ============================================
     Files          1149     1162      +13     
     Lines         20704    20836     +132     
     Branches       3756     3760       +4     
   ============================================
   + Hits          11159    11248      +89     
   - Misses         8830     8874      +44     
   + Partials        715      714       -1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/5382?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...cs/prometheus/PrometheusMetricsTrackerManager.java](https://codecov.io/gh/apache/shardingsphere/pull/5382/diff?src=pr&el=tree#diff-c2hhcmRpbmctbWV0cmljcy9zaGFyZGluZy1tZXRyaWNzLXByb21ldGhldXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL21ldHJpY3MvcHJvbWV0aGV1cy9Qcm9tZXRoZXVzTWV0cmljc1RyYWNrZXJNYW5hZ2VyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...ram/PrometheusHistogramMetricsTrackerDelegate.java](https://codecov.io/gh/apache/shardingsphere/pull/5382/diff?src=pr&el=tree#diff-c2hhcmRpbmctbWV0cmljcy9zaGFyZGluZy1tZXRyaWNzLXByb21ldGhldXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL21ldHJpY3MvcHJvbWV0aGV1cy9pbXBsL2hpc3RvZ3JhbS9Qcm9tZXRoZXVzSGlzdG9ncmFtTWV0cmljc1RyYWNrZXJEZWxlZ2F0ZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...mmary/PrometheusSummaryMetricsTrackerDelegate.java](https://codecov.io/gh/apache/shardingsphere/pull/5382/diff?src=pr&el=tree#diff-c2hhcmRpbmctbWV0cmljcy9zaGFyZGluZy1tZXRyaWNzLXByb21ldGhldXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL21ldHJpY3MvcHJvbWV0aGV1cy9pbXBsL3N1bW1hcnkvUHJvbWV0aGV1c1N1bW1hcnlNZXRyaWNzVHJhY2tlckRlbGVnYXRlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...shardingsphere/metrics/enums/MetricsLabelEnum.java](https://codecov.io/gh/apache/shardingsphere/pull/5382/diff?src=pr&el=tree#diff-c2hhcmRpbmctbWV0cmljcy9zaGFyZGluZy1tZXRyaWNzLXNwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvbWV0cmljcy9lbnVtcy9NZXRyaWNzTGFiZWxFbnVtLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../shardingsphere/metrics/enums/MetricsTypeEnum.java](https://codecov.io/gh/apache/shardingsphere/pull/5382/diff?src=pr&el=tree#diff-c2hhcmRpbmctbWV0cmljcy9zaGFyZGluZy1tZXRyaWNzLXNwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvbWV0cmljcy9lbnVtcy9NZXRyaWNzVHlwZUVudW0uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...ingsphere/metrics/facade/MetricsTrackerFacade.java](https://codecov.io/gh/apache/shardingsphere/pull/5382/diff?src=pr&el=tree#diff-c2hhcmRpbmctbWV0cmljcy9zaGFyZGluZy1tZXRyaWNzLWZhY2FkZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvbWV0cmljcy9mYWNhZGUvTWV0cmljc1RyYWNrZXJGYWNhZGUuamF2YQ==) | `31.81% <31.81%> (ø)` | `0.00 <0.00> (?)` | |
   | [...us/impl/gauge/ChannelCountGaugeMetricsTracker.java](https://codecov.io/gh/apache/shardingsphere/pull/5382/diff?src=pr&el=tree#diff-c2hhcmRpbmctbWV0cmljcy9zaGFyZGluZy1tZXRyaWNzLXByb21ldGhldXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL21ldHJpY3MvcHJvbWV0aGV1cy9pbXBsL2dhdWdlL0NoYW5uZWxDb3VudEdhdWdlTWV0cmljc1RyYWNrZXIuamF2YQ==) | `42.85% <42.85%> (ø)` | `1.00 <1.00> (?)` | |
   | [...mpl/counter/RequestTotalCounterMetricsTracker.java](https://codecov.io/gh/apache/shardingsphere/pull/5382/diff?src=pr&el=tree#diff-c2hhcmRpbmctbWV0cmljcy9zaGFyZGluZy1tZXRyaWNzLXByb21ldGhldXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL21ldHJpY3MvcHJvbWV0aGV1cy9pbXBsL2NvdW50ZXIvUmVxdWVzdFRvdGFsQ291bnRlck1ldHJpY3NUcmFja2VyLmphdmE=) | `75.00% <75.00%> (ø)` | `1.00 <1.00> (?)` | |
   | [...stogram/RequestLatencyHistogramMetricsTracker.java](https://codecov.io/gh/apache/shardingsphere/pull/5382/diff?src=pr&el=tree#diff-c2hhcmRpbmctbWV0cmljcy9zaGFyZGluZy1tZXRyaWNzLXByb21ldGhldXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL21ldHJpY3MvcHJvbWV0aGV1cy9pbXBsL2hpc3RvZ3JhbS9SZXF1ZXN0TGF0ZW5jeUhpc3RvZ3JhbU1ldHJpY3NUcmFja2VyLmphdmE=) | `75.00% <75.00%> (ø)` | `1.00 <1.00> (?)` | |
   | [...mpl/counter/SQLStatementCounterMetricsTracker.java](https://codecov.io/gh/apache/shardingsphere/pull/5382/diff?src=pr&el=tree#diff-c2hhcmRpbmctbWV0cmljcy9zaGFyZGluZy1tZXRyaWNzLXByb21ldGhldXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL21ldHJpY3MvcHJvbWV0aGV1cy9pbXBsL2NvdW50ZXIvU1FMU3RhdGVtZW50Q291bnRlck1ldHJpY3NUcmFja2VyLmphdmE=) | `77.77% <77.77%> (ø)` | `1.00 <1.00> (?)` | |
   | ... and [35 more](https://codecov.io/gh/apache/shardingsphere/pull/5382/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5382?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5382?src=pr&el=footer). Last update [d0d7648...dd31329](https://codecov.io/gh/apache/shardingsphere/pull/5382?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] coveralls edited a comment on pull request #5382: build base framework for metrics

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #5382:
URL: https://github.com/apache/shardingsphere/pull/5382#issuecomment-621168653


   ## Pull Request Test Coverage Report for [Build 11370](https://coveralls.io/builds/30454031)
   
   * **56** of **118**   **(47.46%)**  changed or added relevant lines in **12** files are covered.
   * **5** unchanged lines in **1** file lost coverage.
   * Overall coverage decreased (**-0.05%**) to **57.473%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [sharding-metrics/sharding-metrics-prometheus/src/main/java/org/apache/shardingsphere/metrics/prometheus/impl/counter/RequestTotalCounterMetricsTracker.java](https://coveralls.io/builds/30454031/source?filename=sharding-metrics%2Fsharding-metrics-prometheus%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fmetrics%2Fprometheus%2Fimpl%2Fcounter%2FRequestTotalCounterMetricsTracker.java#L36) | 6 | 8 | 75.0%
   | [sharding-metrics/sharding-metrics-prometheus/src/main/java/org/apache/shardingsphere/metrics/prometheus/impl/counter/SQLStatementCounterMetricsTracker.java](https://coveralls.io/builds/30454031/source?filename=sharding-metrics%2Fsharding-metrics-prometheus%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fmetrics%2Fprometheus%2Fimpl%2Fcounter%2FSQLStatementCounterMetricsTracker.java#L37) | 7 | 9 | 77.78%
   | [sharding-metrics/sharding-metrics-prometheus/src/main/java/org/apache/shardingsphere/metrics/prometheus/impl/histogram/PrometheusHistogramMetricsTrackerDelegate.java](https://coveralls.io/builds/30454031/source?filename=sharding-metrics%2Fsharding-metrics-prometheus%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fmetrics%2Fprometheus%2Fimpl%2Fhistogram%2FPrometheusHistogramMetricsTrackerDelegate.java#L34) | 0 | 2 | 0.0%
   | [sharding-metrics/sharding-metrics-prometheus/src/main/java/org/apache/shardingsphere/metrics/prometheus/impl/histogram/RequestLatencyHistogramMetricsTracker.java](https://coveralls.io/builds/30454031/source?filename=sharding-metrics%2Fsharding-metrics-prometheus%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fmetrics%2Fprometheus%2Fimpl%2Fhistogram%2FRequestLatencyHistogramMetricsTracker.java#L37) | 6 | 8 | 75.0%
   | [sharding-metrics/sharding-metrics-prometheus/src/main/java/org/apache/shardingsphere/metrics/prometheus/impl/summary/PrometheusSummaryMetricsTrackerDelegate.java](https://coveralls.io/builds/30454031/source?filename=sharding-metrics%2Fsharding-metrics-prometheus%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fmetrics%2Fprometheus%2Fimpl%2Fsummary%2FPrometheusSummaryMetricsTrackerDelegate.java#L34) | 0 | 2 | 0.0%
   | [sharding-metrics/sharding-metrics-prometheus/src/main/java/org/apache/shardingsphere/metrics/prometheus/impl/summary/RequestLatencySummaryMetricsTracker.java](https://coveralls.io/builds/30454031/source?filename=sharding-metrics%2Fsharding-metrics-prometheus%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fmetrics%2Fprometheus%2Fimpl%2Fsummary%2FRequestLatencySummaryMetricsTracker.java#L43) | 10 | 12 | 83.33%
   | [sharding-metrics/sharding-metrics-prometheus/src/main/java/org/apache/shardingsphere/metrics/prometheus/impl/gauge/ChannelCountGaugeMetricsTracker.java](https://coveralls.io/builds/30454031/source?filename=sharding-metrics%2Fsharding-metrics-prometheus%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fmetrics%2Fprometheus%2Fimpl%2Fgauge%2FChannelCountGaugeMetricsTracker.java#L33) | 3 | 7 | 42.86%
   | [sharding-metrics/sharding-metrics-spi/src/main/java/org/apache/shardingsphere/metrics/enums/MetricsLabelEnum.java](https://coveralls.io/builds/30454031/source?filename=sharding-metrics%2Fsharding-metrics-spi%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fmetrics%2Fenums%2FMetricsLabelEnum.java#L26) | 0 | 5 | 0.0%
   | [sharding-metrics/sharding-metrics-spi/src/main/java/org/apache/shardingsphere/metrics/enums/MetricsTypeEnum.java](https://coveralls.io/builds/30454031/source?filename=sharding-metrics%2Fsharding-metrics-spi%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fmetrics%2Fenums%2FMetricsTypeEnum.java#L23) | 0 | 5 | 0.0%
   | [sharding-metrics/sharding-metrics-prometheus/src/main/java/org/apache/shardingsphere/metrics/prometheus/PrometheusMetricsTrackerManager.java](https://coveralls.io/builds/30454031/source?filename=sharding-metrics%2Fsharding-metrics-prometheus%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fmetrics%2Fprometheus%2FPrometheusMetricsTrackerManager.java#L36) | 0 | 7 | 0.0%
   <!-- | **Total:** | **56** | **118** | **47.46%** | -->
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/strategy/algorithm/sharding/inline/InlineShardingAlgorithm.java](https://coveralls.io/builds/30454031/source?filename=sharding-core%2Fsharding-core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fcore%2Fstrategy%2Falgorithm%2Fsharding%2Finline%2FInlineShardingAlgorithm.java#L55) | 5 | 58.82% |
   <!-- | **Total:** | **5** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/30454031/badge)](https://coveralls.io/builds/30454031) |
   | :-- | --: |
   | Change from base [Build 11349](https://coveralls.io/builds/30426921): |  -0.05% |
   | Covered Lines: | 11975 |
   | Relevant Lines: | 20836 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org