[GitHub] [flink] godfreyhe commented on a change in pull request #11671: [FLINK-17052] [client] Introduce PlanGenerator

[GitBox <gi...@apache.org>]

godfreyhe commented on a change in pull request #11671: [FLINK-17052] [client] Introduce PlanGenerator
URL: https://github.com/apache/flink/pull/11671#discussion_r406122262
 
 

 ##########
 File path: flink-java/src/main/java/org/apache/flink/api/java/ExecutionEnvironment.java
 ##########
 @@ -1035,6 +1030,14 @@ protected void registerCachedFilesWithPlan(Plan p) throws IOException {
 		}
 	}
 
+	/**
 
 Review comment:
   consider the following user table program:
   val env = ExecutionEnvironment.getExecutionEnvironment()
   val tableEnv = BatchTableEnvironment.create(env, config)
   env.registerCachedFile("/tmp/cache", "my_cache")
   val input = env.fromElements(...)...
   tEnv.fromDataSet(input)...
   tEnv.execute() // will generate plan through PlanGenerator in this method
   
   If we do not expose this method, the generated plan does not contain the cache files registered in DataSet program.(which can be converted to Table through `BatchTableEnvironment.fromDataSet` method)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services