You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "dhruba borthakur (JIRA)" <ji...@apache.org> on 2009/11/09 08:33:32 UTC
[jira] Created: (HDFS-756) libhdfs unit tests do not run
libhdfs unit tests do not run
------------------------------
Key: HDFS-756
URL: https://issues.apache.org/jira/browse/HDFS-756
Project: Hadoop HDFS
Issue Type: Bug
Components: contrib/libhdfs
Reporter: dhruba borthakur
Fix For: 0.22.0
The libhdfs unit tests (ant test-c++-libhdfs -Dislibhdfs=1) do not run yet because the scripts are in the common subproject,
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-756) libhdfs unit tests do not run
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12777833#action_12777833 ]
Konstantin Boudnik commented on HDFS-756:
-----------------------------------------
I'd suggest to raise the priority on this, because it makes full build {{ant test}} to fail all the time.
> libhdfs unit tests do not run
> ------------------------------
>
> Key: HDFS-756
> URL: https://issues.apache.org/jira/browse/HDFS-756
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: contrib/libhdfs
> Reporter: dhruba borthakur
> Assignee: Eli Collins
> Fix For: 0.22.0
>
>
> The libhdfs unit tests (ant test-c++-libhdfs -Dislibhdfs=1) do not run yet because the scripts are in the common subproject,
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-756) libhdfs unit tests do not run
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12780322#action_12780322 ]
Eli Collins commented on HDFS-756:
----------------------------------
You need to apply the patch from HDFS-727 first. That's patch is ready to go just need a comitter to commit it.
> libhdfs unit tests do not run
> ------------------------------
>
> Key: HDFS-756
> URL: https://issues.apache.org/jira/browse/HDFS-756
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: contrib/libhdfs
> Reporter: dhruba borthakur
> Assignee: Eli Collins
> Priority: Critical
> Fix For: 0.22.0
>
> Attachments: hdfs-756-2.patch, hdfs-756.patch, log
>
>
> The libhdfs unit tests (ant test-c++-libhdfs -Dislibhdfs=1) do not run yet because the scripts are in the common subproject,
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-756) libhdfs unit tests do not run
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12778733#action_12778733 ]
Hadoop QA commented on HDFS-756:
--------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12425177/hdfs-756.patch
against trunk revision 881017.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 13 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/116/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/116/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/116/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/116/console
This message is automatically generated.
> libhdfs unit tests do not run
> ------------------------------
>
> Key: HDFS-756
> URL: https://issues.apache.org/jira/browse/HDFS-756
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: contrib/libhdfs
> Reporter: dhruba borthakur
> Assignee: Eli Collins
> Priority: Critical
> Fix For: 0.22.0
>
> Attachments: hdfs-756.patch
>
>
> The libhdfs unit tests (ant test-c++-libhdfs -Dislibhdfs=1) do not run yet because the scripts are in the common subproject,
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HDFS-756) libhdfs unit tests do not run
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated HDFS-756:
-----------------------------
Attachment: hdfs-756.patch
Patch attached. The project split means the libhdfs test needs to access both the hdfs and common respos. The test lives in and is run out of the hdfs repo, however it runs an instance of hdfs, and therefore needs access to the common repo's bin directory. test-libhdfs.sh runs the hdfs instance out of the common repo (build/test/libhdfs and sub-directories get created there) since hadoop-daemon.sh makes doing otherwise a pain.
*This means the test now requires setting HADOOP_CORE_HOME.* Once HDFS-621 is checked in it would be nice to convert this test to run a MiniDFS cluster and no longer depend on a common repo. It doesn't seem like running one-daemon per process using the traditional startup scripts adds much additional coverage. Reasonable?
To run the test:
{{export HADOOP_CORE_HOME=<common repo dir>}}
{{ant -Dcompile.c\+\+=true -Dlibhdfs=true test-c\+\+-libhdfs}}
You may need to ant clean your common directory to remove old hdfs jar files in the root directory, build/ivy or the lib dirs.
> libhdfs unit tests do not run
> ------------------------------
>
> Key: HDFS-756
> URL: https://issues.apache.org/jira/browse/HDFS-756
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: contrib/libhdfs
> Reporter: dhruba borthakur
> Assignee: Eli Collins
> Priority: Critical
> Fix For: 0.22.0
>
> Attachments: hdfs-756.patch
>
>
> The libhdfs unit tests (ant test-c++-libhdfs -Dislibhdfs=1) do not run yet because the scripts are in the common subproject,
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HDFS-756) libhdfs unit tests do not run
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Boudnik updated HDFS-756:
------------------------------------
Affects Version/s: 0.22.0
> libhdfs unit tests do not run
> ------------------------------
>
> Key: HDFS-756
> URL: https://issues.apache.org/jira/browse/HDFS-756
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: contrib/libhdfs
> Affects Versions: 0.22.0
> Reporter: dhruba borthakur
> Assignee: Eli Collins
> Priority: Critical
> Fix For: 0.22.0
>
> Attachments: hdfs-756-2.patch, hdfs-756.patch, log
>
>
> The libhdfs unit tests (ant test-c++-libhdfs -Dislibhdfs=1) do not run yet because the scripts are in the common subproject,
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-756) libhdfs unit tests do not run
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12778711#action_12778711 ]
Konstantin Boudnik commented on HDFS-756:
-----------------------------------------
I don't think a dependency on a Common workspace is the very plausible idea. For once, it will affect Hudson's configurations and will introduce an inter-build dependencies there.
I believe a better way is to rely on the content of hadoop-core SNAPSHOT file which includes all bin/ scripts in it packed into bin.tgz file. What has to be done is to create a temp directory to unpack said bin.tgz file and then use it for the purpose of the test.
This approach will allow to make the test self-sufficient and avoid having potentially harmful dependencies.
> libhdfs unit tests do not run
> ------------------------------
>
> Key: HDFS-756
> URL: https://issues.apache.org/jira/browse/HDFS-756
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: contrib/libhdfs
> Reporter: dhruba borthakur
> Assignee: Eli Collins
> Priority: Critical
> Fix For: 0.22.0
>
> Attachments: hdfs-756.patch
>
>
> The libhdfs unit tests (ant test-c++-libhdfs -Dislibhdfs=1) do not run yet because the scripts are in the common subproject,
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HDFS-756) libhdfs unit tests do not run
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated HDFS-756:
-----------------------------
Status: Patch Available (was: Open)
> libhdfs unit tests do not run
> ------------------------------
>
> Key: HDFS-756
> URL: https://issues.apache.org/jira/browse/HDFS-756
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: contrib/libhdfs
> Reporter: dhruba borthakur
> Assignee: Eli Collins
> Priority: Critical
> Fix For: 0.22.0
>
> Attachments: hdfs-756-2.patch, hdfs-756.patch
>
>
> The libhdfs unit tests (ant test-c++-libhdfs -Dislibhdfs=1) do not run yet because the scripts are in the common subproject,
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-756) libhdfs unit tests do not run
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12779242#action_12779242 ]
Eli Collins commented on HDFS-756:
----------------------------------
Hey Konstantin -- Thanks for the feedback. Using the snapshot jar should work and removes the dependency on a common repo. Since the snapshot jar is updated from maven this approach will still work if you've also got changes in a common repo that should be used when running the test. If people are OK with that I'll update the patch. Per the above though I think this patch should be temporary, what do you think about converting this test to run a MiniDFS cluster (once HDFS-621 is in) and have a separate end-to-end test?
> libhdfs unit tests do not run
> ------------------------------
>
> Key: HDFS-756
> URL: https://issues.apache.org/jira/browse/HDFS-756
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: contrib/libhdfs
> Reporter: dhruba borthakur
> Assignee: Eli Collins
> Priority: Critical
> Fix For: 0.22.0
>
> Attachments: hdfs-756.patch
>
>
> The libhdfs unit tests (ant test-c++-libhdfs -Dislibhdfs=1) do not run yet because the scripts are in the common subproject,
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HDFS-756) libhdfs unit tests do not run
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Boudnik updated HDFS-756:
------------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I've just committed this. Thanks Eli.
> libhdfs unit tests do not run
> ------------------------------
>
> Key: HDFS-756
> URL: https://issues.apache.org/jira/browse/HDFS-756
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: contrib/libhdfs
> Affects Versions: 0.22.0
> Reporter: dhruba borthakur
> Assignee: Eli Collins
> Priority: Critical
> Fix For: 0.22.0
>
> Attachments: hdfs-756-2.patch, hdfs-756.patch, log
>
>
> The libhdfs unit tests (ant test-c++-libhdfs -Dislibhdfs=1) do not run yet because the scripts are in the common subproject,
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-756) libhdfs unit tests do not run
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12780164#action_12780164 ]
Eli Collins commented on HDFS-756:
----------------------------------
That last part should have read "the tests fails because it can not find the scripts to start the daemons". Sorry for the noise.
> libhdfs unit tests do not run
> ------------------------------
>
> Key: HDFS-756
> URL: https://issues.apache.org/jira/browse/HDFS-756
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: contrib/libhdfs
> Reporter: dhruba borthakur
> Assignee: Eli Collins
> Priority: Critical
> Fix For: 0.22.0
>
> Attachments: hdfs-756-2.patch, hdfs-756.patch
>
>
> The libhdfs unit tests (ant test-c++-libhdfs -Dislibhdfs=1) do not run yet because the scripts are in the common subproject,
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HDFS-756) libhdfs unit tests do not run
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated HDFS-756:
-----------------------------
Priority: Critical (was: Major)
Agreed, I'll have a patch out soon.
> libhdfs unit tests do not run
> ------------------------------
>
> Key: HDFS-756
> URL: https://issues.apache.org/jira/browse/HDFS-756
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: contrib/libhdfs
> Reporter: dhruba borthakur
> Assignee: Eli Collins
> Priority: Critical
> Fix For: 0.22.0
>
>
> The libhdfs unit tests (ant test-c++-libhdfs -Dislibhdfs=1) do not run yet because the scripts are in the common subproject,
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HDFS-756) libhdfs unit tests do not run
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated HDFS-756:
-----------------------------
Attachment: hdfs-756-2.patch
Here's an updated patch that creates the bin directory from the core jar. The config scripts in the bin directory assume the bin directory is named "bin" and that it lives in the hadoop home directory, so that's where the test scripts extracts it. The test script does not clobber a bin directory if it already exists, which I tested by creating an empty bin directory and checking that the tests fail because they can find the scripts to start the daemons. The tests pass after applying the patch from HDFS-727.
> libhdfs unit tests do not run
> ------------------------------
>
> Key: HDFS-756
> URL: https://issues.apache.org/jira/browse/HDFS-756
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: contrib/libhdfs
> Reporter: dhruba borthakur
> Assignee: Eli Collins
> Priority: Critical
> Fix For: 0.22.0
>
> Attachments: hdfs-756-2.patch, hdfs-756.patch
>
>
> The libhdfs unit tests (ant test-c++-libhdfs -Dislibhdfs=1) do not run yet because the scripts are in the common subproject,
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HDFS-756) libhdfs unit tests do not run
Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
dhruba borthakur updated HDFS-756:
----------------------------------
Status: Open (was: Patch Available)
Let's use the snapshot jar for now.
> libhdfs unit tests do not run
> ------------------------------
>
> Key: HDFS-756
> URL: https://issues.apache.org/jira/browse/HDFS-756
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: contrib/libhdfs
> Reporter: dhruba borthakur
> Assignee: Eli Collins
> Priority: Critical
> Fix For: 0.22.0
>
> Attachments: hdfs-756.patch
>
>
> The libhdfs unit tests (ant test-c++-libhdfs -Dislibhdfs=1) do not run yet because the scripts are in the common subproject,
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-756) libhdfs unit tests do not run
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12781920#action_12781920 ]
Hudson commented on HDFS-756:
-----------------------------
Integrated in Hadoop-Hdfs-trunk #150 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk/150/])
> libhdfs unit tests do not run
> ------------------------------
>
> Key: HDFS-756
> URL: https://issues.apache.org/jira/browse/HDFS-756
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: contrib/libhdfs
> Affects Versions: 0.22.0
> Reporter: dhruba borthakur
> Assignee: Eli Collins
> Priority: Critical
> Fix For: 0.22.0
>
> Attachments: hdfs-756-2.patch, hdfs-756.patch, log
>
>
> The libhdfs unit tests (ant test-c++-libhdfs -Dislibhdfs=1) do not run yet because the scripts are in the common subproject,
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HDFS-756) libhdfs unit tests do not run
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated HDFS-756:
-----------------------------
Status: Patch Available (was: Open)
> libhdfs unit tests do not run
> ------------------------------
>
> Key: HDFS-756
> URL: https://issues.apache.org/jira/browse/HDFS-756
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: contrib/libhdfs
> Reporter: dhruba borthakur
> Assignee: Eli Collins
> Priority: Critical
> Fix For: 0.22.0
>
> Attachments: hdfs-756.patch
>
>
> The libhdfs unit tests (ant test-c++-libhdfs -Dislibhdfs=1) do not run yet because the scripts are in the common subproject,
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-756) libhdfs unit tests do not run
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12779239#action_12779239 ]
Konstantin Boudnik commented on HDFS-756:
-----------------------------------------
Slightly different modification of the proposal above is to have all needed scripts checked in along with the test.
Also, I feel kind of uncomfortable with such a 'end-to-end' test to be executed as a part of what is essentially unit/functional validation. Shall we move it to a integration test suite or something?
> libhdfs unit tests do not run
> ------------------------------
>
> Key: HDFS-756
> URL: https://issues.apache.org/jira/browse/HDFS-756
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: contrib/libhdfs
> Reporter: dhruba borthakur
> Assignee: Eli Collins
> Priority: Critical
> Fix For: 0.22.0
>
> Attachments: hdfs-756.patch
>
>
> The libhdfs unit tests (ant test-c++-libhdfs -Dislibhdfs=1) do not run yet because the scripts are in the common subproject,
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-756) libhdfs unit tests do not run
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12780810#action_12780810 ]
Hudson commented on HDFS-756:
-----------------------------
Integrated in Hadoop-Hdfs-trunk-Commit #118 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/118/])
. libhdfs unit tests do not run. (Eli Collins via cos).
> libhdfs unit tests do not run
> ------------------------------
>
> Key: HDFS-756
> URL: https://issues.apache.org/jira/browse/HDFS-756
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: contrib/libhdfs
> Affects Versions: 0.22.0
> Reporter: dhruba borthakur
> Assignee: Eli Collins
> Priority: Critical
> Fix For: 0.22.0
>
> Attachments: hdfs-756-2.patch, hdfs-756.patch, log
>
>
> The libhdfs unit tests (ant test-c++-libhdfs -Dislibhdfs=1) do not run yet because the scripts are in the common subproject,
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-756) libhdfs unit tests do not run
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12785751#action_12785751 ]
Hudson commented on HDFS-756:
-----------------------------
Integrated in Hdfs-Patch-h2.grid.sp2.yahoo.net #81 (See [http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/81/])
> libhdfs unit tests do not run
> ------------------------------
>
> Key: HDFS-756
> URL: https://issues.apache.org/jira/browse/HDFS-756
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: contrib/libhdfs
> Affects Versions: 0.22.0
> Reporter: dhruba borthakur
> Assignee: Eli Collins
> Priority: Critical
> Fix For: 0.22.0
>
> Attachments: hdfs-756-2.patch, hdfs-756.patch, log
>
>
> The libhdfs unit tests (ant test-c++-libhdfs -Dislibhdfs=1) do not run yet because the scripts are in the common subproject,
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-756) libhdfs unit tests do not run
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12780852#action_12780852 ]
Hudson commented on HDFS-756:
-----------------------------
Integrated in Hdfs-Patch-h5.grid.sp2.yahoo.net #121 (See [http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/121/])
. libhdfs unit tests do not run. (Eli Collins via cos).
> libhdfs unit tests do not run
> ------------------------------
>
> Key: HDFS-756
> URL: https://issues.apache.org/jira/browse/HDFS-756
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: contrib/libhdfs
> Affects Versions: 0.22.0
> Reporter: dhruba borthakur
> Assignee: Eli Collins
> Priority: Critical
> Fix For: 0.22.0
>
> Attachments: hdfs-756-2.patch, hdfs-756.patch, log
>
>
> The libhdfs unit tests (ant test-c++-libhdfs -Dislibhdfs=1) do not run yet because the scripts are in the common subproject,
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HDFS-756) libhdfs unit tests do not run
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins reassigned HDFS-756:
--------------------------------
Assignee: Eli Collins
> libhdfs unit tests do not run
> ------------------------------
>
> Key: HDFS-756
> URL: https://issues.apache.org/jira/browse/HDFS-756
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: contrib/libhdfs
> Reporter: dhruba borthakur
> Assignee: Eli Collins
> Fix For: 0.22.0
>
>
> The libhdfs unit tests (ant test-c++-libhdfs -Dislibhdfs=1) do not run yet because the scripts are in the common subproject,
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-756) libhdfs unit tests do not run
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12780391#action_12780391 ]
Konstantin Boudnik commented on HDFS-756:
-----------------------------------------
bq. You need to apply the patch from HDFS-727 first
yup, my bad. everything seems to be working.
+1 patch looks good
> libhdfs unit tests do not run
> ------------------------------
>
> Key: HDFS-756
> URL: https://issues.apache.org/jira/browse/HDFS-756
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: contrib/libhdfs
> Reporter: dhruba borthakur
> Assignee: Eli Collins
> Priority: Critical
> Fix For: 0.22.0
>
> Attachments: hdfs-756-2.patch, hdfs-756.patch, log
>
>
> The libhdfs unit tests (ant test-c++-libhdfs -Dislibhdfs=1) do not run yet because the scripts are in the common subproject,
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-756) libhdfs unit tests do not run
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12779246#action_12779246 ]
Eli Collins commented on HDFS-756:
----------------------------------
I'd prefer using the snapshot jar instead of duplicating the scripts, we're going to require the snapshot jar anyway to execute.
> libhdfs unit tests do not run
> ------------------------------
>
> Key: HDFS-756
> URL: https://issues.apache.org/jira/browse/HDFS-756
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: contrib/libhdfs
> Reporter: dhruba borthakur
> Assignee: Eli Collins
> Priority: Critical
> Fix For: 0.22.0
>
> Attachments: hdfs-756.patch
>
>
> The libhdfs unit tests (ant test-c++-libhdfs -Dislibhdfs=1) do not run yet because the scripts are in the common subproject,
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HDFS-756) libhdfs unit tests do not run
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Boudnik updated HDFS-756:
------------------------------------
Attachment: log
The patch seems Ok. However, test is failing on my linux box (see the log file)
> libhdfs unit tests do not run
> ------------------------------
>
> Key: HDFS-756
> URL: https://issues.apache.org/jira/browse/HDFS-756
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: contrib/libhdfs
> Reporter: dhruba borthakur
> Assignee: Eli Collins
> Priority: Critical
> Fix For: 0.22.0
>
> Attachments: hdfs-756-2.patch, hdfs-756.patch, log
>
>
> The libhdfs unit tests (ant test-c++-libhdfs -Dislibhdfs=1) do not run yet because the scripts are in the common subproject,
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-756) libhdfs unit tests do not run
Posted by "Konstantin Boudnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12779520#action_12779520 ]
Konstantin Boudnik commented on HDFS-756:
-----------------------------------------
bq. I think this patch should be temporary, what do you think about converting this test to run a MiniDFS cluster (once HDFS-621 is in) and have a separate end-to-end test?
I think this is a very good idea!
> libhdfs unit tests do not run
> ------------------------------
>
> Key: HDFS-756
> URL: https://issues.apache.org/jira/browse/HDFS-756
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: contrib/libhdfs
> Reporter: dhruba borthakur
> Assignee: Eli Collins
> Priority: Critical
> Fix For: 0.22.0
>
> Attachments: hdfs-756.patch
>
>
> The libhdfs unit tests (ant test-c++-libhdfs -Dislibhdfs=1) do not run yet because the scripts are in the common subproject,
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-756) libhdfs unit tests do not run
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12780238#action_12780238 ]
Hadoop QA commented on HDFS-756:
--------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12425498/hdfs-756-2.patch
against trunk revision 881695.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/119/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/119/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/119/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/119/console
This message is automatically generated.
> libhdfs unit tests do not run
> ------------------------------
>
> Key: HDFS-756
> URL: https://issues.apache.org/jira/browse/HDFS-756
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: contrib/libhdfs
> Reporter: dhruba borthakur
> Assignee: Eli Collins
> Priority: Critical
> Fix For: 0.22.0
>
> Attachments: hdfs-756-2.patch, hdfs-756.patch
>
>
> The libhdfs unit tests (ant test-c++-libhdfs -Dislibhdfs=1) do not run yet because the scripts are in the common subproject,
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.