You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/07/29 02:53:40 UTC
[GitHub] [rocketmq] Cczzzz opened a new issue, #4720: When the broker master fails，return timeout，Client will not retry.
Cczzzz opened a new issue, #4720:
URL: https://github.com/apache/rocketmq/issues/4720
**BUG REPORT**
1. Please describe the issue you observed:
- What did you do (The steps to reproduce)?
- While sending, kill master
- What is expected to see?
- send error, timeout
- What did you see instead?
- timeout
When the broker master fails，Clients cannot choose to send to other broker masters。
When the broker master fails，return timeout，Client will not retry。
This is because the first occurrence of the client consumes all the timeout。when return timeout ，The client will consume all timeouts.No time left to retry
DefaultMQProducerImpl# 607
sendResult = this.sendKernelImpl(msg, mq, communicationMode, sendCallback, topicPublishInfo, timeout - costTime);
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] Cczzzz commented on issue #4720: When the broker master fails，return timeout，Client will not retry.
Posted by GitBox <gi...@apache.org>.
Cczzzz commented on issue #4720:
URL: https://github.com/apache/rocketmq/issues/4720#issuecomment-1202174042
When I set the timeout to 10s, it still cannot be retried correctly.
2022-08-02 16:22:05,917 WARN RocketmqClient - sendKernelImpl exception, resend at once, InvokeID: -2111425297163537192, RT: 10015ms, Broker: MessageQueue [topic=CONNECT, brokerName=broker-c, queueId=0]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] lizhanhui commented on issue #4720: When the broker master fails，return timeout，Client will not retry.
Posted by GitBox <gi...@apache.org>.
lizhanhui commented on issue #4720:
URL: https://github.com/apache/rocketmq/issues/4720#issuecomment-1211523072
Finally, this issue is raised again.
IMO, the retry strategy on the client side needs significant refinement. I suggest creating a RIP to improve this. We need something similar to what gRPC-client-retry strategy https://github.com/grpc/proposal/blob/master/A6-client-retries.md
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] Cczzzz commented on issue #4720: When the broker master fails，return timeout，Client will not retry.
Posted by GitBox <gi...@apache.org>.
Cczzzz commented on issue #4720:
URL: https://github.com/apache/rocketmq/issues/4720#issuecomment-1204798236
> #3555 @Cczzzz Verify that this PR solves this issue
@duhenglucky no,is different
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] Cczzzz commented on issue #4720: When the broker master fails，return timeout，Client will not retry.
Posted by GitBox <gi...@apache.org>.
Cczzzz commented on issue #4720:
URL: https://github.com/apache/rocketmq/issues/4720#issuecomment-1203397994
no,is different
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] github-actions[bot] commented on issue #4720: When the broker master fails，return timeout，Client will not retry.
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #4720:
URL: https://github.com/apache/rocketmq/issues/4720#issuecomment-1678251458
This issue was closed because it has been inactive for 3 days since being marked as stale.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] SeaItFover commented on issue #4720: When the broker master fails，return timeout，Client will not retry.
Posted by GitBox <gi...@apache.org>.
SeaItFover commented on issue #4720:
URL: https://github.com/apache/rocketmq/issues/4720#issuecomment-1200335562
> **BUG REPORT**
>
> 1. Please describe the issue you observed:
>
> * What did you do (The steps to reproduce)?
> * While sending, kill master
> * What is expected to see?
> * The client does not report an error
> * What did you see instead?
> * send error, timeout
>
> When the broker master fails，Clients cannot choose to send to other broker masters。 When the broker master fails，return timeout，Client will not retry。 This is because the first occurrence of the client consumes all the timeout。when return timeout ，The client will consume all timeouts.No time left to retry
>
> DefaultMQProducerImpl# 607 sendResult = this.sendKernelImpl(msg, mq, communicationMode, sendCallback, topicPublishInfo, timeout - costTime);
I dont think this is a bug, in sync mode, the argument of timout is provided by the application layer, total retry timeout consume the timeout together. In async mode, only retry once.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] panzhi33 commented on issue #4720: When the broker master fails，return timeout，Client will not retry.
Posted by GitBox <gi...@apache.org>.
panzhi33 commented on issue #4720:
URL: https://github.com/apache/rocketmq/issues/4720#issuecomment-1204899388
This is because the first send exceeds the set timeout, so it will not continue to retry. I think this restriction should be removed and the timeout should be recalculated when retrying
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] duhenglucky commented on issue #4720: When the broker master fails，return timeout，Client will not retry.
Posted by GitBox <gi...@apache.org>.
duhenglucky commented on issue #4720:
URL: https://github.com/apache/rocketmq/issues/4720#issuecomment-1202227663
https://github.com/apache/rocketmq/pull/3555 @Cczzzz Verify that this PR solves this issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] Cczzzz commented on issue #4720: When the broker master fails，return timeout，Client will not retry.
Posted by GitBox <gi...@apache.org>.
Cczzzz commented on issue #4720:
URL: https://github.com/apache/rocketmq/issues/4720#issuecomment-1202157957
It will cause the client to fail when the master goes down.is this reasonable？I always thought the client was insensitive
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] github-actions[bot] commented on issue #4720: When the broker master fails，return timeout，Client will not retry.
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #4720:
URL: https://github.com/apache/rocketmq/issues/4720#issuecomment-1675547390
This issue is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] github-actions[bot] closed issue #4720: When the broker master fails，return timeout，Client will not retry.
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed issue #4720: When the broker master fails，return timeout，Client will not retry.
URL: https://github.com/apache/rocketmq/issues/4720
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org