You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ant.apache.org by bo...@apache.org on 2014/07/19 20:00:53 UTC

git commit: try to make spawn test pass in Jenkins by using a bigger security margin

Repository: ant
Updated Branches:
  refs/heads/master 66c2551a5 -> 9eb4c3a9a


try to make spawn test pass in Jenkins by using a bigger security margin


Project: http://git-wip-us.apache.org/repos/asf/ant/repo
Commit: http://git-wip-us.apache.org/repos/asf/ant/commit/9eb4c3a9
Tree: http://git-wip-us.apache.org/repos/asf/ant/tree/9eb4c3a9
Diff: http://git-wip-us.apache.org/repos/asf/ant/diff/9eb4c3a9

Branch: refs/heads/master
Commit: 9eb4c3a9a00c2062a02a7f064df983625c93a9bd
Parents: 66c2551
Author: Stefan Bodewig <bo...@apache.org>
Authored: Sat Jul 19 20:00:34 2014 +0200
Committer: Stefan Bodewig <bo...@apache.org>
Committed: Sat Jul 19 20:00:34 2014 +0200

----------------------------------------------------------------------
 .../junit/org/apache/tools/ant/taskdefs/ExecTaskTest.java    | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/ant/blob/9eb4c3a9/src/tests/junit/org/apache/tools/ant/taskdefs/ExecTaskTest.java
----------------------------------------------------------------------
diff --git a/src/tests/junit/org/apache/tools/ant/taskdefs/ExecTaskTest.java b/src/tests/junit/org/apache/tools/ant/taskdefs/ExecTaskTest.java
index 49135cf..aede740 100644
--- a/src/tests/junit/org/apache/tools/ant/taskdefs/ExecTaskTest.java
+++ b/src/tests/junit/org/apache/tools/ant/taskdefs/ExecTaskTest.java
@@ -48,9 +48,9 @@ public class ExecTaskTest {
     private static final int TIME_TO_WAIT = 1;
     /** maximum time allowed for the build in milliseconds */
     private static final int MAX_BUILD_TIME = 4000;
-    private static final int SECURITY_MARGIN = 2000; // wait 2 second extras
-    // the test failed with 100 ms of margin on cvs.apache.org on August 1st,
-    // 2003
+    private static final int SECURITY_MARGIN = 3000; // wait 3 second extras
+    // the test failed with 100 ms of margin on cvs.apache.org on August 1st, 2003
+    // the test failed with 2 s of margin on Windows Jenkins slaves on during July 2014
 
     /** Utilities used for file operations */
     private static final FileUtils FILE_UTILS = FileUtils.getFileUtils();
@@ -74,7 +74,7 @@ public class ExecTaskTest {
                 false, false);
         // this is guaranteed by FileUtils#createTempFile
         assertTrue("log file not existing", !logFile.exists());
-        // make the spawned process run 4 seconds
+        // make the spawned process run 1 seconds
         myBuild.setTimeToWait(TIME_TO_WAIT);
         myBuild.setLogFile(logFile.getAbsolutePath());
         myBuild.addBuildListener(new MonitoredBuildListener());