You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2020/04/20 15:22:36 UTC

[GitHub] [calcite] hsyuan commented on a change in pull request #1912: [CALCITE-3889] Add apply(Mappings.Mapping) to RelTrait and RelTraitSet

hsyuan commented on a change in pull request #1912:
URL: https://github.com/apache/calcite/pull/1912#discussion_r411467170



##########
File path: core/src/main/java/org/apache/calcite/plan/RelTrait.java
##########
@@ -85,4 +87,14 @@
    * @param planner Planner
    */
   void register(RelOptPlanner planner);
+
+  /**
+   * Applies a mapping to this trait.
+   *
+   * @param mapping   Mapping
+   * @return trait with mapping applied
+   */
+  default <T extends RelTrait> T apply(Mappings.TargetMapping mapping) {

Review comment:
       Can I have your use cases?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org