You are viewing a plain text version of this content. The canonical link for it is here.
Posted to ojb-dev@db.apache.org by Antonio Gallardo <ag...@agsoftware.dnsalias.com> on 2004/01/26 02:39:03 UTC
Upgrade to commons-collections 3.0?
Hi:
Apache commons-collection-3.0.jar is out. Can we upgrade to them?
http://jakarta.apache.org/site/news.html#20040125.1
I already compiled OJB with this new version.
Best Regards,
Antonio Gallardo
---------------------------------------------------------------------
To unsubscribe, e-mail: ojb-dev-unsubscribe@db.apache.org
For additional commands, e-mail: ojb-dev-help@db.apache.org
Re: Upgrade to commons-collections 3.0?
Posted by Antonio Gallardo <ag...@agsoftware.dnsalias.com>.
Armin Waibel dijo:
> Hi,
>
> the question is, were do we use commons-collection in OJB
> (OJB main classes)?
> There is currently one class using commons-collection:
> PersistentFieldAutoProxyImpl
> This class using FastHashMap. FastHashMap should be 2.x/3.x compatible,
> because there was no package renaming for this class. So, OJB runtime
> jar should work with both versions of commons-collection.
AFAIK, the FastHashMap was improved and some bug fixed (maybe not in our
unique FastHashMap used by OJB). I suppose we can start using the new jar
and tell that the old version is OK too. That way we start to promote the
use of the new jar.
Is this OK?
Best Regards,
Antonio Gallardo
>
> I propose to upgrade when most other popular projects (Torque, XDoclet,
> Tomcat, Struts?, ...) use new commons-collection version (to avoid
> side-effects with these used libraries).
>
> In any case I propose to add a note in release notes, says that OJB is
> compatible with both versions.
>
> regards,
> Armin
>
> Antonio Gallardo wrote:
>> Thomas Dudziak dijo:
>>
>>>I would be extra careful with changing the commons stuff. There's a lot
>>> of
>>>projects using them (e.g. Torque, Tomcat (?), XDoclet), so we should
>>> check
>>>whether there are any signifcant changes (there should be a reason that
>>> is
>>>a new major version number), and how they affect not only OJB but also
>>>these other projects.
>>
>>
>> Hi Thomas:
>>
>> I understand your concerns. If this help, I can said, it is already
>> running in Tomcat 4.1.29 and Cocoon 2.1.4-dev and no problems reported
>> at
>> all.
>>
>> Best Regards,
>>
>> Antonio Gallardo
---------------------------------------------------------------------
To unsubscribe, e-mail: ojb-dev-unsubscribe@db.apache.org
For additional commands, e-mail: ojb-dev-help@db.apache.org
Re: Upgrade to commons-collections 3.0?
Posted by Brian McCallister <mc...@forthillcompany.com>.
If that is the only place using it than something is weird as I wrote
that class and *know* I didn't add any jar's then (wasn't a committer).
Let's see if we can just remove commons-collections if this is the
case.
-Brian
On Jan 27, 2004, at 5:12 AM, Armin Waibel wrote:
> Hi,
>
> the question is, were do we use commons-collection in OJB
> (OJB main classes)?
> There is currently one class using commons-collection:
> PersistentFieldAutoProxyImpl
> This class using FastHashMap. FastHashMap should be 2.x/3.x
> compatible, because there was no package renaming for this class. So,
> OJB runtime jar should work with both versions of commons-collection.
>
> I propose to upgrade when most other popular projects (Torque,
> XDoclet, Tomcat, Struts?, ...) use new commons-collection version (to
> avoid side-effects with these used libraries).
>
> In any case I propose to add a note in release notes, says that OJB is
> compatible with both versions.
>
> regards,
> Armin
>
> Antonio Gallardo wrote:
>> Thomas Dudziak dijo:
>>> I would be extra careful with changing the commons stuff. There's a
>>> lot of
>>> projects using them (e.g. Torque, Tomcat (?), XDoclet), so we should
>>> check
>>> whether there are any signifcant changes (there should be a reason
>>> that is
>>> a new major version number), and how they affect not only OJB but
>>> also
>>> these other projects.
>> Hi Thomas:
>> I understand your concerns. If this help, I can said, it is already
>> running in Tomcat 4.1.29 and Cocoon 2.1.4-dev and no problems
>> reported at
>> all.
>> Best Regards,
>> Antonio Gallardo
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: ojb-dev-unsubscribe@db.apache.org
>> For additional commands, e-mail: ojb-dev-help@db.apache.org
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: ojb-dev-unsubscribe@db.apache.org
> For additional commands, e-mail: ojb-dev-help@db.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: ojb-dev-unsubscribe@db.apache.org
For additional commands, e-mail: ojb-dev-help@db.apache.org
Re: Upgrade to commons-collections 3.0?
Posted by Armin Waibel <ar...@code-au-lait.de>.
Martin Poeschl wrote:
> i'll check torque .. we should also upgrade to use the torque generator
> 3.1 (as we don't need the torque runtime stuff)
+1
Armin
>
> martin
>
> Thomas Dudziak wrote:
>
>> I'll check xdoclet, and for torque and struts I'd suggest that somebody
>> who is subscribed to the developer (preferably) or user maling list asks
>> whether commons-collection.3 works.
>>
>> Tom
>>
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: ojb-dev-unsubscribe@db.apache.org
> For additional commands, e-mail: ojb-dev-help@db.apache.org
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: ojb-dev-unsubscribe@db.apache.org
For additional commands, e-mail: ojb-dev-help@db.apache.org
Re: Upgrade to commons-collections 3.0?
Posted by Thomas Dudziak <to...@first.gmd.de>.
I was wondering why we should upgrade to 3.0 in the first place as we're
neither requiring the new functionality nor are there any bug fixes
relevant to us. I think that instead we should stick to whichever
version is currently in use and put in the release notes or the FAQ a
paragraph about which versions of commonly used libraries OJB comes with
and which newer versions are also tested. This way anybody who wants
to/has to use a newer version can simply replace it.
Also we should have for any jar in the lib folder the version number in
the filename (e.g. commons-collections, commons-beanutils, p6spy etc.).
BTW, the XDoclet OJB module works with commons-collections 3.0.
On Wed, 28 Jan 2004, Martin Poeschl wrote:
> i'll check torque .. we should also upgrade to use the torque generator
> 3.1 (as we don't need the torque runtime stuff)
+1. I could try that later this week.
Tom
---------------------------------------------------------------------
To unsubscribe, e-mail: ojb-dev-unsubscribe@db.apache.org
For additional commands, e-mail: ojb-dev-help@db.apache.org
Re: Upgrade to commons-collections 3.0?
Posted by Martin Poeschl <mp...@marmot.at>.
i'll check torque .. we should also upgrade to use the torque generator
3.1 (as we don't need the torque runtime stuff)
martin
Thomas Dudziak wrote:
>I'll check xdoclet, and for torque and struts I'd suggest that somebody
>who is subscribed to the developer (preferably) or user maling list asks
>whether commons-collection.3 works.
>
>Tom
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: ojb-dev-unsubscribe@db.apache.org
For additional commands, e-mail: ojb-dev-help@db.apache.org
Re: Upgrade to commons-collections 3.0?
Posted by Thomas Dudziak <to...@first.gmd.de>.
I'll check xdoclet, and for torque and struts I'd suggest that somebody
who is subscribed to the developer (preferably) or user maling list asks
whether commons-collection.3 works.
Tom
---------------------------------------------------------------------
To unsubscribe, e-mail: ojb-dev-unsubscribe@db.apache.org
For additional commands, e-mail: ojb-dev-help@db.apache.org
Re: Upgrade to commons-collections 3.0?
Posted by Armin Waibel <ar...@code-au-lait.de>.
Hi,
the question is, were do we use commons-collection in OJB
(OJB main classes)?
There is currently one class using commons-collection:
PersistentFieldAutoProxyImpl
This class using FastHashMap. FastHashMap should be 2.x/3.x compatible,
because there was no package renaming for this class. So, OJB runtime
jar should work with both versions of commons-collection.
I propose to upgrade when most other popular projects (Torque, XDoclet,
Tomcat, Struts?, ...) use new commons-collection version (to avoid
side-effects with these used libraries).
In any case I propose to add a note in release notes, says that OJB is
compatible with both versions.
regards,
Armin
Antonio Gallardo wrote:
> Thomas Dudziak dijo:
>
>>I would be extra careful with changing the commons stuff. There's a lot of
>>projects using them (e.g. Torque, Tomcat (?), XDoclet), so we should check
>>whether there are any signifcant changes (there should be a reason that is
>>a new major version number), and how they affect not only OJB but also
>>these other projects.
>
>
> Hi Thomas:
>
> I understand your concerns. If this help, I can said, it is already
> running in Tomcat 4.1.29 and Cocoon 2.1.4-dev and no problems reported at
> all.
>
> Best Regards,
>
> Antonio Gallardo
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: ojb-dev-unsubscribe@db.apache.org
> For additional commands, e-mail: ojb-dev-help@db.apache.org
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: ojb-dev-unsubscribe@db.apache.org
For additional commands, e-mail: ojb-dev-help@db.apache.org
Re: Upgrade to commons-collections 3.0?
Posted by Antonio Gallardo <ag...@agsoftware.dnsalias.com>.
Thomas Dudziak dijo:
> I would be extra careful with changing the commons stuff. There's a lot of
> projects using them (e.g. Torque, Tomcat (?), XDoclet), so we should check
> whether there are any signifcant changes (there should be a reason that is
> a new major version number), and how they affect not only OJB but also
> these other projects.
Hi Thomas:
I understand your concerns. If this help, I can said, it is already
running in Tomcat 4.1.29 and Cocoon 2.1.4-dev and no problems reported at
all.
Best Regards,
Antonio Gallardo
---------------------------------------------------------------------
To unsubscribe, e-mail: ojb-dev-unsubscribe@db.apache.org
For additional commands, e-mail: ojb-dev-help@db.apache.org
Re: Upgrade to commons-collections 3.0?
Posted by Thomas Dudziak <to...@first.gmd.de>.
I would be extra careful with changing the commons stuff. There's a lot of
projects using them (e.g. Torque, Tomcat (?), XDoclet), so we should check
whether there are any signifcant changes (there should be a reason that is
a new major version number), and how they affect not only OJB but also
these other projects.
Tom
---------------------------------------------------------------------
To unsubscribe, e-mail: ojb-dev-unsubscribe@db.apache.org
For additional commands, e-mail: ojb-dev-help@db.apache.org
Re: Upgrade to commons-collections 3.0?
Posted by Brian McCallister <mc...@forthillcompany.com>.
+1 for switching, though we need to be careful.
iirc quite a few packages were rearranged. If they stayed true to form
the old ones will still exist and just be deprecated. We need to be
careful switching in order to make sure we don't break anyone's
applications a la dll hell. If Antonio was able to do a drop-in
replacement and get it to compile we are good to go, I think, even if
we require 3.0
-Brian
On Jan 25, 2004, at 8:39 PM, Antonio Gallardo wrote:
> Hi:
>
> Apache commons-collection-3.0.jar is out. Can we upgrade to them?
>
> http://jakarta.apache.org/site/news.html#20040125.1
>
> I already compiled OJB with this new version.
>
> Best Regards,
>
> Antonio Gallardo
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: ojb-dev-unsubscribe@db.apache.org
> For additional commands, e-mail: ojb-dev-help@db.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: ojb-dev-unsubscribe@db.apache.org
For additional commands, e-mail: ojb-dev-help@db.apache.org