You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@ratis.apache.org by GitBox <gi...@apache.org> on 2021/12/13 08:18:32 UTC

[GitHub] [ratis] Xushaohong commented on a change in pull request #560: RATIS-1446. Avoid leader election for invalid conf

Xushaohong commented on a change in pull request #560:
URL: https://github.com/apache/ratis/pull/560#discussion_r767493994



##########
File path: ratis-server/src/main/java/org/apache/ratis/server/impl/LeaderElection.java
##########
@@ -271,6 +272,9 @@ private boolean shouldRun(long electionTerm) {
 
   private ResultAndTerm submitRequestAndWaitResult(Phase phase, RaftConfigurationImpl conf, long electionTerm)
       throws InterruptedException {
+    if (!conf.containsInConf(server.getId()) && phase == Phase.ELECTION) {

Review comment:
       > We should fix the unit tests but not adding the phase check here.
   
   OK, let's find out what's wrong with UT




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org