[jira] [Commented] (ZOOKEEPER-1757) Adler32 may not be sufficient to protect against data corruption

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13766133#comment-13766133 ] 

Hadoop QA commented on ZOOKEEPER-1757:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12602925/ZOOKEEPER.1757.patch
  against trunk revision 1522079.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    -1 core tests.  The patch failed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1576//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1576//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1576//console

This message is automatically generated.
                
> Adler32 may not be sufficient to protect against data corruption
> ----------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1757
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1757
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: server
>         Environment: Linux.  Oracle JDK6/7
>            Reporter: Thawan Kooburat
>         Attachments: ZOOKEEPER.1757.patch, ZOOKEEPER.1757.patch
>
>
> I was investigating data inconsistency bug in our internal branch. One possible area is snapshot/txnlog corruption. So I wrote a more robust corruption test and found that it is easy to break our checksum algorithm which is Adler32.
> When this happen, it is more likely that corrupted data will fail other sanity check during deserialization phase, but it is still scary that it can pass the checksum.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira