You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@plc4x.apache.org by GitBox <gi...@apache.org> on 2018/09/19 06:44:28 UTC

[GitHub] sruehl commented on issue #23: Added note for Service Loader.

sruehl commented on issue #23: Added note for Service Loader.
URL: https://github.com/apache/incubator-plc4x/pull/23#issuecomment-422675552
 
 
   > @sruehl I noticed that I wasnt able to reference the PlcDriverManager as it is placed in core. So I suggest to extract an interface PlcDriverManager and to rename the implementation to DefaultPlcDriverManager.
   > The Interface is especially necessary for us to implement our proxy, as the PlcDriverManager can be used as an equivalent of the javax.sql Datasource.
   
   fair enough im just thinking if there would be a better way to retrieve the PlcDriverManager as to use the `DefaultPlcDriverManager`. Might confuse a Api User but im not sure what would be best though...

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services