[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #522: MINIFICPP-786 - GetFile processor doesn't seem to work with default c…

[GitBox <gi...@apache.org>]

arpadboda commented on a change in pull request #522: MINIFICPP-786 - GetFile processor doesn't seem to work with default c…
URL: https://github.com/apache/nifi-minifi-cpp/pull/522#discussion_r268620241
 
 

 ##########
 File path: libminifi/src/processors/GetFile.cpp
 ##########
 @@ -220,15 +219,14 @@ void GetFile::pollListing(std::queue<std::string> &list, const GetFileRequest &r
   std::lock_guard<std::mutex> lock(mutex_);
 
   while (!_dirList.empty() && (request.batchSize == 0 || list.size() < request.batchSize)) {
-    std::string fileName = _dirList.front();
+    list.push(_dirList.front());
     _dirList.pop();
-    list.push(fileName);
   }
-
-  return;
 }
 
 bool GetFile::acceptFile(std::string fullName, std::string name, const GetFileRequest &request) {
+  logger_->log_debug("Checking file: %s", fullName);
 
 Review comment:
   Makes sense, changed to trace, thanks!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services