You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by gallenvara <gi...@git.apache.org> on 2015/10/22 09:30:34 UTC

[GitHub] flink pull request: [FLINK-2890] [tests] Apply JMH on StringSerial...

GitHub user gallenvara opened a pull request:

    https://github.com/apache/flink/pull/1284

    [FLINK-2890] [tests] Apply JMH on StringSerializationSpeedBenchmark class.

    JMH is a Java harness for building, running, and analysing nano/micro/milli/macro benchmarks.Use JMH to replace the old micro benchmarks method in order to get much more accurate results.Modify the `StringSerializationSpeedBenchmark` class and move it to `flink-benchmark` module.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gallenvara/flink stringSerializationSpeed

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/1284.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1284
    
----
commit 4b7fb3da178fc1f2e1a4353949c5f8e42a7205b4
Author: gallenvara <ga...@126.com>
Date:   2015-10-22T06:35:11Z

    [FLINK-2890] [tests] Apply JMH on StringSerializationSpeedBenchmark class.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-2890] [tests] Apply JMH on StringSerial...

Posted by gallenvara <gi...@git.apache.org>.
Github user gallenvara commented on the pull request:

    https://github.com/apache/flink/pull/1284#issuecomment-150131741
  
    JMH result:
    ![stringserializationspeed](https://cloud.githubusercontent.com/assets/12931563/10659384/f944e136-78d1-11e5-87db-f7929818774d.PNG)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-2890] [tests] Apply JMH on StringSerial...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/1284


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-2890] [tests] Apply JMH on StringSerial...

Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the pull request:

    https://github.com/apache/flink/pull/1284#issuecomment-151208210
  
    I'm going to merge this PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---