You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2019/04/26 10:58:24 UTC
[GitHub] [cordova-windows] raphinesse opened a new pull request #330:
Conditionally skip the _one_ broken test for VS 2017 instead of allowing
the whole suite to fail
raphinesse opened a new pull request #330: Conditionally skip the _one_ broken test for VS 2017 instead of allowing the whole suite to fail
URL: https://github.com/apache/cordova-windows/pull/330
### Motivation and Context
<!-- Why is this change required? What problem does it solve? -->
<!-- If it fixes an open issue, please link to the issue here. -->
The CI tests on AppVeyor using VS 2017 were allowed to fail completely because of _one_ E2E test that is broken under these conditions. This is confusing and could mask any other broken tests.
### Description
<!-- Describe your changes in detail -->
Instead of allowing the whole suite to fail when using VS 2017, we only skip the known-bad tests when VS 2017 on AppVeyor is used.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org