You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Kihwal Lee (JIRA)" <ji...@apache.org> on 2012/11/14 16:36:12 UTC

[jira] [Created] (HADOOP-9037) Bug in test-patch.sh and precommit build process

Kihwal Lee created HADOOP-9037:
----------------------------------

             Summary: Bug in test-patch.sh and precommit build process
                 Key: HADOOP-9037
                 URL: https://issues.apache.org/jira/browse/HADOOP-9037
             Project: Hadoop Common
          Issue Type: Bug
          Components: build
    Affects Versions: 3.0.0
            Reporter: Kihwal Lee
            Priority: Critical


In HDFS-4171, the precommit build failed, but it still posted +1 for every category.  

{noformat}
======================================================================
======================================================================
    Running tests.
======================================================================
======================================================================


/home/jenkins/jenkins-slave/workspace/PreCommit-HDFS-Build/trunk/
dev-support/test-patch.sh: line 713: [: hadoop-hdfs-project/hadoop-hdfs:
binary operator expected
{noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HADOOP-9037) Bug in test-patch.sh and precommit build process

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-9037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13497236#comment-13497236 ] 

Hadoop QA commented on HADOOP-9037:
-----------------------------------

{color:green}+1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12553510/hadoop-9037.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1745//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1745//console

This message is automatically generated.
                
> Bug in test-patch.sh and precommit build process
> ------------------------------------------------
>
>                 Key: HADOOP-9037
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9037
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 3.0.0
>            Reporter: Kihwal Lee
>            Assignee: Kihwal Lee
>            Priority: Critical
>         Attachments: hadoop-9037.patch
>
>
> In HDFS-4171, the precommit build failed, but it still posted +1 for every category.  
> {noformat}
> ======================================================================
> ======================================================================
>     Running tests.
> ======================================================================
> ======================================================================
> /home/jenkins/jenkins-slave/workspace/PreCommit-HDFS-Build/trunk/
> dev-support/test-patch.sh: line 713: [: hadoop-hdfs-project/hadoop-hdfs:
> binary operator expected
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HADOOP-9037) Bug in test-patch.sh and precommit build process

Posted by "Kihwal Lee (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-9037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kihwal Lee updated HADOOP-9037:
-------------------------------

    Status: Patch Available  (was: Open)
    
> Bug in test-patch.sh and precommit build process
> ------------------------------------------------
>
>                 Key: HADOOP-9037
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9037
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 3.0.0
>            Reporter: Kihwal Lee
>            Assignee: Kihwal Lee
>            Priority: Critical
>         Attachments: hadoop-9037.patch
>
>
> In HDFS-4171, the precommit build failed, but it still posted +1 for every category.  
> {noformat}
> ======================================================================
> ======================================================================
>     Running tests.
> ======================================================================
> ======================================================================
> /home/jenkins/jenkins-slave/workspace/PreCommit-HDFS-Build/trunk/
> dev-support/test-patch.sh: line 713: [: hadoop-hdfs-project/hadoop-hdfs:
> binary operator expected
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HADOOP-9037) Bug in test-patch.sh and precommit build process

Posted by "Kihwal Lee (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-9037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kihwal Lee updated HADOOP-9037:
-------------------------------

    Attachment: hadoop-9037.patch

The patch adds quotes around the argument to the unary operator. It may have a leading space, but that only happens when there actually is a module, so the "-n" test is still valid.
                
> Bug in test-patch.sh and precommit build process
> ------------------------------------------------
>
>                 Key: HADOOP-9037
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9037
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 3.0.0
>            Reporter: Kihwal Lee
>            Assignee: Kihwal Lee
>            Priority: Critical
>         Attachments: hadoop-9037.patch
>
>
> In HDFS-4171, the precommit build failed, but it still posted +1 for every category.  
> {noformat}
> ======================================================================
> ======================================================================
>     Running tests.
> ======================================================================
> ======================================================================
> /home/jenkins/jenkins-slave/workspace/PreCommit-HDFS-Build/trunk/
> dev-support/test-patch.sh: line 713: [: hadoop-hdfs-project/hadoop-hdfs:
> binary operator expected
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Assigned] (HADOOP-9037) Bug in test-patch.sh and precommit build process

Posted by "Kihwal Lee (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-9037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kihwal Lee reassigned HADOOP-9037:
----------------------------------

    Assignee: Kihwal Lee
    
> Bug in test-patch.sh and precommit build process
> ------------------------------------------------
>
>                 Key: HADOOP-9037
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9037
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 3.0.0
>            Reporter: Kihwal Lee
>            Assignee: Kihwal Lee
>            Priority: Critical
>
> In HDFS-4171, the precommit build failed, but it still posted +1 for every category.  
> {noformat}
> ======================================================================
> ======================================================================
>     Running tests.
> ======================================================================
> ======================================================================
> /home/jenkins/jenkins-slave/workspace/PreCommit-HDFS-Build/trunk/
> dev-support/test-patch.sh: line 713: [: hadoop-hdfs-project/hadoop-hdfs:
> binary operator expected
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HADOOP-9037) Bug in test-patch.sh and precommit build process

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-9037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13497282#comment-13497282 ] 

Hudson commented on HADOOP-9037:
--------------------------------

Integrated in Hadoop-trunk-Commit #3017 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/3017/])
    HADOOP-9037. Bug in test-patch.sh and precommit build process. Contributed by Kihwal Lee (Revision 1409274)

     Result = SUCCESS
jlowe : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1409274
Files : 
* /hadoop/common/trunk/dev-support/test-patch.sh
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt

                
> Bug in test-patch.sh and precommit build process
> ------------------------------------------------
>
>                 Key: HADOOP-9037
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9037
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 3.0.0
>            Reporter: Kihwal Lee
>            Assignee: Kihwal Lee
>            Priority: Critical
>             Fix For: 3.0.0
>
>         Attachments: hadoop-9037.patch
>
>
> In HDFS-4171, the precommit build failed, but it still posted +1 for every category.  
> {noformat}
> ======================================================================
> ======================================================================
>     Running tests.
> ======================================================================
> ======================================================================
> /home/jenkins/jenkins-slave/workspace/PreCommit-HDFS-Build/trunk/
> dev-support/test-patch.sh: line 713: [: hadoop-hdfs-project/hadoop-hdfs:
> binary operator expected
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HADOOP-9037) Bug in test-patch.sh and precommit build process

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-9037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13497927#comment-13497927 ] 

Hudson commented on HADOOP-9037:
--------------------------------

Integrated in Hadoop-Yarn-trunk #37 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/37/])
    HADOOP-9037. Bug in test-patch.sh and precommit build process. Contributed by Kihwal Lee (Revision 1409274)

     Result = SUCCESS
jlowe : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1409274
Files : 
* /hadoop/common/trunk/dev-support/test-patch.sh
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt

                
> Bug in test-patch.sh and precommit build process
> ------------------------------------------------
>
>                 Key: HADOOP-9037
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9037
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 3.0.0
>            Reporter: Kihwal Lee
>            Assignee: Kihwal Lee
>            Priority: Critical
>             Fix For: 3.0.0
>
>         Attachments: hadoop-9037.patch
>
>
> In HDFS-4171, the precommit build failed, but it still posted +1 for every category.  
> {noformat}
> ======================================================================
> ======================================================================
>     Running tests.
> ======================================================================
> ======================================================================
> /home/jenkins/jenkins-slave/workspace/PreCommit-HDFS-Build/trunk/
> dev-support/test-patch.sh: line 713: [: hadoop-hdfs-project/hadoop-hdfs:
> binary operator expected
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HADOOP-9037) Bug in test-patch.sh and precommit build process

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-9037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13498014#comment-13498014 ] 

Hudson commented on HADOOP-9037:
--------------------------------

Integrated in Hadoop-Mapreduce-trunk #1258 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1258/])
    HADOOP-9037. Bug in test-patch.sh and precommit build process. Contributed by Kihwal Lee (Revision 1409274)

     Result = FAILURE
jlowe : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1409274
Files : 
* /hadoop/common/trunk/dev-support/test-patch.sh
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt

                
> Bug in test-patch.sh and precommit build process
> ------------------------------------------------
>
>                 Key: HADOOP-9037
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9037
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 3.0.0
>            Reporter: Kihwal Lee
>            Assignee: Kihwal Lee
>            Priority: Critical
>             Fix For: 3.0.0
>
>         Attachments: hadoop-9037.patch
>
>
> In HDFS-4171, the precommit build failed, but it still posted +1 for every category.  
> {noformat}
> ======================================================================
> ======================================================================
>     Running tests.
> ======================================================================
> ======================================================================
> /home/jenkins/jenkins-slave/workspace/PreCommit-HDFS-Build/trunk/
> dev-support/test-patch.sh: line 713: [: hadoop-hdfs-project/hadoop-hdfs:
> binary operator expected
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HADOOP-9037) Bug in test-patch.sh and precommit build process

Posted by "Kihwal Lee (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-9037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13497210#comment-13497210 ] 

Kihwal Lee commented on HADOOP-9037:
------------------------------------

At line 713,
{noformat}
  if [ -n $hdfs_modules ]; then
{noformat}

{{$hdfs_modules}} was "hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs". Since "-n" is a unary operator, the {{test}} complained.
                
> Bug in test-patch.sh and precommit build process
> ------------------------------------------------
>
>                 Key: HADOOP-9037
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9037
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 3.0.0
>            Reporter: Kihwal Lee
>            Priority: Critical
>
> In HDFS-4171, the precommit build failed, but it still posted +1 for every category.  
> {noformat}
> ======================================================================
> ======================================================================
>     Running tests.
> ======================================================================
> ======================================================================
> /home/jenkins/jenkins-slave/workspace/PreCommit-HDFS-Build/trunk/
> dev-support/test-patch.sh: line 713: [: hadoop-hdfs-project/hadoop-hdfs:
> binary operator expected
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HADOOP-9037) Bug in test-patch.sh and precommit build process

Posted by "Jason Lowe (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-9037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13497264#comment-13497264 ] 

Jason Lowe commented on HADOOP-9037:
------------------------------------

+1 lgtm.
                
> Bug in test-patch.sh and precommit build process
> ------------------------------------------------
>
>                 Key: HADOOP-9037
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9037
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 3.0.0
>            Reporter: Kihwal Lee
>            Assignee: Kihwal Lee
>            Priority: Critical
>         Attachments: hadoop-9037.patch
>
>
> In HDFS-4171, the precommit build failed, but it still posted +1 for every category.  
> {noformat}
> ======================================================================
> ======================================================================
>     Running tests.
> ======================================================================
> ======================================================================
> /home/jenkins/jenkins-slave/workspace/PreCommit-HDFS-Build/trunk/
> dev-support/test-patch.sh: line 713: [: hadoop-hdfs-project/hadoop-hdfs:
> binary operator expected
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HADOOP-9037) Bug in test-patch.sh and precommit build process

Posted by "Jason Lowe (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-9037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jason Lowe updated HADOOP-9037:
-------------------------------

       Resolution: Fixed
    Fix Version/s: 3.0.0
     Hadoop Flags: Reviewed
           Status: Resolved  (was: Patch Available)

Thanks, Kihwal.  I committed this to trunk.
                
> Bug in test-patch.sh and precommit build process
> ------------------------------------------------
>
>                 Key: HADOOP-9037
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9037
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 3.0.0
>            Reporter: Kihwal Lee
>            Assignee: Kihwal Lee
>            Priority: Critical
>             Fix For: 3.0.0
>
>         Attachments: hadoop-9037.patch
>
>
> In HDFS-4171, the precommit build failed, but it still posted +1 for every category.  
> {noformat}
> ======================================================================
> ======================================================================
>     Running tests.
> ======================================================================
> ======================================================================
> /home/jenkins/jenkins-slave/workspace/PreCommit-HDFS-Build/trunk/
> dev-support/test-patch.sh: line 713: [: hadoop-hdfs-project/hadoop-hdfs:
> binary operator expected
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HADOOP-9037) Bug in test-patch.sh and precommit build process

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-9037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13497999#comment-13497999 ] 

Hudson commented on HADOOP-9037:
--------------------------------

Integrated in Hadoop-Hdfs-trunk #1227 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1227/])
    HADOOP-9037. Bug in test-patch.sh and precommit build process. Contributed by Kihwal Lee (Revision 1409274)

     Result = FAILURE
jlowe : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1409274
Files : 
* /hadoop/common/trunk/dev-support/test-patch.sh
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt

                
> Bug in test-patch.sh and precommit build process
> ------------------------------------------------
>
>                 Key: HADOOP-9037
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9037
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 3.0.0
>            Reporter: Kihwal Lee
>            Assignee: Kihwal Lee
>            Priority: Critical
>             Fix For: 3.0.0
>
>         Attachments: hadoop-9037.patch
>
>
> In HDFS-4171, the precommit build failed, but it still posted +1 for every category.  
> {noformat}
> ======================================================================
> ======================================================================
>     Running tests.
> ======================================================================
> ======================================================================
> /home/jenkins/jenkins-slave/workspace/PreCommit-HDFS-Build/trunk/
> dev-support/test-patch.sh: line 713: [: hadoop-hdfs-project/hadoop-hdfs:
> binary operator expected
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira