[GitHub] [trafficserver] shinrich commented on a change in pull request #6870: Generalize SNI support

[GitBox <gi...@apache.org>]

shinrich commented on a change in pull request #6870:
URL: https://github.com/apache/trafficserver/pull/6870#discussion_r566231932



##########
File path: iocore/net/P_SNIActionPerformer.h
##########
@@ -261,14 +264,14 @@ class TLSValidProtocols : public ActionItem
   TLSValidProtocols() : protocol_mask(max_mask) {}
   TLSValidProtocols(unsigned long protocols) : unset(false), protocol_mask(protocols) {}
   int
-  SNIAction(Continuation *cont, const Context & /* ctx */) const override
+  SNIAction(TLSSNISupport *snis, const Context & /* ctx */) const override
   {
     if (!unset) {
-      auto ssl_vc = dynamic_cast<SSLNetVConnection *>(cont);
+      auto ssl_vc = dynamic_cast<SSLNetVConnection *>(snis);

Review comment:
       Looking through this, I realize there is no value to doing the dynamic_cast here as opposed to a static_cast since we don't bother to check the return value.   That is an issue that predates this PR, so I'll put up a separate PR for that.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org