You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Sumit Mohanty <sm...@hortonworks.com> on 2015/09/10 03:28:26 UTC
Review Request 38243: Ambari should support custom stack names
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38243/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez and Sid Wagle.
Bugs: AMBARI-12597
https://issues.apache.org/jira/browse/AMBARI-12597
Repository: ambari
Description
-------
Ambari should support custom stack names - when custom stack names are used the parsing logic should parse only the version. This fix assumes that custom stacks are named XYZ-VERSION.NAME where XYZ is the type and Version is integers separated by dots and then any string as name.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryVersionEntity.java 0fb2f10
ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceDirectory.java 25c2260
ambari-server/src/main/java/org/apache/ambari/server/stack/StackDirectory.java 89c10c6
ambari-server/src/main/java/org/apache/ambari/server/utils/VersionUtils.java 4d1fc48
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProviderTest.java 442bcb2
ambari-server/src/test/java/org/apache/ambari/server/utils/TestVersionUtils.java 433d1c9
Diff: https://reviews.apache.org/r/38243/diff/
Testing
-------
Added unit tests, ran relevant unit tests.
Thanks,
Sumit Mohanty
Re: Review Request 38243: Ambari should support custom stack names
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38243/#review98440
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On Sept. 10, 2015, 1:28 a.m., Sumit Mohanty wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38243/
> -----------------------------------------------------------
>
> (Updated Sept. 10, 2015, 1:28 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Sid Wagle.
>
>
> Bugs: AMBARI-12597
> https://issues.apache.org/jira/browse/AMBARI-12597
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Ambari should support custom stack names - when custom stack names are used the parsing logic should parse only the version. This fix assumes that custom stacks are named XYZ-VERSION.NAME where XYZ is the type and Version is integers separated by dots and then any string as name.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryVersionEntity.java 0fb2f10
> ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceDirectory.java 25c2260
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackDirectory.java 89c10c6
> ambari-server/src/main/java/org/apache/ambari/server/utils/VersionUtils.java 4d1fc48
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProviderTest.java 442bcb2
> ambari-server/src/test/java/org/apache/ambari/server/utils/TestVersionUtils.java 433d1c9
>
> Diff: https://reviews.apache.org/r/38243/diff/
>
>
> Testing
> -------
>
> Added unit tests, ran relevant unit tests.
>
>
> Thanks,
>
> Sumit Mohanty
>
>