You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Mike Percy (Code Review)" <ge...@cloudera.org> on 2017/11/29 08:02:09 UTC
[kudu-CR] Improve make site.sh validation checks for git remotes
Mike Percy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8677
Change subject: Improve make_site.sh validation checks for git remotes
......................................................................
Improve make_site.sh validation checks for git remotes
This was using the "apache" remote and giving a confusing error when it
was not set. We'll use "origin" and do a better job of validating that
it's set.
Change-Id: I1bf22ad01706319f0e5a9a2beb99d21511393f42
---
M docs/support/scripts/make_site.sh
1 file changed, 7 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/77/8677/1
--
To view, visit http://gerrit.cloudera.org:8080/8677
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1bf22ad01706319f0e5a9a2beb99d21511393f42
Gerrit-Change-Number: 8677
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
[kudu-CR] Improve make site.sh validation checks for git remotes
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8677 )
Change subject: Improve make_site.sh validation checks for git remotes
......................................................................
Improve make_site.sh validation checks for git remotes
This was using the "apache" remote and giving a confusing error when it
was not set. We'll use "origin" and do a better job of validating that
it's set.
Change-Id: I1bf22ad01706319f0e5a9a2beb99d21511393f42
Reviewed-on: http://gerrit.cloudera.org:8080/8677
Reviewed-by: Mike Percy <mp...@apache.org>
Tested-by: Mike Percy <mp...@apache.org>
---
M docs/support/scripts/make_site.sh
1 file changed, 7 insertions(+), 1 deletion(-)
Approvals:
Mike Percy: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/8677
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I1bf22ad01706319f0e5a9a2beb99d21511393f42
Gerrit-Change-Number: 8677
Gerrit-PatchSet: 2
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] Improve make site.sh validation checks for git remotes
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8677 )
Change subject: Improve make_site.sh validation checks for git remotes
......................................................................
Patch Set 1: Verified+1 Code-Review+2
release stuff
--
To view, visit http://gerrit.cloudera.org:8080/8677
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1bf22ad01706319f0e5a9a2beb99d21511393f42
Gerrit-Change-Number: 8677
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Wed, 29 Nov 2017 08:02:46 +0000
Gerrit-HasComments: No