[GitHub] [lucene] gsmiller opened a new pull request, #11804: FacetsCollector#collect is no longer final to allow extension

[GitBox <gi...@apache.org>]

gsmiller opened a new pull request, #11804:
URL: https://github.com/apache/lucene/pull/11804

   ### Description
   
   I'd like to propose removing the `final` restriction on `FacetsCollector#collect` to allow extension. I have a use-case where I'd like to be able to throw a `CollectionTerminatedException` from a `FacetsCollector` after collecting a specified number of hits (this is a runtime optimization where we're OK faceting over a subset of all actual matches). Being able to extend `collect` would make this much simpler to achieve.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org

[GitHub] [lucene] gsmiller merged pull request #11804: FacetsCollector#collect is no longer final to allow extension

[GitBox <gi...@apache.org>]

gsmiller merged PR #11804:
URL: https://github.com/apache/lucene/pull/11804


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org