[GitHub] [airflow] vincbeck commented on a diff in pull request #29657: Add `wait_for_completion` param in `RedshiftCreateClusterOperator`

["vincbeck (via GitHub)" <gi...@apache.org>]

vincbeck commented on code in PR #29657:
URL: https://github.com/apache/airflow/pull/29657#discussion_r1113524200


##########
tests/providers/amazon/aws/operators/test_redshift_cluster.py:
##########
@@ -76,6 +77,10 @@ def test_create_single_node_cluster(self, mock_get_conn):
             **params,
         )
 
+        mock_get_conn.return_value.get_waiter.return_value.wait.assert_called_once_with(

Review Comment:
   We should test that the waiter is not called when `wait_for_completion` is `False`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org