You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@xtable.apache.org by "vinishjail97 (via GitHub)" <gi...@apache.org> on 2025/02/12 07:58:49 UTC

[PR] Handle timestamp_ntz in delta conversion target [incubator-xtable]

vinishjail97 opened a new pull request, #646:
URL: https://github.com/apache/incubator-xtable/pull/646

   ## *Important Read*
   - *Please ensure the GitHub issue is mentioned at the beginning of the PR*
   
   ## What is the purpose of the pull request
   
   Handle timestamp_ntz in delta target, this needs to be done in a better way by finding this function in delta codebase. 
   https://docs.delta.io/2.0.0/versioning.html 
   `When creating a table, Delta Lake chooses the minimum required protocol version based on table characteristics such as the schema or table properties
   `
   ## Brief change log
   
   *(for example:)*
   - * Handle timestamp_ntz in delta target*
   
   ## Verify this pull request
   
   *(Please pick either of the following options)*
   
   This pull request is a trivial rework / code cleanup without any test coverage.
   
   *(or)*
   
   This pull request is already covered by existing tests, such as *(please describe tests)*.
   
   (or)
   
   This change added tests and can be verified as follows:
   
   *(example:)*
   
   - *Added integration tests for end-to-end.*
   - *Added TestConversionController to verify the change.*
   - *Manually verified the change by running a job locally.*
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@xtable.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Handle timestamp_ntz in delta conversion target [incubator-xtable]

Posted by "vinishjail97 (via GitHub)" <gi...@apache.org>.
vinishjail97 commented on code in PR #646:
URL: https://github.com/apache/incubator-xtable/pull/646#discussion_r1952158986


##########
xtable-core/src/main/java/org/apache/xtable/delta/DeltaConversionTarget.java:
##########
@@ -66,9 +66,9 @@
 import org.apache.xtable.spi.sync.ConversionTarget;
 
 public class DeltaConversionTarget implements ConversionTarget {
-  private static final String MIN_READER_VERSION = String.valueOf(1);
+  private static final String MIN_READER_VERSION = String.valueOf(3);

Review Comment:
   Handle this gracefully by calling the function which upgrades version in delta codebase, this was the pending comment from the previous PR that wasn't addressed. 
   
   https://github.com/apache/incubator-xtable/pull/428 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@xtable.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Handle timestamp_ntz in delta conversion target [incubator-xtable]

Posted by "vinishjail97 (via GitHub)" <gi...@apache.org>.
vinishjail97 closed pull request #646: Handle timestamp_ntz in delta conversion target
URL: https://github.com/apache/incubator-xtable/pull/646


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@xtable.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org